Skip to content

[geogram] build geogram dynamic if crt linkage dynamic#13719

Merged
BillyONeal merged 3 commits intomicrosoft:masterfrom
xandox:build_geogram_dynamic_if_crt_linkage_dynamic
Oct 6, 2020
Merged

[geogram] build geogram dynamic if crt linkage dynamic#13719
BillyONeal merged 3 commits intomicrosoft:masterfrom
xandox:build_geogram_dynamic_if_crt_linkage_dynamic

Conversation

@xandox
Copy link
Contributor

@xandox xandox commented Sep 24, 2020

Fix installation for triplet x64-windows-static-md

  • What does your PR fix? Fixes #
    profile.cmake

  • Which triplets are supported/not supported? Have you updated the CI baseline?
    now support x64-windows-static-md triplet

  • Does your PR follow the maintainer guide?
    I hope

fix settings for switch to dynamic linkage
@LilyWangL LilyWangL changed the title build geogram dynamic if crt linkage dynamic [geogram] build geogram dynamic if crt linkage dynamic Sep 25, 2020
@LilyWangL LilyWangL added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Sep 25, 2020
@LilyWangL
Copy link
Contributor

Blocked by #13722.

@ras0219-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LilyWangL LilyWangL added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Sep 30, 2020
@xandox
Copy link
Contributor Author

xandox commented Oct 2, 2020

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 13719 in repo microsoft/vcpkg

@xandox
Copy link
Contributor Author

xandox commented Oct 2, 2020

@LilyWangL help! :)
How to rerun canceled checks?

@dan-shaw
Copy link
Contributor

dan-shaw commented Oct 6, 2020

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@BillyONeal BillyONeal merged commit 7f0ea80 into microsoft:master Oct 6, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants