Skip to content

[cpr/crc32c] Update version#13678

Merged
BillyONeal merged 6 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/manyports_20200923_3
Oct 13, 2020
Merged

[cpr/crc32c] Update version#13678
BillyONeal merged 6 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/manyports_20200923_3

Conversation

@JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Sep 23, 2020 •
edited
Loading

Continue PR #13558.
Special changes:

  • crc32: set it always build as a static library instead of set CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS to ON.

Related: #13536.

@JackBoosY JackBoosY added info:internal category:port-update The issue is with a library, which is requesting update new revision labels Sep 23, 2020
@JackBoosY JackBoosY changed the title [manyports] Update version 4 [cpr/crc32c/devil] Update version Sep 23, 2020
@JackBoosY JackBoosY changed the title [cpr/crc32c/devil] Update version [cpr/crc32c] Update version Sep 23, 2020
@JackBoosY JackBoosY requested review from NancyLi1013 and PhoebeHui and removed request for PhoebeHui September 23, 2020 08:32
@JackBoosY JackBoosY assigned NancyLi1013 and unassigned PhoebeHui Sep 23, 2020
@NancyLi1013 NancyLi1013 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Sep 24, 2020
ras0219-msft
ras0219-msft requested changes Sep 24, 2020
View reviewed changes
@NancyLi1013 NancyLi1013 removed the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Sep 25, 2020
JackBoosY
JackBoosY commented Sep 25, 2020
View reviewed changes
@JackBoosY
Copy link
Contributor Author

JackBoosY commented Sep 25, 2020

Blocked by #13722.

@JackBoosY
Copy link
Contributor Author

JackBoosY commented Sep 27, 2020

blocked by #13765.

ras0219-msft
ras0219-msft requested changes Sep 28, 2020
View reviewed changes
@JackBoosY
Copy link
Contributor Author

JackBoosY commented Oct 9, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 9, 2020

No pipelines are associated with this pull request.

@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Oct 9, 2020
@BillyONeal BillyONeal merged commit 26279b7 into microsoft:master Oct 13, 2020
@BillyONeal
Copy link
Member

BillyONeal commented Oct 13, 2020

Thanks for your contribution!

@JackBoosY JackBoosY deleted the dev/jack/manyports_20200923_3 branch October 14, 2020 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ras0219-msft ras0219-msft Awaiting requested review from ras0219-msft

1 more reviewer

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@NancyLi1013 NancyLi1013

Labels

category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JackBoosY @BillyONeal @ras0219-msft @NancyLi1013 @PhoebeHui