Skip to content

Various MinGW build fixes#11637

Closed
koprok wants to merge 6 commits intomicrosoft:masterfrom
koprok:mingw-build-fixes
Closed

Various MinGW build fixes#11637
koprok wants to merge 6 commits intomicrosoft:masterfrom
koprok:mingw-build-fixes

Conversation

@koprok
Copy link
Contributor

@koprok koprok commented May 28, 2020

  • Fix vcpkg_fixup_cmake_targets() to work for MinGW
  • Turn off missing import libs check for MinGW as it does not work
  • Fix MinGW build of following ports: openal-soft, glew, protobuf

@JackBoosY
Copy link
Contributor

Hmm...I don't know how many regressions are realted.

@koprok
Copy link
Contributor Author

koprok commented May 29, 2020

Hmm...I don't know how many regressions are realted.

@JackBoosY, I don't think the regressions are related to my changes. The only change that affects all ports is the one in vcpkg_fixup_cmake_targets and it's really trivial.

What do you suggest me to do?

I could split the port and triplet changes in a separate merge request. They won't cause rebuild of all ports and so no (detected) regressions? Do you want me to do it this way, so that the port and triplet changes can be merged easier / faster?

@JackBoosY
Copy link
Contributor

@koprok We are fixing CI errors now, please wait.

@JackBoosY
Copy link
Contributor

JackBoosY commented May 29, 2020

@JackBoosY
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Contributor

Okay, all regressions are tracked.

@JackBoosY
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY JackBoosY added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Jun 11, 2020
@JackBoosY
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@PhoebeHui
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@PhoebeHui
Copy link
Contributor

/azp run

@PhoebeHui PhoebeHui self-assigned this Jun 18, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@koprok koprok force-pushed the mingw-build-fixes branch from 94c642a to e2b6923 Compare June 24, 2020 07:21
@koprok koprok force-pushed the mingw-build-fixes branch from e2b6923 to 1c592e7 Compare June 24, 2020 07:43
@koprok
Copy link
Contributor Author

koprok commented Jun 25, 2020

Hi guys! I am going to split this merge request in two separate merge requests:

  • one that contains the changes to the ports only; I have also accumulated more port changes and I will add them too;
  • another one that contains only the change in vcpkg_fixup_cmake_targets; this is what causes complete rebuild of all ports and many regressions not related to my changes.

This way the changes to the ports (which are the most of my changes) could be merged much easier without having to resolve all other (unrelated) ports regressions before that.

@koprok koprok closed this Jun 25, 2020
@koprok koprok deleted the mingw-build-fixes branch June 25, 2020 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants