You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hmm...I don't know how many regressions are realted.
@JackBoosY, I don't think the regressions are related to my changes. The only change that affects all ports is the one in vcpkg_fixup_cmake_targets and it's really trivial.
What do you suggest me to do?
I could split the port and triplet changes in a separate merge request. They won't cause rebuild of all ports and so no (detected) regressions? Do you want me to do it this way, so that the port and triplet changes can be merged easier / faster?
Hi guys! I am going to split this merge request in two separate merge requests:
one that contains the changes to the ports only; I have also accumulated more port changes and I will add them too;
another one that contains only the change in vcpkg_fixup_cmake_targets; this is what causes complete rebuild of all ports and many regressions not related to my changes.
This way the changes to the ports (which are the most of my changes) could be merged much easier without having to resolve all other (unrelated) ports regressions before that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
category:vcpkg-featureThe issue is a new capability of the tool that doesn’t already exist and we haven’t committed
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.