[vcpkg baseline][libfabric] Only support dynamic build#11647
Merged
dan-shaw merged 1 commit intomicrosoft:masterfrom Jun 3, 2020
Merged
[vcpkg baseline][libfabric] Only support dynamic build#11647dan-shaw merged 1 commit intomicrosoft:masterfrom
dan-shaw merged 1 commit intomicrosoft:masterfrom
Conversation
JackBoosY
added
category:port-bug
JackBoosY
changed the title
BillyONeal
reviewed
May 30, 2020
| @@ -746,6 +746,7 @@ libfabric:x64-linux=fail | |||
| libfabric:x64-osx=fail | |||
| libfabric:x64-uwp=fail | |||
| libfabric:x64-windows=ignore | |||
Member
There was a problem hiding this comment.
It's a bit strange to have fail and ignore for the same port?
Contributor
Author
There was a problem hiding this comment.
I don't know...Maybe this port has file conflicts with other ports.
Contributor
|
Please tag 'reviewed' when ready to merge |
PhoebeHui
approved these changes
Jun 2, 2020
PhoebeHui
added
the
info:needs-maintainer-attention
Contributor
Author
|
@dan-shaw Added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no configuration information for building a static library in libfabric.vcxproj, so static building is disabled.
Related: #11637.