Skip to content

[vcpkg baseline][ocilib] Fix build failure#11646

Merged
dan-shaw merged 5 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/fix_ocilib_build
Jun 2, 2020
Merged

[vcpkg baseline][ocilib] Fix build failure#11646
dan-shaw merged 5 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/fix_ocilib_build

Conversation

@JackBoosY
Copy link
Contributor

The target architecture in different sln is different.

Related: #11637.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal labels May 29, 2020
@JackBoosY JackBoosY changed the title [ocilib] Fix build failure [vcpkg baseline][ocilib] Fix build failure May 29, 2020
@LilyWangL LilyWangL added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label May 29, 2020
@LilyWangL LilyWangL marked this pull request as ready for review May 29, 2020 10:28
@BillyONeal
Copy link
Member

This passes locally for me, what drove this change?

@JackBoosY
Copy link
Contributor Author

@BillyONeal This is indeed a port bug, it seems that the pipeline did not catch this error correctly.

@dan-shaw dan-shaw merged commit d0751cd into microsoft:master Jun 2, 2020
@JackBoosY JackBoosY deleted the dev/jack/fix_ocilib_build branch June 2, 2020 02:04
@BillyONeal
Copy link
Member

@JackBoosY I believe that it is a port bug, but it passes in CI and it passed for me locally, so I was hoping to have a more concrete analysis on why. Oh well, no problem, merged now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants