Skip to content

[vcpkg baseline][sdl2] Disable uwp build.#11648

Closed
JackBoosY wants to merge 1 commit intomicrosoft:masterfrom
JackBoosY:dev/jack/sdl2_disable_uwp_build
Closed

[vcpkg baseline][sdl2] Disable uwp build.#11648
JackBoosY wants to merge 1 commit intomicrosoft:masterfrom
JackBoosY:dev/jack/sdl2_disable_uwp_build

Conversation

@JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented May 29, 2020

F:\vcpkg\buildtrees\sdl2\src\SDL2-2-1f74301957\src\video\winrt\SDL_winrtgamebar.cpp(167): error C2065: '__FIEventHandler_1_IInspectable': undeclared identifier

This error seems by design or a upstream bug.
So disable uwp build now.

Related: #11637.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal labels May 29, 2020
@JackBoosY JackBoosY marked this pull request as ready for review May 29, 2020 09:47
@JackBoosY JackBoosY requested a review from PhoebeHui June 1, 2020 02:47
@JackBoosY
Copy link
Contributor Author

The macro __FIEventHandler_1_IInspectable has been moved to other header files in Windows 10 SDK 10.0.19041.0.
I've report this issue to upstream: https://bugzilla.libsdl.org/show_bug.cgi?id=5170

@JackBoosY
Copy link
Contributor Author

The upstream has been fixed this issue in master branch.

@JackBoosY JackBoosY marked this pull request as draft June 11, 2020 02:57
@JackBoosY JackBoosY closed this Jun 11, 2020
@JackBoosY JackBoosY deleted the dev/jack/sdl2_disable_uwp_build branch June 11, 2020 05:45
@JackBoosY
Copy link
Contributor Author

JackBoosY commented Jun 11, 2020

Will fixe in #11365.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants