Skip to content

[vcpkg baseline][osg] Fix build error when building plugin RestHttpDevice#11645

Closed
JackBoosY wants to merge 1 commit intomicrosoft:masterfrom
JackBoosY:dev/jack/fix_osg_asio_error
Closed

[vcpkg baseline][osg] Fix build error when building plugin RestHttpDevice#11645
JackBoosY wants to merge 1 commit intomicrosoft:masterfrom
JackBoosY:dev/jack/fix_osg_asio_error

Conversation

@JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented May 29, 2020

Use unofficial workaroud to fix build error:

/mnt/_work/1/s/buildtrees/osg/src/raph-3.6.4-c5448290ed/src/osgPlugins/RestHttpDevice/server.cpp:35:29: error: ‘error’ is not a member of ‘asio::placeholders’
         asio::placeholders::error));
                             ^~~~~

Related: #11502 #921.

Fix #11686

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal labels May 29, 2020
@JackBoosY JackBoosY changed the title [osg] Fix build error when building plugin RestHttpDevice [vcpkg baseline][osg] Fix build error when building plugin RestHttpDevice May 29, 2020
@JackBoosY JackBoosY marked this pull request as ready for review May 29, 2020 09:58
@JackBoosY JackBoosY requested a review from PhoebeHui May 29, 2020 09:58
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks because boost::bind follows asio's completion token protocol while std::bind does not.

@JackBoosY
Copy link
Contributor Author

@BillyONeal Hmm... do you have any suggestions to fix this issue?

@NancyLi1013 NancyLi1013 mentioned this pull request Jun 1, 2020
@JackBoosY JackBoosY closed this Jun 2, 2020
@JackBoosY JackBoosY deleted the dev/jack/fix_osg_asio_error branch June 2, 2020 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[osg] build failure

3 participants