add onRenderDescription to TextField#4576
Closed
chrismohr wants to merge 1083 commits intomicrosoft:masterfrom
chrismohr:onRenderDescription_for_TextField
Closed
add onRenderDescription to TextField#4576chrismohr wants to merge 1083 commits intomicrosoft:masterfrom chrismohr:onRenderDescription_for_TextField
chrismohr wants to merge 1083 commits intomicrosoft:masterfrom
chrismohr:onRenderDescription_for_TextField
Conversation
* convert scss to mergestyles * update snapshots * rush change * missing semicolon * update experiments snapshots * cleanup
* Fix issue 3608: DetailsList horizontal scroll * add change file
…value (#4159) * Switched ActionButton prop in Nav from description to ariaDescription * rush change
… children (#4171) * Wire a link to expand/collapse if it has no URL but has children * Add change file. * Update Nav_2018-03-03-08-32.json
* Use correct _list ref string * Update users-samuelmtimbo-fixlistresize_2018-03-03-00-16.json
* Add Keytips to src export to consume for testing * Add exports for keytip utilities * Add rush change file
* Replaced PureComponent with Component * Added change file
* commented out @Customizable decorator in Image.base * rush change
* Fix Facepile aria description * Adding changefile
* Initial implementation of React.createRef polyfill * Updates based on feedback * Updates to components with refs * Fix Type * Fix lint * Revert to original Experiment * Fix typing * Add typedef to docs * Add change files * Remove empty change files
* add clear input * add change file * fix tslint error
* Use DefaultButton instead of html button * npm run change output
* Initial bounce test * Opacity test * Forced opacity delay * got rid of plateau * bringing back comments * Added animation css to teaching bubble * cleaned up animation code in teaching bubble * Cleaning up css * Removed unused import * Added change file
…4200) * seperated out Persona and PersonaCoin components' SCSS * rush change * cleanup comment
* Add Keytips to src export to consume for testing * Add exports for keytip utilities * Add rush change file * Fix import from src in KeytipTree, was auto-imported
* Added overflowButtonAriaLabel * Updated examples to include aria labels for buttons * One more dismiss button label * Added change file
* Adding onPendingValueSet callback * Adding rush change file * Creating two props for preview and revert preview * Fixing some spaces * Changed description * Adding currentPendingValue back to address free form * Going back to onPendingValueChanged * Adding some comments * Renaming variable to sendUndefinedPendingValue * Reducing the logic to only send one callback * Simplifying logic * Changing the comment description * Fixing newPendingIndex condition
…ic class Functions (#4208) * Added a hoistStatics function to customizable decorator * added @Customizable decorator to Image and Layer * rush change * cleanup test code
* Convert scss to styles.ts (no classNames yet) * Use getStyles in base component. * Add base component class names * Make styles required. * Separate DialogContent styles and types * Move DialogContent className logic to styles file. * Organize props * Split DialogFooter styles and types * Comment and deprecate some props * Support isMultiline prop and clean up * private _className method * npm run change output * Update snapshot * Simplify styles conditionals * Delete sass file * Add fallbacks for className checks. * Simplify stylesets with no styles * Move default width variables to style props. * better className fallbacks * nit * Fix font weight. * Add className to footer and fix type issues. * Fix more type errors * Add hoistStatics function to @withResponsiveMode decorator * npm run change output
* Match a url that has navigated to a location in page * Modified page paths * Removed baseRoute and added comment * Repurposing pageroute utility * Revert "Repurposing pageroute utility" This reverts commit 8a086bb. * Repurposing pageroute utility * Code cleanup * Added change file * Removed spaces * Counting hashes * Semicolons
* Setting up an example with shimmer tiles. * Adds some logic to fake some shimmer tiles. * Imports shimmer inside TileList. * Reuse the _getCells function to create fake Shimmer Tiles. * Break point before changing Tile. * Adds a Shimmer tile to Tile component. * Adds logic to Tile in case the content is not passed. * Refactors the example helpers and adds new proprietes to GridItem and GridSegment. * Refactors some logic. * Changes the logic for changes in TilesList. Moves getShimmerCell as a private member of Tile class. * Changes Tile 'shimmerPlaceholder' prop name to 'asPlaceholder'. Applies a different logic to the margin replaced by border. * Renames props and styles in Tile * Break point to test some new things. * Exports the TileLayoutValues enum. * Duplicate ShimmerLine to put basics for ShimmerGap. * Removes unnecessary checks and moves functions outside for re-usability. * Change the name of maxHeight to maxLineHeight for better semantics. * Extracts another function for reusability purposes. * Renames again a prop for semantics reasons. * Cleans up code. * Renames a prop for semantics. * Duplicates a folder as base for ShimmerTile component. * Sets up props for ShimmerTile * Exports a const for reusability. * Creates a new example for ShimmerTile. * Removes a file. * Adds initial elements for testing * Brings logic in TilesList and sets up an example. * Updates some styling in the TilesList example. * Change name of a constant for semantics. * Sets a checkbox to toggle sizes. Fixes Firefox border rounding decimal value of pixels. * Fixes build errors. * Rush change log. * Changes type 'JSX.Element[] | JSX.Elelment' to React.ReactNode. * Removes import. * Removes the import statement.
…menu (#4517) * SplitButton: Allow the primary portion of a splitButton (when it a menu) to collapse a submenu * rush change * Clear the submenu props off of the item when handling the hover events not on the expandable portion of the control. * Remove unneeeded comment update
* Update docs explaining the stale bot usage * Removed personal info
* Slow down stale bot until we complete our April triage sprint.
* Implemented styling package's animation * Added change file * Removed string typing for build error * Export pulsing beacon animation style * bundlesize
* SpinButton: Cancel the up/down arrow keys when inside of a spinButton to make sure they don't leak outside of the spinButton (especially when inside of a FocusZone) * rush change * Remove extra 's' in the comment I added
chrismohr
requested review from
Jahnp,
KatherineThayerMicrosoft,
ThomasMichon,
aditima,
atneik,
cschleiden,
dzearing,
joschect,
lorejoh12,
micahgodbolt,
mikewheaton,
phkuo,
srideshpande and
yiminwu
as code owners
Member
|
looks like you've pulled in a bunch of unexpected changes. Go grab a fresh fork of master, and make your change again. Going to close this down so people aren't getting spammed. |
1 task
Contributor
Author
|
Thanks @micahgodbolt, here's the new pr: #4588 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Add onRenderDescription to TextField. Since description only takes a
string, this allows us to render a description with additional markup, like a link for example.