Coachmark: Pulsing beacon animation was moved to Styling#4473
Merged
lynamemi merged 6 commits intomicrosoft:masterfrom Apr 12, 2018
Merged
Coachmark: Pulsing beacon animation was moved to Styling#4473lynamemi merged 6 commits intomicrosoft:masterfrom
lynamemi merged 6 commits intomicrosoft:masterfrom
Conversation
Collaborator
Author
|
@dzearing need a bundlesize bump. |
leddie24
approved these changes
Apr 10, 2018
Collaborator
leddie24
left a comment
leddie24
left a comment
There was a problem hiding this comment.
Not 100% familiar with the code, but it looks good. There's some almost redundant bits of code from lines 262-269, and 282-288, and 299-305. Is there a way we can simplify this?
Collaborator
Author
|
@leddie24 Great points, thanks for taking a look. Since those lines deal with different animations, I lean towards leaving them for now but looking into refactoring in the future if everyone is ok with that. |
phkuo
approved these changes
Apr 11, 2018
dzearing
approved these changes
Apr 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Moved the pulsing beacon animation to the Styling package in this PR: #4446
The design and behavior has not changed.
Focus areas to test
(optional)