Skip to content

MessageBar: Dismiss button and overflow button aria labels#4166

Merged
lynamemi merged 4 commits intomicrosoft:masterfrom
lynamemi:messagebar-aria
Mar 7, 2018
Merged

MessageBar: Dismiss button and overflow button aria labels#4166
lynamemi merged 4 commits intomicrosoft:masterfrom
lynamemi:messagebar-aria

Conversation

@lynamemi
Copy link
Copy Markdown
Collaborator

@lynamemi lynamemi commented Mar 2, 2018

Pull request checklist

Description of changes

  • Examples weren't using the dismiss button's aria label
  • The overflow button for use with there is truncated text did not have an aria label implementation

Focus areas to test

(optional)

Copy link
Copy Markdown
Member

@betrue-final-final betrue-final-final left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great! Confirmed on Narrator.

@lynamemi lynamemi merged commit 2cf6fef into microsoft:master Mar 7, 2018
@lynamemi lynamemi deleted the messagebar-aria branch March 7, 2018 23:20
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Messagebar close button has no screen reader label

2 participants