Change docs for hidden to state true by default#4519
Merged
micahgodbolt merged 1 commit intomicrosoft:masterfrom Apr 12, 2018
micahgodbolt:dialog-docs
Merged
Change docs for hidden to state true by default#4519micahgodbolt merged 1 commit intomicrosoft:masterfrom micahgodbolt:dialog-docs
micahgodbolt merged 1 commit intomicrosoft:masterfrom
micahgodbolt:dialog-docs
Conversation
manishgarg1
approved these changes
Apr 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
As per issue, this isn't the greatest fix. Our guidelines state that Boolean props should always have 'true' as the exception (therefore false by default). But in this case, changing the behavior of the Dialog would be a large breaking change entailing reworking of a ton of components... so better to at least have the docs reflect the current state, even if not optimum.