Skip to content

Facepile conditionally rendering aria-describedby#4183

Merged
dzearing merged 2 commits intomicrosoft:masterfrom
FalseLobster:FirstBug
Mar 6, 2018
Merged

Facepile conditionally rendering aria-describedby#4183
dzearing merged 2 commits intomicrosoft:masterfrom
FalseLobster:FirstBug

Conversation

@FalseLobster
Copy link
Copy Markdown
Contributor

Pull request checklist

Description of changes

Updating Facepile so that aria-describedby is only rendered when needed

@msftclas
Copy link
Copy Markdown

msftclas commented Mar 5, 2018

CLA assistant check
All CLA requirements met.

@FalseLobster FalseLobster changed the title First bug Facepile conditionally rendering aria-describedby Mar 5, 2018
@dzearing dzearing merged commit 0ccc7bd into microsoft:master Mar 6, 2018
Markionium added a commit to Markionium/office-ui-fabric-react that referenced this pull request Mar 6, 2018
* master:
  Applying package updates.
  Polyfill react create ref (microsoft#4182)
  [Pickers] Add async debounce option to BasePicker (microsoft#4163)
  Facepile conditionally rendering aria-describedby (microsoft#4183)
  Applying package updates.
  Addressing Issue microsoft#4174 - 5.59.0 crashing in <ImageBase> (microsoft#4185)
  Website fix: Remove PureComponent (microsoft#4186)
  Add Keytip and KeytipLayer to experiments export (microsoft#4184)
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accessibility in Facepile

4 participants