Skip to content

Conversation

@bigbadcapers
Copy link
Contributor

@bigbadcapers bigbadcapers commented Apr 27, 2023

New Behavior

  • Support .design files in the filetypeicons package.
  • Update folder bottom-edge seam dark yellow color to be accessible against more backgrounds
  • Changes tested using storybook.
  • yarn change

@size-auditor
Copy link

size-auditor bot commented Apr 27, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: ead9ba7beb543767206556636c7059e069979096 (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 27, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 95f0c25:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 27, 2023

📊 Bundle size report

🤖 This report was generated against ead9ba7beb543767206556636c7059e069979096

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 27, 2023

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 27, 2023

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 797 823 5000
Breadcrumb mount 2228 2219 1000
Checkbox mount 2176 2136 5000
CheckboxBase mount 1891 1869 5000
ChoiceGroup mount 3729 3732 5000
ComboBox mount 865 887 1000
CommandBar mount 8093 8040 1000
ContextualMenu mount 18242 18631 1000
DefaultButton mount 985 988 5000
DetailsRow mount 2899 2947 5000
DetailsRowFast mount 2909 2972 5000
DetailsRowNoStyles mount 2669 2698 5000
Dialog mount 3486 3493 1000
DocumentCardTitle mount 325 323 1000
Dropdown mount 2545 2559 5000
FocusTrapZone mount 1509 1516 5000
FocusZone mount 1455 1441 5000
GroupedList mount 58943 58987 2
GroupedList virtual-rerender 24425 24494 2
GroupedList virtual-rerender-with-unmount 75501 75581 2
GroupedListV2 mount 330 320 2
GroupedListV2 virtual-rerender 294 307 2
GroupedListV2 virtual-rerender-with-unmount 326 326 2
IconButton mount 1425 1425 5000
Label mount 467 459 5000
Layer mount 3630 3588 5000
Link mount 533 522 5000
MenuButton mount 1234 1232 5000
MessageBar mount 27530 27684 5000
Nav mount 2550 2532 1000
OverflowSet mount 1021 1010 5000
Panel mount 2290 2340 1000
Persona mount 984 966 1000
Pivot mount 1199 1185 1000
PrimaryButton mount 1111 1114 5000
Rating mount 5843 5849 5000
SearchBox mount 1189 1139 5000
Shimmer mount 2375 2369 5000
Slider mount 1731 1723 5000
SpinButton mount 3746 3750 5000
Spinner mount 529 520 5000
SplitButton mount 2444 2473 5000
Stack mount 540 532 5000
StackWithIntrinsicChildren mount 1150 1145 5000
StackWithTextChildren mount 3231 3239 5000
SwatchColorPicker mount 8217 8177 5000
TagPicker mount 2015 2013 5000
Text mount 496 500 5000
TextField mount 1202 1201 5000
ThemeProvider mount 1140 1125 5000
ThemeProvider virtual-rerender 776 780 5000
ThemeProvider virtual-rerender-with-unmount 1750 1736 5000
Toggle mount 795 814 5000
buttonNative mount 283 288 5000

@dzearing dzearing merged commit 46f19b9 into master Apr 28, 2023
@khmakoto khmakoto deleted the caperez/filetype_designer branch May 1, 2023 20:39
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request May 2, 2023
* master:
  applying package updates
  fix: dont ignore lib, lib-commonjs and lib-amd files (microsoft#27736)
  Add DraggableZone into export map (microsoft#27569)
  Add export for FolderCover.scss (microsoft#27507)
  applying package updates
  Add filetype icon for Microsoft Designer (microsoft#27724)
  ci: add build task back as lint pre-requirement to unblock temporarily import plugin lint rule (microsoft#27729)
  fix(react-charting): add missing dependency to fix lint violations during release (microsoft#27728)
  Added partition for controlled overflow menu (microsoft#27520)
  Azure Theme 8.0: Tag Button variant for DefaultButton and PrimaryButton (microsoft#27186)
  Azure Theme 8.0 dropdown fix for high contrast themes (microsoft#27346)
  chore: enable TS intellisense in cross library projects for better/consistent DX (microsoft#26605)
  chore: enforce files naming to use .styles.ts [cxe-red files] (microsoft#27710)
  chore(v0): enable emit only dts and use new conformance test API to narrow down TS Program (microsoft#27686)
  codeowner update (microsoft#27719)
  Tag/TagButton init component setup (microsoft#27102)
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request May 2, 2023
* feat/drawer-components: (120 commits)
  fix: add missing change file
  Component testing - Donut chart (microsoft#27033)
  fix: update .npmignore files to resolve npm8/node16 regression with npm publish for v9 packages (microsoft#27741)
  chore: add .swcrc to .npmignore (generator) (microsoft#27739)
  docs: update API
  Autogenerate react-toast package (microsoft#27730)
  applying package updates
  fix: dont ignore lib, lib-commonjs and lib-amd files (microsoft#27736)
  Add DraggableZone into export map (microsoft#27569)
  Add export for FolderCover.scss (microsoft#27507)
  applying package updates
  Add filetype icon for Microsoft Designer (microsoft#27724)
  ci: add build task back as lint pre-requirement to unblock temporarily import plugin lint rule (microsoft#27729)
  fix(react-charting): add missing dependency to fix lint violations during release (microsoft#27728)
  Added partition for controlled overflow menu (microsoft#27520)
  Azure Theme 8.0: Tag Button variant for DefaultButton and PrimaryButton (microsoft#27186)
  Azure Theme 8.0 dropdown fix for high contrast themes (microsoft#27346)
  chore: enable TS intellisense in cross library projects for better/consistent DX (microsoft#26605)
  chore: enforce files naming to use .styles.ts [cxe-red files] (microsoft#27710)
  chore(v0): enable emit only dts and use new conformance test API to narrow down TS Program (microsoft#27686)
  ...
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants