Autogenerate react-toast package #27730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ling1726
requested review from
a team,
JustSlone,
jurokapsiar and
tudorpopams
as code owners
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 710 | 696 | 5000 | |
| Button | mount | 398 | 395 | 5000 | |
| Field | mount | 1223 | 1229 | 5000 | |
| FluentProvider | mount | 780 | 777 | 5000 | |
| FluentProviderWithTheme | mount | 104 | 105 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 92 | 92 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 105 | 110 | 10 | |
| InfoButton | mount | 20 | 17 | 5000 | |
| MakeStyles | mount | 1196 | 1183 | 50000 | |
| Persona | mount | 1918 | 1877 | 5000 | |
| SpinButton | mount | 1463 | 1486 | 5000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: e9c67ecb4f3b0ee1ee355e2c8eec17afa0b20a5a (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 95d8646:
|
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| RefMinimalPerf.default | 146 | 131 | 1.11:1 |
| ButtonMinimalPerf.default | 122 | 111 | 1.1:1 |
| VideoMinimalPerf.default | 563 | 524 | 1.07:1 |
| FormMinimalPerf.default | 298 | 282 | 1.06:1 |
| AttachmentMinimalPerf.default | 101 | 97 | 1.04:1 |
| AvatarMinimalPerf.default | 148 | 142 | 1.04:1 |
| CheckboxMinimalPerf.default | 1373 | 1320 | 1.04:1 |
| CarouselMinimalPerf.default | 323 | 314 | 1.03:1 |
| ChatDuplicateMessagesPerf.default | 194 | 189 | 1.03:1 |
| DividerMinimalPerf.default | 278 | 271 | 1.03:1 |
| MenuMinimalPerf.default | 660 | 640 | 1.03:1 |
| SliderMinimalPerf.default | 852 | 825 | 1.03:1 |
| StatusMinimalPerf.default | 547 | 533 | 1.03:1 |
| AccordionMinimalPerf.default | 113 | 111 | 1.02:1 |
| AlertMinimalPerf.default | 200 | 196 | 1.02:1 |
| BoxMinimalPerf.default | 267 | 261 | 1.02:1 |
| DropdownManyItemsPerf.default | 477 | 469 | 1.02:1 |
| GridMinimalPerf.default | 273 | 267 | 1.02:1 |
| HeaderSlotsPerf.default | 628 | 617 | 1.02:1 |
| ItemLayoutMinimalPerf.default | 908 | 887 | 1.02:1 |
| LayoutMinimalPerf.default | 276 | 270 | 1.02:1 |
| ProviderMinimalPerf.default | 261 | 255 | 1.02:1 |
| ReactionMinimalPerf.default | 295 | 289 | 1.02:1 |
| TreeWith60ListItems.default | 110 | 108 | 1.02:1 |
| ChatWithPopoverPerf.default | 244 | 241 | 1.01:1 |
| DialogMinimalPerf.default | 619 | 611 | 1.01:1 |
| EmbedMinimalPerf.default | 2069 | 2047 | 1.01:1 |
| InputMinimalPerf.default | 671 | 663 | 1.01:1 |
| ListNestedPerf.default | 418 | 414 | 1.01:1 |
| MenuButtonMinimalPerf.default | 1197 | 1190 | 1.01:1 |
| RosterPerf.default | 1645 | 1626 | 1.01:1 |
| ProviderMergeThemesPerf.default | 857 | 847 | 1.01:1 |
| CustomToolbarPrototype.default | 1851 | 1830 | 1.01:1 |
| AttachmentSlotsPerf.default | 785 | 785 | 1:1 |
| FlexMinimalPerf.default | 214 | 215 | 1:1 |
| LoaderMinimalPerf.default | 235 | 234 | 1:1 |
| PopupMinimalPerf.default | 473 | 475 | 1:1 |
| PortalMinimalPerf.default | 120 | 120 | 1:1 |
| SplitButtonMinimalPerf.default | 2745 | 2755 | 1:1 |
| IconMinimalPerf.default | 490 | 491 | 1:1 |
| TreeMinimalPerf.default | 608 | 606 | 1:1 |
| CardMinimalPerf.default | 392 | 395 | 0.99:1 |
| DropdownMinimalPerf.default | 1754 | 1767 | 0.99:1 |
| HeaderMinimalPerf.default | 275 | 278 | 0.99:1 |
| ImageMinimalPerf.default | 293 | 296 | 0.99:1 |
| LabelMinimalPerf.default | 306 | 308 | 0.99:1 |
| ListCommonPerf.default | 497 | 500 | 0.99:1 |
| ListMinimalPerf.default | 406 | 412 | 0.99:1 |
| ListWith60ListItems.default | 471 | 475 | 0.99:1 |
| SegmentMinimalPerf.default | 267 | 269 | 0.99:1 |
| TableManyItemsPerf.default | 1407 | 1418 | 0.99:1 |
| TableMinimalPerf.default | 314 | 318 | 0.99:1 |
| TooltipMinimalPerf.default | 1596 | 1618 | 0.99:1 |
| ButtonOverridesMissPerf.default | 765 | 782 | 0.98:1 |
| ChatMinimalPerf.default | 566 | 575 | 0.98:1 |
| RadioGroupMinimalPerf.default | 353 | 359 | 0.98:1 |
| TextMinimalPerf.default | 262 | 266 | 0.98:1 |
| TextAreaMinimalPerf.default | 360 | 366 | 0.98:1 |
| ToolbarMinimalPerf.default | 674 | 686 | 0.98:1 |
| AnimationMinimalPerf.default | 381 | 391 | 0.97:1 |
| SkeletonMinimalPerf.default | 263 | 270 | 0.97:1 |
| ButtonSlotsPerf.default | 359 | 380 | 0.94:1 |
| DatepickerMinimalPerf.default | 4498 | 4800 | 0.94:1 |
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
Collaborator
🕵 FluentUI-v0 No visual regressions between this PR and main |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 842 | 836 | 5000 | |
| Breadcrumb | mount | 2216 | 2241 | 1000 | |
| Checkbox | mount | 2172 | 2162 | 5000 | |
| CheckboxBase | mount | 1907 | 1919 | 5000 | |
| ChoiceGroup | mount | 3752 | 3806 | 5000 | |
| ComboBox | mount | 875 | 884 | 1000 | |
| CommandBar | mount | 8105 | 8133 | 1000 | |
| ContextualMenu | mount | 16785 | 17740 | 1000 | |
| DefaultButton | mount | 981 | 965 | 5000 | |
| DetailsRow | mount | 2931 | 2952 | 5000 | |
| DetailsRowFast | mount | 2927 | 2907 | 5000 | |
| DetailsRowNoStyles | mount | 2681 | 2708 | 5000 | |
| Dialog | mount | 3501 | 3472 | 1000 | |
| DocumentCardTitle | mount | 312 | 320 | 1000 | |
| Dropdown | mount | 2559 | 2656 | 5000 | |
| FocusTrapZone | mount | 1524 | 1512 | 5000 | |
| FocusZone | mount | 1467 | 1459 | 5000 | |
| GroupedList | mount | 50648 | 58860 | 2 | |
| GroupedList | virtual-rerender | 24464 | 24449 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 75137 | 74957 | 2 | |
| GroupedListV2 | mount | 316 | 306 | 2 | |
| GroupedListV2 | virtual-rerender | 308 | 302 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 323 | 326 | 2 | |
| IconButton | mount | 1393 | 1467 | 5000 | |
| Label | mount | 461 | 473 | 5000 | |
| Layer | mount | 3559 | 3617 | 5000 | |
| Link | mount | 532 | 540 | 5000 | |
| MenuButton | mount | 1239 | 1244 | 5000 | |
| MessageBar | mount | 27497 | 27511 | 5000 | |
| Nav | mount | 2571 | 2564 | 1000 | |
| OverflowSet | mount | 1015 | 1010 | 5000 | |
| Panel | mount | 2251 | 2272 | 1000 | |
| Persona | mount | 988 | 991 | 1000 | |
| Pivot | mount | 1161 | 1183 | 1000 | |
| PrimaryButton | mount | 1114 | 1110 | 5000 | |
| Rating | mount | 5803 | 5770 | 5000 | |
| SearchBox | mount | 1144 | 1176 | 5000 | |
| Shimmer | mount | 2397 | 2338 | 5000 | |
| Slider | mount | 1720 | 1751 | 5000 | |
| SpinButton | mount | 3765 | 3837 | 5000 | |
| Spinner | mount | 511 | 514 | 5000 | |
| SplitButton | mount | 2423 | 2445 | 5000 | |
| Stack | mount | 533 | 538 | 5000 | |
| StackWithIntrinsicChildren | mount | 1133 | 1137 | 5000 | |
| StackWithTextChildren | mount | 3234 | 3230 | 5000 | |
| SwatchColorPicker | mount | 8138 | 8236 | 5000 | |
| TagPicker | mount | 2045 | 1996 | 5000 | |
| Text | mount | 497 | 498 | 5000 | |
| TextField | mount | 1197 | 1206 | 5000 | |
| ThemeProvider | mount | 1134 | 1138 | 5000 | |
| ThemeProvider | virtual-rerender | 780 | 780 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1740 | 1737 | 5000 | |
| Toggle | mount | 795 | 805 | 5000 | |
| buttonNative | mount | 284 | 282 | 5000 |
tudorpopams
approved these changes
Apr 28, 2023
JustSlone
approved these changes
May 1, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
May 2, 2023
* feat/drawer-components: docs: update API Autogenerate react-toast package (microsoft#27730)
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
May 2, 2023
* feat/drawer-components: (120 commits) fix: add missing change file Component testing - Donut chart (microsoft#27033) fix: update .npmignore files to resolve npm8/node16 regression with npm publish for v9 packages (microsoft#27741) chore: add .swcrc to .npmignore (generator) (microsoft#27739) docs: update API Autogenerate react-toast package (microsoft#27730) applying package updates fix: dont ignore lib, lib-commonjs and lib-amd files (microsoft#27736) Add DraggableZone into export map (microsoft#27569) Add export for FolderCover.scss (microsoft#27507) applying package updates Add filetype icon for Microsoft Designer (microsoft#27724) ci: add build task back as lint pre-requirement to unblock temporarily import plugin lint rule (microsoft#27729) fix(react-charting): add missing dependency to fix lint violations during release (microsoft#27728) Added partition for controlled overflow menu (microsoft#27520) Azure Theme 8.0: Tag Button variant for DefaultButton and PrimaryButton (microsoft#27186) Azure Theme 8.0 dropdown fix for high contrast themes (microsoft#27346) chore: enable TS intellisense in cross library projects for better/consistent DX (microsoft#26605) chore: enforce files naming to use .styles.ts [cxe-red files] (microsoft#27710) chore(v0): enable emit only dts and use new conformance test API to narrow down TS Program (microsoft#27686) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title