chore: enforce files naming to use .styles.ts [cxe-red files] #27710
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8d267ef:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 8232a5a7f2d7535ac7d0cd4af455ea6e70e9f613 (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | mount | 145 | 147 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 125 | 127 | 10 | Possible regression |
| InfoButton | mount | 24 | 25 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 878 | 835 | 5000 | |
| Button | mount | 447 | 434 | 5000 | |
| Field | mount | 1495 | 1471 | 5000 | |
| FluentProvider | mount | 1057 | 1096 | 5000 | |
| FluentProviderWithTheme | mount | 145 | 147 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender | 111 | 105 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 125 | 127 | 10 | Possible regression |
| InfoButton | mount | 24 | 25 | 5000 | Possible regression |
| MakeStyles | mount | 1313 | 1332 | 50000 | |
| Persona | mount | 2451 | 2350 | 5000 | |
| SpinButton | mount | 1830 | 1862 | 5000 |
📊 Bundle size reportUnchanged fixtures
|
🕵 fluentuiv9 No visual regressions between this PR and main |
layershifter
requested review from
a team,
behowell,
khmakoto,
micahgodbolt,
sopranopillow,
spmonahan and
tomi-msft
as code owners
* master: applying package updates fix: dont ignore lib, lib-commonjs and lib-amd files (microsoft#27736) Add DraggableZone into export map (microsoft#27569) Add export for FolderCover.scss (microsoft#27507) applying package updates Add filetype icon for Microsoft Designer (microsoft#27724) ci: add build task back as lint pre-requirement to unblock temporarily import plugin lint rule (microsoft#27729) fix(react-charting): add missing dependency to fix lint violations during release (microsoft#27728) Added partition for controlled overflow menu (microsoft#27520) Azure Theme 8.0: Tag Button variant for DefaultButton and PrimaryButton (microsoft#27186) Azure Theme 8.0 dropdown fix for high contrast themes (microsoft#27346) chore: enable TS intellisense in cross library projects for better/consistent DX (microsoft#26605) chore: enforce files naming to use .styles.ts [cxe-red files] (microsoft#27710) chore(v0): enable emit only dts and use new conformance test API to narrow down TS Program (microsoft#27686) codeowner update (microsoft#27719) Tag/TagButton init component setup (microsoft#27102)
* feat/drawer-components: (120 commits) fix: add missing change file Component testing - Donut chart (microsoft#27033) fix: update .npmignore files to resolve npm8/node16 regression with npm publish for v9 packages (microsoft#27741) chore: add .swcrc to .npmignore (generator) (microsoft#27739) docs: update API Autogenerate react-toast package (microsoft#27730) applying package updates fix: dont ignore lib, lib-commonjs and lib-amd files (microsoft#27736) Add DraggableZone into export map (microsoft#27569) Add export for FolderCover.scss (microsoft#27507) applying package updates Add filetype icon for Microsoft Designer (microsoft#27724) ci: add build task back as lint pre-requirement to unblock temporarily import plugin lint rule (microsoft#27729) fix(react-charting): add missing dependency to fix lint violations during release (microsoft#27728) Added partition for controlled overflow menu (microsoft#27520) Azure Theme 8.0: Tag Button variant for DefaultButton and PrimaryButton (microsoft#27186) Azure Theme 8.0 dropdown fix for high contrast themes (microsoft#27346) chore: enable TS intellisense in cross library projects for better/consistent DX (microsoft#26605) chore: enforce files naming to use .styles.ts [cxe-red files] (microsoft#27710) chore(v0): enable emit only dts and use new conformance test API to narrow down TS Program (microsoft#27686) ...
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
5 participants
New Behavior
This PR removes
useCOMPONENTStyles.tsfiles touseCOMPONENTStyles.styles.tsfiles to follow Griffel's rule for naming files.The ESLint rule have not been enabled yet, this PR is a preparation to do that. Affects files owned by @microsoft/cxe-red
Change files are set to patch/prerelease as artifacts should be updated.
Related Issue(s)