Azure Theme 8.0: Tag Button variant for DefaultButton and PrimaryButton #27186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
📊 Bundle size report🤖 This report was generated against 61598b80568c53cacbd9f63a17c258264f345216 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: d9f8a815f9424d6174c4ef45ce3b977ffc28b67f (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 854faa7:
|
khmakoto
approved these changes
Apr 25, 2023
change/@fluentui-azure-themes-d76d2c27-2e5d-4c90-bb94-2d9e9ebb0ede.json
Outdated
Show resolved
Hide resolved
fabricteam
reviewed
Apr 27, 2023
| @@ -0,0 +1,7 @@ | |||
| { | |||
Collaborator
There was a problem hiding this comment.
🕵 fluentuiv8 Open the Visual Regressions report to inspect the 2 screenshots
✅ There was 0 screenshots added, 2 screenshots removed, 1045 screenshots unchanged, 0 screenshots with different dimensions and 0 screenshots with visible difference.
unknown 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Pivot - Overflow.Tabs - RTL.Narrow - Last tab selected.chromium.png | 0 | Removed |
| Pivot - Overflow.Tabs - RTL.Narrow - Overflow menu.chromium.png | 0 | Removed |
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
May 2, 2023
* master: applying package updates fix: dont ignore lib, lib-commonjs and lib-amd files (microsoft#27736) Add DraggableZone into export map (microsoft#27569) Add export for FolderCover.scss (microsoft#27507) applying package updates Add filetype icon for Microsoft Designer (microsoft#27724) ci: add build task back as lint pre-requirement to unblock temporarily import plugin lint rule (microsoft#27729) fix(react-charting): add missing dependency to fix lint violations during release (microsoft#27728) Added partition for controlled overflow menu (microsoft#27520) Azure Theme 8.0: Tag Button variant for DefaultButton and PrimaryButton (microsoft#27186) Azure Theme 8.0 dropdown fix for high contrast themes (microsoft#27346) chore: enable TS intellisense in cross library projects for better/consistent DX (microsoft#26605) chore: enforce files naming to use .styles.ts [cxe-red files] (microsoft#27710) chore(v0): enable emit only dts and use new conformance test API to narrow down TS Program (microsoft#27686) codeowner update (microsoft#27719) Tag/TagButton init component setup (microsoft#27102)
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
May 2, 2023
* feat/drawer-components: (120 commits) fix: add missing change file Component testing - Donut chart (microsoft#27033) fix: update .npmignore files to resolve npm8/node16 regression with npm publish for v9 packages (microsoft#27741) chore: add .swcrc to .npmignore (generator) (microsoft#27739) docs: update API Autogenerate react-toast package (microsoft#27730) applying package updates fix: dont ignore lib, lib-commonjs and lib-amd files (microsoft#27736) Add DraggableZone into export map (microsoft#27569) Add export for FolderCover.scss (microsoft#27507) applying package updates Add filetype icon for Microsoft Designer (microsoft#27724) ci: add build task back as lint pre-requirement to unblock temporarily import plugin lint rule (microsoft#27729) fix(react-charting): add missing dependency to fix lint violations during release (microsoft#27728) Added partition for controlled overflow menu (microsoft#27520) Azure Theme 8.0: Tag Button variant for DefaultButton and PrimaryButton (microsoft#27186) Azure Theme 8.0 dropdown fix for high contrast themes (microsoft#27346) chore: enable TS intellisense in cross library projects for better/consistent DX (microsoft#26605) chore: enforce files naming to use .styles.ts [cxe-red files] (microsoft#27710) chore(v0): enable emit only dts and use new conformance test API to narrow down TS Program (microsoft#27686) ...
Collaborator
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
No previous behavior - new feature
New Behavior
These designs deviate from the portal only in the dark theme text color. The black text against the blue background was not readable. I also noticed that the rest background remains the same for al states in dark theme, but the border color changes. I believe this PR will unblock the issue of no tags in Azure Theme for now, and we can fine tune the background colors / text / border colors at a later time.
Light & High Contrast Light themes - rest, hover, active, focus
Dark & High Contrast Dark themes - rest, hover, active, focus
Related Issue(s)