-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Add DraggableZone into export map #27569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4a4291e:
|
Asset size changes
Baseline commit: 4b30d60494c2da73e30923f53986fd02470706a4 (build) |
📊 Bundle size report🤖 This report was generated against 4b30d60494c2da73e30923f53986fd02470706a4 |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 807 | 821 | 5000 | |
| Breadcrumb | mount | 2292 | 2271 | 1000 | |
| Checkbox | mount | 2165 | 2158 | 5000 | |
| CheckboxBase | mount | 1903 | 1887 | 5000 | |
| ChoiceGroup | mount | 3770 | 3694 | 5000 | |
| ComboBox | mount | 878 | 880 | 1000 | |
| CommandBar | mount | 8046 | 8205 | 1000 | |
| ContextualMenu | mount | 15987 | 15935 | 1000 | |
| DefaultButton | mount | 973 | 969 | 5000 | |
| DetailsRow | mount | 2897 | 2889 | 5000 | |
| DetailsRowFast | mount | 2894 | 2896 | 5000 | |
| DetailsRowNoStyles | mount | 2662 | 2655 | 5000 | |
| Dialog | mount | 3426 | 3457 | 1000 | |
| DocumentCardTitle | mount | 326 | 327 | 1000 | |
| Dropdown | mount | 2565 | 2570 | 5000 | |
| FocusTrapZone | mount | 1522 | 1511 | 5000 | |
| FocusZone | mount | 1453 | 1437 | 5000 | |
| GroupedList | mount | 49321 | 57875 | 2 | |
| GroupedList | virtual-rerender | 24058 | 24065 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 75235 | 75022 | 2 | |
| GroupedListV2 | mount | 324 | 320 | 2 | |
| GroupedListV2 | virtual-rerender | 302 | 302 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 316 | 312 | 2 | |
| IconButton | mount | 1430 | 1448 | 5000 | |
| Label | mount | 456 | 465 | 5000 | |
| Layer | mount | 3586 | 3558 | 5000 | |
| Link | mount | 525 | 530 | 5000 | |
| MenuButton | mount | 1244 | 1228 | 5000 | |
| MessageBar | mount | 28326 | 28435 | 5000 | |
| Nav | mount | 2514 | 2552 | 1000 | |
| OverflowSet | mount | 1010 | 1009 | 5000 | |
| Panel | mount | 2260 | 2209 | 1000 | |
| Persona | mount | 980 | 975 | 1000 | |
| Pivot | mount | 1165 | 1178 | 1000 | |
| PrimaryButton | mount | 1099 | 1097 | 5000 | |
| Rating | mount | 5805 | 5775 | 5000 | |
| SearchBox | mount | 1136 | 1150 | 5000 | |
| Shimmer | mount | 2317 | 2340 | 5000 | |
| Slider | mount | 1709 | 1746 | 5000 | |
| SpinButton | mount | 3775 | 3791 | 5000 | |
| Spinner | mount | 516 | 520 | 5000 | |
| SplitButton | mount | 2450 | 2440 | 5000 | |
| Stack | mount | 536 | 540 | 5000 | |
| StackWithIntrinsicChildren | mount | 1132 | 1134 | 5000 | |
| StackWithTextChildren | mount | 3212 | 3201 | 5000 | |
| SwatchColorPicker | mount | 8103 | 8182 | 5000 | |
| TagPicker | mount | 1972 | 1999 | 5000 | |
| Text | mount | 486 | 505 | 5000 | |
| TextField | mount | 1218 | 1214 | 5000 | |
| ThemeProvider | mount | 1133 | 1142 | 5000 | |
| ThemeProvider | virtual-rerender | 779 | 782 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1732 | 1708 | 5000 | |
| Toggle | mount | 814 | 804 | 5000 | |
| buttonNative | mount | 277 | 284 | 5000 |
|
Ping - this is blocking Office Online from moving to webpack 5. Any suggestions of workaround are also appreciated |
change/@fluentui-react-3469d3b8-ceaa-47ad-af92-c5e1db22d1e0.json
Outdated
Show resolved
Hide resolved
🕵 fluentuiv8 No visual regressions between this PR and main |
|
@khmakoto This change triggered the size auditor by introducing a new bundle |
* master: applying package updates fix: dont ignore lib, lib-commonjs and lib-amd files (microsoft#27736) Add DraggableZone into export map (microsoft#27569) Add export for FolderCover.scss (microsoft#27507) applying package updates Add filetype icon for Microsoft Designer (microsoft#27724) ci: add build task back as lint pre-requirement to unblock temporarily import plugin lint rule (microsoft#27729) fix(react-charting): add missing dependency to fix lint violations during release (microsoft#27728) Added partition for controlled overflow menu (microsoft#27520) Azure Theme 8.0: Tag Button variant for DefaultButton and PrimaryButton (microsoft#27186) Azure Theme 8.0 dropdown fix for high contrast themes (microsoft#27346) chore: enable TS intellisense in cross library projects for better/consistent DX (microsoft#26605) chore: enforce files naming to use .styles.ts [cxe-red files] (microsoft#27710) chore(v0): enable emit only dts and use new conformance test API to narrow down TS Program (microsoft#27686) codeowner update (microsoft#27719) Tag/TagButton init component setup (microsoft#27102)
* feat/drawer-components: (120 commits) fix: add missing change file Component testing - Donut chart (microsoft#27033) fix: update .npmignore files to resolve npm8/node16 regression with npm publish for v9 packages (microsoft#27741) chore: add .swcrc to .npmignore (generator) (microsoft#27739) docs: update API Autogenerate react-toast package (microsoft#27730) applying package updates fix: dont ignore lib, lib-commonjs and lib-amd files (microsoft#27736) Add DraggableZone into export map (microsoft#27569) Add export for FolderCover.scss (microsoft#27507) applying package updates Add filetype icon for Microsoft Designer (microsoft#27724) ci: add build task back as lint pre-requirement to unblock temporarily import plugin lint rule (microsoft#27729) fix(react-charting): add missing dependency to fix lint violations during release (microsoft#27728) Added partition for controlled overflow menu (microsoft#27520) Azure Theme 8.0: Tag Button variant for DefaultButton and PrimaryButton (microsoft#27186) Azure Theme 8.0 dropdown fix for high contrast themes (microsoft#27346) chore: enable TS intellisense in cross library projects for better/consistent DX (microsoft#26605) chore: enforce files naming to use .styles.ts [cxe-red files] (microsoft#27710) chore(v0): enable emit only dts and use new conformance test API to narrow down TS Program (microsoft#27686) ...
|
🎉 Handy links: |
Previous Behavior
DraggableZoneis not in the export map of@fluentui/reactpackage, resulting in errors like:when this component is imports with:
import { DraggableZone } from "@fluentui/react/lib/utilities/DraggableZone";New Behavior
With this PR,
DraggableZonecomponent is exposed and can be import like other components:import { DraggableZone } from "@fluentui/react/lib/DraggableZone";