Tag/TagButton init component setup #27102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
📊 Bundle size report🤖 This report was generated against bad96553b2d34ffb3d45c32a44d4883046a15945 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 57a0ed2:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: bad96553b2d34ffb3d45c32a44d4883046a15945 (build) |
packages/react-components/react-tags/src/components/Tag/Tag.types.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-tags/src/components/Tag/useTagStyles.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-tags/src/components/TagButton/TagButton.types.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-tags/src/components/TagButton/TagButton.types.ts
Show resolved
Hide resolved
packages/react-components/react-tags/src/components/TagButton/useTagButtonStyles.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-tags/src/components/TagButton/renderTagButton.tsx
Outdated
Show resolved
Hide resolved
…pes.ts Co-authored-by: Esteban Munoz Facusse <[email protected]>
….tsx Co-authored-by: Esteban Munoz Facusse <[email protected]>
…TagButton.types.ts Co-authored-by: Esteban Munoz Facusse <[email protected]>
…renderTagButton.tsx Co-authored-by: Esteban Munoz Facusse <[email protected]>
spmonahan
approved these changes
Mar 8, 2023
Contributor
spmonahan
left a comment
spmonahan
left a comment
There was a problem hiding this comment.
Left a few comments, nothing blocking though since this component is early still.
packages/react-components/react-tags/src/components/TagButton/useTagButton.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-tags/src/components/Tag/useTag.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-tags/src/components/TagButton/useTagButtonStyles.ts
Show resolved
Hide resolved
….tsx Co-authored-by: Sean Monahan <[email protected]>
…useTagButton.tsx Co-authored-by: Sean Monahan <[email protected]>
github-actions
bot
modified the milestones:
March Project Cycle Q1 2023,
April Project Cycle Q2 2023
packages/react-components/react-tags/src/components/Tag/__snapshots__/Tag.test.tsx.snap
Outdated
Show resolved
Hide resolved
...s/react-components/react-tags/src/components/TagButton/__snapshots__/TagButton.test.tsx.snap
Outdated
Show resolved
Hide resolved
TristanWatanabe
approved these changes
Apr 27, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
May 2, 2023
* master: applying package updates fix: dont ignore lib, lib-commonjs and lib-amd files (microsoft#27736) Add DraggableZone into export map (microsoft#27569) Add export for FolderCover.scss (microsoft#27507) applying package updates Add filetype icon for Microsoft Designer (microsoft#27724) ci: add build task back as lint pre-requirement to unblock temporarily import plugin lint rule (microsoft#27729) fix(react-charting): add missing dependency to fix lint violations during release (microsoft#27728) Added partition for controlled overflow menu (microsoft#27520) Azure Theme 8.0: Tag Button variant for DefaultButton and PrimaryButton (microsoft#27186) Azure Theme 8.0 dropdown fix for high contrast themes (microsoft#27346) chore: enable TS intellisense in cross library projects for better/consistent DX (microsoft#26605) chore: enforce files naming to use .styles.ts [cxe-red files] (microsoft#27710) chore(v0): enable emit only dts and use new conformance test API to narrow down TS Program (microsoft#27686) codeowner update (microsoft#27719) Tag/TagButton init component setup (microsoft#27102)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To break this component down to manageable chunks this PR only focuses on an init setup of types, slots, and basic layout.
Tag
TagButton
todo: