fix: make Option's checkIcon slot render conditionally #27409
Merged
+31
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type for `checkIcon` is nullable but the render function did not null check the slot so passing `null` to the slot caused a runtime error. Adds tests to verify the behavior.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 96f619a:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: cb6569b754d05385466021717a283bdead3f3f34 (build) |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 936 | 925 | 5000 | |
| Button | mount | 597 | 610 | 5000 | |
| Field | mount | 1714 | 1718 | 5000 | |
| FluentProvider | mount | 1207 | 1222 | 5000 | |
| FluentProviderWithTheme | mount | 313 | 319 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 294 | 288 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 320 | 328 | 10 | |
| InfoButton | mount | 218 | 215 | 5000 | |
| MakeStyles | mount | 1356 | 1310 | 50000 | |
| Persona | mount | 2312 | 2244 | 5000 | |
| SpinButton | mount | 2030 | 2027 | 5000 |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
smhigley
approved these changes
Apr 3, 2023
github-actions
bot
modified the milestones:
March Project Cycle Q1 2023,
April Project Cycle Q2 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Apr 4, 2023
* master: (39 commits) Added merge tests for custom styles (microsoft#27086) fix: make Option's checkIcon slot render conditionally (microsoft#27409) docs: add subcomponents to Combobox and Dropdown docs (microsoft#27410) Breadcrumb spec (microsoft#26742) bugfix(react-utilities): increments SlotRenderFunction signature to include children (microsoft#27377) fix: Menu should not steal focus on close (microsoft#27414) Fixed Overflow component when there's more then one children element (microsoft#27402) feat(scripts-executors): support custom base and printing all affected packages for checkIfPackagesAffected (microsoft#27364) applying package updates feat(scripts-tasks): make perf test setup generic (microsoft#26920) fix: ColorPicker preview color updated to ignore forced colors (microsoft#27394) fix: Fix babel build error on windows (microsoft#27406) chore(react-datepicker-compat): Add vr-tests and bundle-size fixtures for DatePicker (microsoft#27351) fix(react-dialog): DialogContent scrollbar always visible (microsoft#27367) docs: Add tokens search (microsoft#27265) chore(scripts-tasks): remove not needed api-extractor task logs (microsoft#27094) chore(react-tree): adds e2e flat tree tests (microsoft#27318) applying package updates Accessibility fix for empty vertical bar chart (microsoft#26254) fix(react-datepicker-compat): Fix theming issues with all themes and WHCM (microsoft#27361) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Option'scheckIconslot is nullable according to the types but the render code does not null-check the slot so code likeleads to a runtime error.
New Behavior
Options render code null checks the slot.Tests added to verify the behavior.