Skip to content

Conversation

@sopranopillow
Copy link
Contributor

This PR fixes the following issues:

  • When clicking grid items, there were unwanted styles left behind if while clicking you move the mouse out of the control.
  • Contrast issues with high contrast and dark theme.
  • Not showing current selection when the date range is month.
  • Contrast issues with marked days.
  • Colors didn't feel cohesive and seemed like we had two themes in one.

Before

image
image

After

image
image

@sopranopillow sopranopillow self-assigned this Mar 29, 2023
@sopranopillow sopranopillow requested review from a team and khmakoto as code owners March 29, 2023 02:01
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 29, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1403b5f:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Mar 29, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: a9e738b4004a59b252893d472caed84b1c336b9d (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 29, 2023

📊 Bundle size report

🤖 This report was generated against a9e738b4004a59b252893d472caed84b1c336b9d

@sopranopillow sopranopillow requested a review from khmakoto March 29, 2023 18:45
@sopranopillow sopranopillow merged commit aa8650b into microsoft:master Mar 29, 2023
@sopranopillow sopranopillow deleted the react-datepicker-compat/hcm branch March 29, 2023 20:09
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Apr 4, 2023
* master: (39 commits)
  Added merge tests for custom styles (microsoft#27086)
  fix: make Option's checkIcon slot render conditionally (microsoft#27409)
  docs: add subcomponents to Combobox and Dropdown docs (microsoft#27410)
  Breadcrumb spec (microsoft#26742)
  bugfix(react-utilities): increments SlotRenderFunction signature to include children (microsoft#27377)
  fix: Menu should not steal focus on close (microsoft#27414)
  Fixed Overflow component when there's more then one children element (microsoft#27402)
  feat(scripts-executors): support custom base and printing all affected packages for checkIfPackagesAffected (microsoft#27364)
  applying package updates
  feat(scripts-tasks): make perf test setup generic (microsoft#26920)
  fix: ColorPicker preview color updated to ignore forced colors (microsoft#27394)
  fix: Fix babel build error on windows (microsoft#27406)
  chore(react-datepicker-compat): Add vr-tests and bundle-size fixtures for DatePicker (microsoft#27351)
  fix(react-dialog): DialogContent scrollbar always visible (microsoft#27367)
  docs: Add tokens search (microsoft#27265)
  chore(scripts-tasks): remove not needed api-extractor task logs (microsoft#27094)
  chore(react-tree): adds e2e flat tree tests (microsoft#27318)
  applying package updates
  Accessibility fix for empty vertical bar chart (microsoft#26254)
  fix(react-datepicker-compat): Fix theming issues with all themes and WHCM (microsoft#27361)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants