Skip to content

Conversation

@bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Mar 24, 2023

New Behavior

  1. adds e2e tests for flat tree scenarios
  2. adds example to flattenTree comments
  3. creates internal method flattenTreeFromElement to help on e2e tests
  4. updates useFlatTree to allow passing onOpenChange and onNavigation as options

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 24, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f3c520f:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Mar 24, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 81c5ac536b119eb97fb8e8db40dd0360a20f04dd (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 24, 2023

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
67.994 kB
18.395 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
207.4 kB
57.516 kB
react-components
react-components: FluentProvider & webLightTheme
38.819 kB
12.351 kB
react-portal-compat
PortalCompatProvider
6.446 kB
2.185 kB
🤖 This report was generated against 81c5ac536b119eb97fb8e8db40dd0360a20f04dd

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 24, 2023

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 899 886 5000
Button mount 593 578 5000
Field mount 1525 1552 5000
FluentProvider mount 1104 1123 5000
FluentProviderWithTheme mount 292 300 10
FluentProviderWithTheme virtual-rerender 283 287 10
FluentProviderWithTheme virtual-rerender-with-unmount 302 295 10
InfoButton mount 201 214 5000
MakeStyles mount 1382 1397 50000
Persona mount 2153 2081 5000
SpinButton mount 1866 1863 5000

@bsunderhus bsunderhus marked this pull request as ready for review March 24, 2023 12:44
@bsunderhus bsunderhus requested a review from a team as a code owner March 24, 2023 12:44
@bsunderhus bsunderhus mentioned this pull request Mar 24, 2023
22 tasks
@bsunderhus bsunderhus force-pushed the react-tree/tests--adds-e2e-flat-tree-tests branch from c98b29c to f3c520f Compare March 24, 2023 13:48
@bsunderhus bsunderhus merged commit 7dc0392 into microsoft:master Mar 30, 2023
@bsunderhus bsunderhus deleted the react-tree/tests--adds-e2e-flat-tree-tests branch March 30, 2023 09:36
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Apr 4, 2023
* master: (39 commits)
  Added merge tests for custom styles (microsoft#27086)
  fix: make Option's checkIcon slot render conditionally (microsoft#27409)
  docs: add subcomponents to Combobox and Dropdown docs (microsoft#27410)
  Breadcrumb spec (microsoft#26742)
  bugfix(react-utilities): increments SlotRenderFunction signature to include children (microsoft#27377)
  fix: Menu should not steal focus on close (microsoft#27414)
  Fixed Overflow component when there's more then one children element (microsoft#27402)
  feat(scripts-executors): support custom base and printing all affected packages for checkIfPackagesAffected (microsoft#27364)
  applying package updates
  feat(scripts-tasks): make perf test setup generic (microsoft#26920)
  fix: ColorPicker preview color updated to ignore forced colors (microsoft#27394)
  fix: Fix babel build error on windows (microsoft#27406)
  chore(react-datepicker-compat): Add vr-tests and bundle-size fixtures for DatePicker (microsoft#27351)
  fix(react-dialog): DialogContent scrollbar always visible (microsoft#27367)
  docs: Add tokens search (microsoft#27265)
  chore(scripts-tasks): remove not needed api-extractor task logs (microsoft#27094)
  chore(react-tree): adds e2e flat tree tests (microsoft#27318)
  applying package updates
  Accessibility fix for empty vertical bar chart (microsoft#26254)
  fix(react-datepicker-compat): Fix theming issues with all themes and WHCM (microsoft#27361)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants