Skip to content

Conversation

@sopranopillow
Copy link
Contributor

@sopranopillow sopranopillow commented Mar 27, 2023

This PR adds vr tests for DatePicker compat and bundle size fixtures.

Related Issue(s)

@sopranopillow sopranopillow self-assigned this Mar 27, 2023
@msft-fluent-ui-bot msft-fluent-ui-bot added the Component: DatePickerCompat react-datepicker-compat label Mar 27, 2023
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 29, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a1a9816:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Mar 29, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 263ea175b5da60d0abacc0eec88d7c338ce5c74a (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 29, 2023

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-datepicker-compat
DatePicker Compat
0 B
0 B
250.208 kB
66.95 kB
🆕 New entry

🤖 This report was generated against 263ea175b5da60d0abacc0eec88d7c338ce5c74a

@sopranopillow sopranopillow marked this pull request as ready for review March 29, 2023 17:04
@sopranopillow sopranopillow requested review from a team and khmakoto as code owners March 29, 2023 17:04
@khmakoto
Copy link
Member

You should add "bundle-size": "bundle-size measure" as part of the scripts in package.json so the bundle size is correctly calculated and reported.

@khmakoto khmakoto changed the title chore(react-datepicker-compat): Add vr-tests for DatePicker chore(react-datepicker-compat): Add vr-tests and bundle-size fixtures for DatePicker Mar 29, 2023
@sopranopillow sopranopillow requested a review from khmakoto March 30, 2023 16:49
@sopranopillow
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@sopranopillow sopranopillow merged commit f972b0d into microsoft:master Mar 31, 2023
@sopranopillow sopranopillow deleted the react-datepicker-compat/vr-tests branch March 31, 2023 18:55
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Apr 4, 2023
* master: (39 commits)
  Added merge tests for custom styles (microsoft#27086)
  fix: make Option's checkIcon slot render conditionally (microsoft#27409)
  docs: add subcomponents to Combobox and Dropdown docs (microsoft#27410)
  Breadcrumb spec (microsoft#26742)
  bugfix(react-utilities): increments SlotRenderFunction signature to include children (microsoft#27377)
  fix: Menu should not steal focus on close (microsoft#27414)
  Fixed Overflow component when there's more then one children element (microsoft#27402)
  feat(scripts-executors): support custom base and printing all affected packages for checkIfPackagesAffected (microsoft#27364)
  applying package updates
  feat(scripts-tasks): make perf test setup generic (microsoft#26920)
  fix: ColorPicker preview color updated to ignore forced colors (microsoft#27394)
  fix: Fix babel build error on windows (microsoft#27406)
  chore(react-datepicker-compat): Add vr-tests and bundle-size fixtures for DatePicker (microsoft#27351)
  fix(react-dialog): DialogContent scrollbar always visible (microsoft#27367)
  docs: Add tokens search (microsoft#27265)
  chore(scripts-tasks): remove not needed api-extractor task logs (microsoft#27094)
  chore(react-tree): adds e2e flat tree tests (microsoft#27318)
  applying package updates
  Accessibility fix for empty vertical bar chart (microsoft#26254)
  fix(react-datepicker-compat): Fix theming issues with all themes and WHCM (microsoft#27361)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: DatePickerCompat react-datepicker-compat

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DatePicker: Add vr tests

5 participants