Skip to content

fix: ColorPicker preview color updated to ignore forced colors #27394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GeoffCoxMSFT merged 4 commits into from
Mar 31, 2023
Merged

fix: ColorPicker preview color updated to ignore forced colors #27394

GeoffCoxMSFT merged 4 commits into from
Mar 31, 2023

Conversation

@GeoffCoxMSFT
Copy link
Member

@GeoffCoxMSFT GeoffCoxMSFT commented Mar 30, 2023

Problem

The ColorPicker preview color is not shown in force-colors mode

Change

forced-color-adjust: none added to preview color box style

Testing

Verified in browser emulating forced-colors

Issue

Fixes: #27333

@GeoffCoxMSFT GeoffCoxMSFT self-assigned this Mar 30, 2023
@GeoffCoxMSFT GeoffCoxMSFT marked this pull request as ready for review March 30, 2023 23:28
@GeoffCoxMSFT GeoffCoxMSFT requested review from a team as code owners March 30, 2023 23:28
@github-actions github-actions bot added this to the March Project Cycle Q1 2023 milestone Mar 30, 2023
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 30, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 091a6d0:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Mar 31, 2023 •
edited
Loading

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react fluentui-react-ColorPicker 126.044 kB 126.069 kB ExceedsBaseline     25 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: 34d618882a79b1cd65b2d4903f77caf9d5d83891 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 31, 2023 •
edited
Loading

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 31, 2023 •
edited
Loading

📊 Bundle size report

🤖 This report was generated against 34d618882a79b1cd65b2d4903f77caf9d5d83891

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 31, 2023 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 991 969 5000
Breadcrumb mount 2296 2342 1000
Checkbox mount 2220 2233 5000
CheckboxBase mount 1988 1999 5000
ChoiceGroup mount 3836 3891 5000
ComboBox mount 1036 1034 1000
CommandBar mount 8264 8256 1000
ContextualMenu mount 16140 16056 1000
DefaultButton mount 1151 1140 5000
DetailsRow mount 3056 3055 5000
DetailsRowFast mount 3043 3121 5000
DetailsRowNoStyles mount 2799 2867 5000
Dialog mount 3348 3373 1000
DocumentCardTitle mount 444 463 1000
Dropdown mount 2774 2741 5000
FocusTrapZone mount 1662 1645 5000
FocusZone mount 1618 1616 5000
GroupedList mount 50328 58459 2
GroupedList virtual-rerender 24436 24374 2
GroupedList virtual-rerender-with-unmount 75342 76064 2
GroupedListV2 mount 434 456 2
GroupedListV2 virtual-rerender 422 420 2
GroupedListV2 virtual-rerender-with-unmount 432 447 2
IconButton mount 1581 1589 5000
Label mount 574 579 5000
Layer mount 3710 3778 5000
Link mount 665 665 5000
MenuButton mount 1393 1410 5000
MessageBar mount 27709 27839 5000
Nav mount 2704 2734 1000
OverflowSet mount 1131 1133 5000
Panel mount 2112 2160 1000
Persona mount 1104 1148 1000
Pivot mount 1339 1344 1000
PrimaryButton mount 1265 1270 5000
Rating mount 5844 5857 5000
SearchBox mount 1263 1259 5000
Shimmer mount 2469 2431 5000
Slider mount 1773 1792 5000
SpinButton mount 3929 3942 5000
Spinner mount 638 643 5000
SplitButton mount 2678 2682 5000
Stack mount 666 661 5000
StackWithIntrinsicChildren mount 1264 1283 5000
StackWithTextChildren mount 3401 3411 5000
SwatchColorPicker mount 8349 8338 5000
TagPicker mount 2110 2300 5000
Text mount 627 637 5000
TextField mount 1334 1324 5000
ThemeProvider mount 1228 1240 5000
ThemeProvider virtual-rerender 886 894 5000
ThemeProvider virtual-rerender-with-unmount 1851 1816 5000
Toggle mount 896 901 5000
buttonNative mount 403 406 5000

@GeoffCoxMSFT GeoffCoxMSFT merged commit cbc6188 into microsoft:master Mar 31, 2023
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Apr 4, 2023
@marcosmoura
Merge branch 'master' into marcosmoura/feat/drawer-component
eb96d10 
* master: (39 commits)
  Added merge tests for custom styles (microsoft#27086)
  fix: make Option's checkIcon slot render conditionally (microsoft#27409)
  docs: add subcomponents to Combobox and Dropdown docs (microsoft#27410)
  Breadcrumb spec (microsoft#26742)
  bugfix(react-utilities): increments SlotRenderFunction signature to include children (microsoft#27377)
  fix: Menu should not steal focus on close (microsoft#27414)
  Fixed Overflow component when there's more then one children element (microsoft#27402)
  feat(scripts-executors): support custom base and printing all affected packages for checkIfPackagesAffected (microsoft#27364)
  applying package updates
  feat(scripts-tasks): make perf test setup generic (microsoft#26920)
  fix: ColorPicker preview color updated to ignore forced colors (microsoft#27394)
  fix: Fix babel build error on windows (microsoft#27406)
  chore(react-datepicker-compat): Add vr-tests and bundle-size fixtures for DatePicker (microsoft#27351)
  fix(react-dialog): DialogContent scrollbar always visible (microsoft#27367)
  docs: Add tokens search (microsoft#27265)
  chore(scripts-tasks): remove not needed api-extractor task logs (microsoft#27094)
  chore(react-tree): adds e2e flat tree tests (microsoft#27318)
  applying package updates
  Accessibility fix for empty vertical bar chart (microsoft#26254)
  fix(react-datepicker-compat): Fix theming issues with all themes and WHCM (microsoft#27361)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tomi-msft tomi-msft tomi-msft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@GeoffCoxMSFT GeoffCoxMSFT

Labels

Component: ColorPicker

Projects

None yet

Milestone

March Project Cycle Q1 2023

Development

Successfully merging this pull request may close these issues.

[Bug]: Color Picker preview square color is not appearing in High contrast mode

4 participants

@GeoffCoxMSFT @fabricteam @tomi-msft @msft-fluent-ui-bot