Accessibility fix for empty vertical bar chart #26254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srmukher
force-pushed
the
users/srmukher/VBC_accessibility
branch
from
c3434e0 to
352fdc6
Compare
Collaborator
📊 Bundle size report🤖 This report was generated against 4f76849de438f2ee7842121ac3b8176ba1c0a2a5 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 4f76849de438f2ee7842121ac3b8176ba1c0a2a5 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2404c66:
|
AtishayMsft
reviewed
Jan 9, 2023
packages/react-charting/src/components/VerticalBarChart/VerticalBarChart.base.tsx
Outdated
Show resolved
Hide resolved
AtishayMsft
reviewed
Jan 9, 2023
packages/react-charting/src/components/VerticalBarChart/VerticalBarChart.base.tsx
Outdated
Show resolved
Hide resolved
AtishayMsft
reviewed
Jan 9, 2023
packages/react-charting/src/components/VerticalBarChart/VerticalBarChart.base.tsx
Show resolved
Hide resolved
srmukher
force-pushed
the
users/srmukher/VBC_accessibility
branch
2 times, most recently
from
4077830 to
ee23191
Compare
srmukher
force-pushed
the
users/srmukher/VBC_accessibility
branch
from
ee23191 to
167359d
Compare
AtishayMsft
reviewed
Feb 6, 2023
packages/react-charting/src/components/VerticalBarChart/VerticalBarChart.base.tsx
Outdated
Show resolved
Hide resolved
AtishayMsft
reviewed
Feb 6, 2023
packages/react-charting/src/components/VerticalBarChart/VerticalBarChart.base.tsx
Outdated
Show resolved
Hide resolved
AtishayMsft
reviewed
Feb 6, 2023
packages/react-charting/src/components/VerticalBarChart/VerticalBarChart.base.tsx
Outdated
Show resolved
Hide resolved
…ers/srmukher/VBC_accessibility
srmukher
force-pushed
the
users/srmukher/VBC_accessibility
branch
2 times, most recently
from
40b98f3 to
6042262
Compare
srmukher
force-pushed
the
users/srmukher/VBC_accessibility
branch
from
6042262 to
d538fcf
Compare
AtishayMsft
reviewed
Feb 23, 2023
packages/react-charting/src/components/VerticalBarChart/VerticalBarChart.base.tsx
Outdated
Show resolved
Hide resolved
…ers/srmukher/VBC_accessibility
AtishayMsft
approved these changes
Mar 27, 2023
…ers/srmukher/VBC_accessibility
…/srmukher/fluentui into users/srmukher/VBC_accessibility
srmukher
force-pushed
the
users/srmukher/VBC_accessibility
branch
from
48d3121 to
2404c66
Compare
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Apr 4, 2023
* master: (39 commits) Added merge tests for custom styles (microsoft#27086) fix: make Option's checkIcon slot render conditionally (microsoft#27409) docs: add subcomponents to Combobox and Dropdown docs (microsoft#27410) Breadcrumb spec (microsoft#26742) bugfix(react-utilities): increments SlotRenderFunction signature to include children (microsoft#27377) fix: Menu should not steal focus on close (microsoft#27414) Fixed Overflow component when there's more then one children element (microsoft#27402) feat(scripts-executors): support custom base and printing all affected packages for checkIfPackagesAffected (microsoft#27364) applying package updates feat(scripts-tasks): make perf test setup generic (microsoft#26920) fix: ColorPicker preview color updated to ignore forced colors (microsoft#27394) fix: Fix babel build error on windows (microsoft#27406) chore(react-datepicker-compat): Add vr-tests and bundle-size fixtures for DatePicker (microsoft#27351) fix(react-dialog): DialogContent scrollbar always visible (microsoft#27367) docs: Add tokens search (microsoft#27265) chore(scripts-tasks): remove not needed api-extractor task logs (microsoft#27094) chore(react-tree): adds e2e flat tree tests (microsoft#27318) applying package updates Accessibility fix for empty vertical bar chart (microsoft#26254) fix(react-datepicker-compat): Fix theming issues with all themes and WHCM (microsoft#27361) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work item 6230
Accessibility fix to announce proper message when graph has no data to display.
Previous Behavior
Currently, the screen reader/narrator does not announce if the graph is empty.
New Behavior
When the component mounts, the screen reader/narrator will announce proper message to indicate if the graph has no data to display.
Related Issue(s)
https://uifabric.visualstudio.com/iss/_workitems/edit/6230/
https://office.visualstudio.com/OC/_workitems/edit/6552630