chore(migrate-converged): add functionality to execute various v9 package file restructuring tasks #24458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59 tasks
Collaborator
📊 Bundle size reportUnchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5d001f0:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 93f154ac2821be1fd408fa98943a641f9d3dc464 (build) |
Hotell
reviewed
Aug 23, 2022
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1683 | 1633 | 5000 | |
| Button | mount | 1113 | 1164 | 5000 | |
| FluentProvider | mount | 1958 | 1926 | 5000 | |
| FluentProviderWithTheme | mount | 700 | 723 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 652 | 671 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 712 | 714 | 10 | |
| MakeStyles | mount | 2269 | 2255 | 50000 | |
| SpinButton | mount | 3240 | 3247 | 5000 |
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| PortalMinimalPerf.default | 196 | 176 | 1.11:1 |
| CardMinimalPerf.default | 611 | 555 | 1.1:1 |
| FlexMinimalPerf.default | 315 | 287 | 1.1:1 |
| AttachmentMinimalPerf.default | 180 | 170 | 1.06:1 |
| ButtonSlotsPerf.default | 615 | 579 | 1.06:1 |
| GridMinimalPerf.default | 373 | 352 | 1.06:1 |
| ItemLayoutMinimalPerf.default | 1323 | 1246 | 1.06:1 |
| RefMinimalPerf.default | 230 | 218 | 1.06:1 |
| FormMinimalPerf.default | 430 | 409 | 1.05:1 |
| RadioGroupMinimalPerf.default | 509 | 487 | 1.05:1 |
| TreeWith60ListItems.default | 179 | 170 | 1.05:1 |
| ChatMinimalPerf.default | 802 | 771 | 1.04:1 |
| EmbedMinimalPerf.default | 4062 | 3916 | 1.04:1 |
| ImageMinimalPerf.default | 435 | 420 | 1.04:1 |
| SliderMinimalPerf.default | 1847 | 1773 | 1.04:1 |
| AnimationMinimalPerf.default | 577 | 561 | 1.03:1 |
| ButtonMinimalPerf.default | 179 | 174 | 1.03:1 |
| HeaderMinimalPerf.default | 391 | 378 | 1.03:1 |
| ListMinimalPerf.default | 559 | 545 | 1.03:1 |
| MenuButtonMinimalPerf.default | 1867 | 1817 | 1.03:1 |
| TableMinimalPerf.default | 449 | 434 | 1.03:1 |
| BoxMinimalPerf.default | 364 | 357 | 1.02:1 |
| DialogMinimalPerf.default | 826 | 808 | 1.02:1 |
| DropdownMinimalPerf.default | 2904 | 2837 | 1.02:1 |
| ListNestedPerf.default | 626 | 615 | 1.02:1 |
| SegmentMinimalPerf.default | 379 | 370 | 1.02:1 |
| CheckboxMinimalPerf.default | 2268 | 2253 | 1.01:1 |
| DatepickerMinimalPerf.default | 6260 | 6195 | 1.01:1 |
| ListWith60ListItems.default | 671 | 665 | 1.01:1 |
| MenuMinimalPerf.default | 901 | 889 | 1.01:1 |
| ProviderMinimalPerf.default | 412 | 409 | 1.01:1 |
| ReactionMinimalPerf.default | 404 | 400 | 1.01:1 |
| SkeletonMinimalPerf.default | 372 | 367 | 1.01:1 |
| SplitButtonMinimalPerf.default | 4827 | 4772 | 1.01:1 |
| TextMinimalPerf.default | 379 | 377 | 1.01:1 |
| TextAreaMinimalPerf.default | 546 | 538 | 1.01:1 |
| ToolbarMinimalPerf.default | 1020 | 1008 | 1.01:1 |
| TooltipMinimalPerf.default | 2550 | 2526 | 1.01:1 |
| AvatarMinimalPerf.default | 196 | 196 | 1:1 |
| CarouselMinimalPerf.default | 519 | 518 | 1:1 |
| ChatWithPopoverPerf.default | 429 | 430 | 1:1 |
| HeaderSlotsPerf.default | 846 | 850 | 1:1 |
| TreeMinimalPerf.default | 874 | 874 | 1:1 |
| AttachmentSlotsPerf.default | 1199 | 1210 | 0.99:1 |
| ChatDuplicateMessagesPerf.default | 310 | 314 | 0.99:1 |
| DividerMinimalPerf.default | 380 | 382 | 0.99:1 |
| InputMinimalPerf.default | 1197 | 1215 | 0.99:1 |
| LoaderMinimalPerf.default | 701 | 705 | 0.99:1 |
| PopupMinimalPerf.default | 664 | 674 | 0.99:1 |
| ProviderMergeThemesPerf.default | 1262 | 1280 | 0.99:1 |
| CustomToolbarPrototype.default | 2744 | 2771 | 0.99:1 |
| DropdownManyItemsPerf.default | 739 | 751 | 0.98:1 |
| StatusMinimalPerf.default | 714 | 731 | 0.98:1 |
| TableManyItemsPerf.default | 2091 | 2142 | 0.98:1 |
| LayoutMinimalPerf.default | 373 | 383 | 0.97:1 |
| ListCommonPerf.default | 695 | 717 | 0.97:1 |
| RosterPerf.default | 2337 | 2404 | 0.97:1 |
| IconMinimalPerf.default | 693 | 714 | 0.97:1 |
| VideoMinimalPerf.default | 798 | 825 | 0.97:1 |
| AlertMinimalPerf.default | 285 | 298 | 0.96:1 |
| LabelMinimalPerf.default | 403 | 421 | 0.96:1 |
| ButtonOverridesMissPerf.default | 1423 | 1491 | 0.95:1 |
| AccordionMinimalPerf.default | 162 | 175 | 0.93:1 |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 1559 | 1567 | 5000 | |
| Breadcrumb | mount | 3600 | 3628 | 1000 | |
| Checkbox | mount | 3391 | 3380 | 5000 | |
| CheckboxBase | mount | 3033 | 3035 | 5000 | |
| ChoiceGroup | mount | 5785 | 5847 | 5000 | |
| ComboBox | mount | 1556 | 1604 | 1000 | |
| CommandBar | mount | 11771 | 11768 | 1000 | |
| ContextualMenu | mount | 13299 | 13236 | 1000 | |
| DefaultButton | mount | 1804 | 1804 | 5000 | |
| DetailsRow | mount | 4662 | 4697 | 5000 | |
| DetailsRowFast | mount | 4667 | 4635 | 5000 | |
| DetailsRowNoStyles | mount | 4440 | 4493 | 5000 | |
| Dialog | mount | 3840 | 3874 | 1000 | |
| DocumentCardTitle | mount | 735 | 732 | 1000 | |
| Dropdown | mount | 4210 | 4206 | 5000 | |
| FocusTrapZone | mount | 2478 | 2524 | 5000 | |
| FocusZone | mount | 2447 | 2445 | 5000 | |
| GroupedList | mount | 68846 | 80166 | 2 | |
| GroupedList | virtual-rerender | 32956 | 32776 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 110051 | 111476 | 2 | |
| GroupedListV2 | mount | 708 | 692 | 2 | |
| GroupedListV2 | virtual-rerender | 654 | 648 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 686 | 688 | 2 | |
| IconButton | mount | 2462 | 2521 | 5000 | |
| Label | mount | 874 | 876 | 5000 | |
| Layer | mount | 5348 | 5357 | 5000 | |
| Link | mount | 1037 | 1074 | 5000 | |
| MenuButton | mount | 2194 | 2197 | 5000 | |
| MessageBar | mount | 2858 | 2838 | 5000 | |
| Nav | mount | 4188 | 4266 | 1000 | |
| OverflowSet | mount | 1684 | 1720 | 5000 | |
| Panel | mount | 3103 | 3123 | 1000 | |
| Persona | mount | 1643 | 1629 | 1000 | |
| Pivot | mount | 2054 | 2100 | 1000 | |
| PrimaryButton | mount | 1932 | 1937 | 5000 | |
| Rating | mount | 9340 | 9379 | 5000 | |
| SearchBox | mount | 1972 | 1971 | 5000 | |
| Shimmer | mount | 3605 | 3730 | 5000 | |
| Slider | mount | 2663 | 2614 | 5000 | |
| SpinButton | mount | 5987 | 6062 | 5000 | |
| Spinner | mount | 975 | 1013 | 5000 | |
| SplitButton | mount | 3977 | 3929 | 5000 | |
| Stack | mount | 1101 | 1092 | 5000 | |
| StackWithIntrinsicChildren | mount | 3235 | 3330 | 5000 | |
| StackWithTextChildren | mount | 6611 | 6534 | 5000 | |
| SwatchColorPicker | mount | 13379 | 13516 | 5000 | |
| TagPicker | mount | 3374 | 3386 | 5000 | |
| TeachingBubble | mount | 105350 | 104755 | 5000 | |
| Text | mount | 1020 | 1018 | 5000 | |
| TextField | mount | 2064 | 2051 | 5000 | |
| ThemeProvider | mount | 1905 | 1934 | 5000 | |
| ThemeProvider | virtual-rerender | 1325 | 1362 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 2699 | 2703 | 5000 | |
| Toggle | mount | 1409 | 1395 | 5000 | |
| buttonNative | mount | 681 | 678 | 5000 |
ling1726
reviewed
Sep 13, 2022
…ctions to cypress, updates tests
This was referenced Oct 24, 2022
This was referenced Nov 1, 2022
Merged
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
…kage file restructuring tasks (microsoft#24458)
This was referenced Nov 21, 2022
This was referenced Nov 28, 2022
This was referenced Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements generator changes needed to execute v9 package restructure outlined by this RFC
Changes
removes old
moveStoriesfunction which was used to move stories fromsrc/storiestosrc/stories/{ComponentName}since that entire migration is now complete.Adds
moveStoriesToPackageRootfunction which will move existing stories fromsrc/storiesto/stories. Any new components created with thecreate-componentscript will now have their story templates populated in the/stories/{ComponentName}directory.Adds
moveDocsToSubfolderwhich moves existingMIGRATION.mdandSPEC.mdfiles to the/docsfolder.Adds
migrateE2ESetupToCypressfunction which moves files within thee2e/folder to appropriate location- moves
tsconfig.jsonto root of package renamed astsconfig.cy.json. This is then added to basetsconfig.json's path references.- moves any file with
.e2e.suffix tosrc/components/{ComponentName}with filename updated to use.cy.suffix.- moves any
selector.tshelper files tosrc/testingand updates any import paths of files that require it.Adds
migrateCommonFolderToTestingfunction which moves any file present in thesrc/commonfolder tosrc/testingand updates the import paths of files that require moved files.Updates
npm.ignorefile to ignore/docsand/storiessubfolders and any files with.cy.in its path.Renames instances where function names are referred to as
e2ein favor ofcypressExample Usage:
Draft PR which uses generator: #25015
Related Issues:
Part of #24129