Skip to content

Conversation

@TristanWatanabe
Copy link
Member

Changes:

Issue:

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 1, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5495fa3:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Nov 1, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 51eaa880e902bb7b24739eff1d3c447e6edc6766 (build)

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
62.94 kB
17.663 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
189.603 kB
52.909 kB
react-components
react-components: FluentProvider & webLightTheme
33.446 kB
11.033 kB
react-input
Input
24.428 kB
7.899 kB
react-portal-compat
PortalCompatProvider
5.857 kB
1.978 kB
react-spinbutton
SpinButton
45.826 kB
12.858 kB
🤖 This report was generated against 51eaa880e902bb7b24739eff1d3c447e6edc6766

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1291 1281 5000
Button mount 927 925 5000
FluentProvider mount 1493 1479 5000
FluentProviderWithTheme mount 580 584 10
FluentProviderWithTheme virtual-rerender 540 548 10
FluentProviderWithTheme virtual-rerender-with-unmount 571 587 10
MakeStyles mount 1969 1964 50000
SpinButton mount 2318 2320 5000

@TristanWatanabe TristanWatanabe marked this pull request as ready for review November 1, 2022 18:50
@TristanWatanabe TristanWatanabe requested review from a team and spmonahan as code owners November 1, 2022 18:50
@TristanWatanabe TristanWatanabe merged commit 890afd9 into microsoft:master Nov 1, 2022
@TristanWatanabe TristanWatanabe deleted the migrate-input branch November 1, 2022 23:16
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Nov 2, 2022
* master: (23 commits)
  fix(docsite-v9): move theme picker under component title so it can be visible on embedded pages (microsoft#25385)
  applying package updates
  feat: Implement child render function for DataGrid rows (microsoft#25476)
  fix(useTable): sort should adapt to enhanced row types (microsoft#25487)
  applying package updates
  feat: positioning should happen out of React lifecycle (microsoft#25456)
  applying package updates
  chore(react-link): migrate to new package structure (microsoft#25471)
  chore(react-input): migrate to new package structure (microsoft#25469)
  fix glob pattern for syncpack (microsoft#25465)
  chore(react-label): migrate to new package structure (microsoft#25470)
  chore: bump Griffel to latest (microsoft#25412)
  chore: add few small toolbar improvements (microsoft#25468)
  docs: fix small typos (microsoft#25464)
  chore: fix dependencies in @fluentui/react-toolbar (microsoft#25466)
  feat: v0 menu style migration from v9 (microsoft#25012)
  applying package updates
  Update List to render children on first render() call (microsoft#25331)
  Scaffold react-skeleton package (microsoft#25435)
  fix(public-docsite): Changing crossplatform urls to use 'cross' instead of 'crossplatform' (microsoft#25437)
  ...
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
Hotell pushed a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants