Skip to content

Conversation

@TristanWatanabe
Copy link
Member

Changes:

Issue:

@TristanWatanabe TristanWatanabe self-assigned this Nov 21, 2022
@size-auditor
Copy link

size-auditor bot commented Nov 21, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 3ca7917d818ccde26b1dc172241f88a6e8f322b3 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1274 1304 5000
Button mount 917 933 5000
FluentProvider mount 1486 1516 5000
FluentProviderWithTheme mount 581 585 10
FluentProviderWithTheme virtual-rerender 545 545 10
FluentProviderWithTheme virtual-rerender-with-unmount 583 574 10
MakeStyles mount 1956 1963 50000
SpinButton mount 2343 2345 5000

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
533 B
341 B
global-context
createContextSelector
554 B
348 B
react-accordion
Accordion (including children components)
79.294 kB
24.443 kB
react-alert
Alert
86.891 kB
21.708 kB
react-avatar
Avatar
51.076 kB
14.285 kB
react-avatar
AvatarGroup
15.006 kB
6.009 kB
react-avatar
AvatarGroupItem
65.654 kB
18.382 kB
react-badge
Badge
23.357 kB
7.361 kB
react-badge
CounterBadge
24.247 kB
7.643 kB
react-badge
PresenceBadge
24.001 kB
7.049 kB
react-button
Button
36.86 kB
9.913 kB
react-button
CompoundButton
43.885 kB
11.131 kB
react-button
MenuButton
41.537 kB
11.187 kB
react-button
SplitButton
48.983 kB
12.588 kB
react-button
ToggleButton
52.685 kB
11.415 kB
react-card
Card - All
71.873 kB
20.936 kB
react-card
Card
67.651 kB
19.892 kB
react-card
CardFooter
8.617 kB
3.62 kB
react-card
CardHeader
9.792 kB
3.995 kB
react-card
CardPreview
8.718 kB
3.674 kB
react-combobox
Combobox (including child components)
78.086 kB
24.988 kB
react-combobox
Dropdown (including child components)
77.373 kB
24.891 kB
react-components
react-components: Button, FluentProvider & webLightTheme
62.975 kB
17.687 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
190.427 kB
53.087 kB
react-components
react-components: FluentProvider & webLightTheme
33.48 kB
11.037 kB
react-dialog
Dialog (including children components)
83.036 kB
24.754 kB
react-divider
Divider
16.515 kB
5.921 kB
react-image
Image
10.836 kB
4.283 kB
react-infobutton
InfoButton
117.938 kB
35.399 kB
react-input
Input
24.122 kB
7.889 kB
react-label
Label
9.394 kB
3.88 kB
react-link
Link
11.862 kB
4.885 kB
react-menu
Menu (including children components)
117.61 kB
36.287 kB
react-menu
Menu (including selectable components)
120.679 kB
36.82 kB
react-overflow
hooks only
11.004 kB
4.188 kB
react-persona
Persona
57.131 kB
15.951 kB
react-popover
Popover
103.682 kB
31.867 kB
react-portal
Portal
10.495 kB
3.851 kB
react-portal-compat
PortalCompatProvider
5.857 kB
1.978 kB
react-positioning
usePositioning
19.826 kB
7.417 kB
react-progress
Progress
13.536 kB
5.107 kB
react-provider
FluentProvider
15.817 kB
5.905 kB
react-radio
Radio
36.446 kB
12.123 kB
react-radio
RadioGroup
14.304 kB
5.72 kB
react-select
Select
23.438 kB
8.018 kB
react-slider
Slider
32.118 kB
10.192 kB
react-spinbutton
SpinButton
44.43 kB
12.812 kB
react-spinner
Spinner
20.013 kB
6.446 kB
react-switch
Switch
33.453 kB
10.581 kB
react-text
Text - Default
11.838 kB
4.625 kB
react-text
Text - Wrappers
15.148 kB
5.06 kB
react-textarea
Textarea
25.697 kB
8.328 kB
react-tooltip
Tooltip
42.032 kB
14.739 kB
react-utilities
SSRProvider
180 B
159 B
🤖 This report was generated against 3ca7917d818ccde26b1dc172241f88a6e8f322b3

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d391b15:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 Open the Visual Regressions report to inspect the 2 screenshots

✅ There was 0 screenshots added, 0 screenshots removed, 1749 screenshots unchanged, 0 screenshots with different dimensions and 2 screenshots with visible difference.

unknown 2 screenshots
Image Name Diff(in Pixels) Image Type
Avatar Converged.size+active+badge.normal.chromium.png 4 Changed
Avatar Converged.size+active+ring-shadow.normal.chromium.png 4 Changed

@TristanWatanabe TristanWatanabe marked this pull request as ready for review November 21, 2022 18:21
@TristanWatanabe TristanWatanabe requested a review from a team as a code owner November 21, 2022 18:21
@TristanWatanabe TristanWatanabe merged commit 109f6e6 into microsoft:master Nov 21, 2022
@TristanWatanabe TristanWatanabe deleted the migrate-positioning branch November 21, 2022 19:45
Hotell pushed a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants