Skip to content

Conversation

@TristanWatanabe
Copy link
Member

Changes:

Issue:

@TristanWatanabe TristanWatanabe self-assigned this Nov 21, 2022
@size-auditor
Copy link

size-auditor bot commented Nov 21, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 3ca7917d818ccde26b1dc172241f88a6e8f322b3 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 21, 2022

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-alert
Alert
86.891 kB
21.708 kB
react-avatar
Avatar
51.076 kB
14.285 kB
react-avatar
AvatarGroup
15.006 kB
6.009 kB
react-avatar
AvatarGroupItem
65.654 kB
18.382 kB
react-components
react-components: Button, FluentProvider & webLightTheme
62.975 kB
17.687 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
190.427 kB
53.087 kB
react-components
react-components: FluentProvider & webLightTheme
33.48 kB
11.037 kB
react-infobutton
InfoButton
117.938 kB
35.399 kB
react-persona
Persona
57.131 kB
15.951 kB
react-popover
Popover
103.682 kB
31.867 kB
react-portal-compat
PortalCompatProvider
5.857 kB
1.978 kB
🤖 This report was generated against 3ca7917d818ccde26b1dc172241f88a6e8f322b3

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 21, 2022

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1326 1339 5000
Button mount 945 928 5000
FluentProvider mount 1613 1621 5000
FluentProviderWithTheme mount 626 633 10
FluentProviderWithTheme virtual-rerender 588 588 10
FluentProviderWithTheme virtual-rerender-with-unmount 623 632 10
MakeStyles mount 1906 1911 50000
SpinButton mount 2596 2521 5000

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 21, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7a3ff26:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 21, 2022

🕵 fluentuiv9 Open the Visual Regressions report to inspect the 2 screenshots

✅ There was 0 screenshots added, 0 screenshots removed, 1749 screenshots unchanged, 0 screenshots with different dimensions and 2 screenshots with visible difference.

unknown 2 screenshots
Image Name Diff(in Pixels) Image Type
Avatar Converged.size+active+badge.normal.chromium.png 9 Changed
Avatar Converged.size+active+ring-shadow.normal.chromium.png 3 Changed

@TristanWatanabe
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@TristanWatanabe TristanWatanabe marked this pull request as ready for review November 21, 2022 19:00
@TristanWatanabe TristanWatanabe requested a review from a team as a code owner November 21, 2022 19:00
@TristanWatanabe TristanWatanabe merged commit c279105 into microsoft:master Nov 21, 2022
@TristanWatanabe TristanWatanabe deleted the migrate-popover branch November 21, 2022 19:48
Hotell pushed a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants