Skip to content

Conversation

@TristanWatanabe
Copy link
Member

Changes:

Issue:

@size-auditor
Copy link

size-auditor bot commented Nov 21, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: c279105c23c0f00294b59e727ffd7f726d874e2b (build)

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
62.975 kB
17.687 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
190.427 kB
53.087 kB
react-components
react-components: FluentProvider & webLightTheme
33.48 kB
11.037 kB
react-portal-compat
PortalCompatProvider
5.857 kB
1.978 kB
react-progress
Progress
13.536 kB
5.107 kB
🤖 This report was generated against c279105c23c0f00294b59e727ffd7f726d874e2b

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9419280:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1579 1572 5000
Button mount 1135 1111 5000
FluentProvider mount 1909 1882 5000
FluentProviderWithTheme mount 759 762 10
FluentProviderWithTheme virtual-rerender 698 706 10
FluentProviderWithTheme virtual-rerender-with-unmount 735 736 10
MakeStyles mount 2240 2301 50000
SpinButton mount 2995 2938 5000

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 Open the Visual Regressions report to inspect the 2 screenshots

✅ There was 0 screenshots added, 0 screenshots removed, 1749 screenshots unchanged, 0 screenshots with different dimensions and 2 screenshots with visible difference.

unknown 2 screenshots
Image Name Diff(in Pixels) Image Type
Avatar Converged.size+active+badge.normal.chromium.png 5 Changed
Avatar Converged.size+active+ring-shadow.normal.chromium.png 6 Changed

@TristanWatanabe TristanWatanabe merged commit 77b8194 into microsoft:master Nov 22, 2022
@TristanWatanabe TristanWatanabe deleted the migrate-progress branch November 22, 2022 20:52
Hotell pushed a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants