Skip to content

feature/format: Merge CI update #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 37 commits into from
Oct 9, 2020
Merged

feature/format: Merge CI update #1361

merged 37 commits into from
Oct 9, 2020

Conversation

@CaseyCarter
Copy link
Contributor

@CaseyCarter CaseyCarter commented Oct 9, 2020

To pick up #1337.

Note that the final commit is a merge conflict resolution requiring actual review.

⚠️ Commit this as a merge, not a squash! ⚠️

CaseyCarter and others added 30 commits September 22, 2020 15:02
@CaseyCarter
Minimal changes to support constexpr allocation in MSVC (microsoft#1313)
3d88a64 
* Minimal changes to support constexpr allocation in MSVC

* Define `_CONSTEXPR20_DYNALLOC` macro to `constexpr` when the compiler defines `__cpp_constexpr_dynamic_alloc` and `inline` otherwise.
* Implement and test `ranges::construct_at` and `ranges::destroy_at`, mark them (and `std` flavors) `_CONSTEXPR20_DYNALLOC`.
* Implement `ranges::destroy` and `ranges::destroy_n` which share machinery with `ranges::destroy_at` with minimal test coverage. (More to follow.)

[This is a dual of internal MSVC-PR-275909.]
@miscco @AdamBucior @StephanTLavavej
Implement ranges::uninitialized_meow (microsoft#1164)
5f4bc22 
Implement several specialized memory range algorithms:
* `ranges::uninitialized_default_construct`, `ranges::uninitialized_default_construct_n`
* `ranges::uninitialized_value_construct`, `ranges::uninitialized_value_construct_n`
* `ranges::uninitialized_fill`, `ranges::uninitialized_fill_n`
* `ranges::uninitialized_copy`, `ranges::uninitialized_copy_n`
* `ranges::uninitialized_move_n`

Co-authored-by: Adam Bucior <[email protected]>
Co-authored-by: Stephan T. Lavavej <[email protected]>
@BillyONeal @StephanTLavavej
P0660R10 <stop_token> And jthread (microsoft#1196)
9e264ab 
Co-authored-by: Stephan T. Lavavej <[email protected]>
@StephanTLavavej
Use constexpr is_sorted, add charconv tests, update comments (microso…
d49e401 
…ft#1278)
@CaseyCarter @StephanTLavavej
Account for C++17 deferred temporary materialization in invocable_r (m…
7a9998c 
…icrosoft#1282)

Co-authored-by: Stephan T. Lavavej <[email protected]>
@SuperWig @CaseyCarter
Fix two VS 2019 16.8 Preview 3 blocked issues (microsoft#1291)
8be9877 
Co-authored-by: Casey Carter <[email protected]>
@AlexGuteniev
Fix atomic_ref<int8_t>::operator--(int) compiler error (microsoft#1303)
648f2b1
@fsb4000 @StephanTLavavej @CaseyCarter
P1007R3 assume_aligned() (microsoft#1306)
6e6321c 
Co-authored-by: Stephan T. Lavavej <[email protected]>
Co-authored-by: Casey Carter <[email protected]>
@Arzaghi
<complex>: prevent invalid conversions (microsoft#1294)
5847f82
@cdacamar
Mark memory_resource dtor as default to enable constant destruction i…
7210dd7 
…n derived classes (microsoft#1314)
@jrabet
Make _Execute_once XFG-compatible. (microsoft#1318)
400aec0
@AlexGuteniev @StephanTLavavej
Remove XP (and Server 2003) support from STL (microsoft#1194)
554b5d3 
Co-authored-by: Stephan T. Lavavej <[email protected]>
@Arzaghi
<filesystem>: create_directories() should throw for empty paths (micr…
d0c089e 
…osoft#1285)
@onihusube @CaseyCarter @StephanTLavavej
P0339R6 polymorphic_allocator<> (microsoft#1311)
c47cedc 
Co-authored-by: Casey Carter <[email protected]>
Co-authored-by: Stephan T. Lavavej <[email protected]>
@simmse @StephanTLavavej
Accept 80-bit long double in <complex> (microsoft#1316)
c70b7a8 
Co-authored-by: Stephan T. Lavavej <[email protected]>
@SunnyWar @StephanTLavavej
Cleanup header inclusion in stl/src (microsoft#1270)
530bdc5 
Co-authored-by: Stephan T. Lavavej <[email protected]>
@MattStephanson @StephanTLavavej
<random>: Fix incorrect rounding in rejection method. (microsoft#1159)
c385d02 
Co-authored-by: Stephan T. Lavavej <[email protected]>
@statementreply @StephanTLavavej
<charconv>: Simplify _Assemble_floating_point_value and optimize _Rig…
974582f 
…ht_shift_with_rounding (microsoft#1220)

Co-authored-by: Stephan T. Lavavej <[email protected]>
@Arzaghi @MattStephanson
@cbezault @StephanTLavavej
<random>: Prevent distributions from returning NaN/Inf (microsoft#1228)
a8b62af 
Co-authored-by: MattStephanson <[email protected]>
Co-authored-by: Curtis J Bezault <[email protected]>
Co-authored-by: Stephan T. Lavavej <[email protected]>
@CaseyCarter
Workaround VSO-1222776 in <ranges> (microsoft#1287)
4386d74
@CaseyCarter @StephanTLavavej
<functional>: bind_front() should use decayed types to determine its …
bb05875 
…return type (microsoft#1293)

Fixes microsoft#1292.

Co-authored-by: Stephan T. Lavavej <[email protected]>
@MattStephanson @StephanTLavavej
<complex>: Fix the pow(complex, arithmetic) overload set (microsoft#1299
d05f8ec 
)

Co-authored-by: Stephan T. Lavavej <[email protected]>
@StephanTLavavej @CaseyCarter
Remove macros and a compiler workaround (microsoft#1307)
7c3742e 
Co-authored-by: Casey Carter <[email protected]>
@StephanTLavavej
Remove unused ConcRT wrappers (microsoft#1325)
d247352
Support upstream EDG in the std test suite (microsoft#1328)
0614c8c
@Arzaghi @StephanTLavavej
<vector>: vector's move ctor should initialize members once (microsof…
02130c4 
…t#1330)

Co-authored-by: Stephan T. Lavavej <[email protected]>
@praveenojha33
Updated _MSVC_STL_UPDATE to October 2020 (microsoft#1340)
03ab954 
Co-authored-by: Praveen Ojha <[email protected]>
@StephanTLavavej
Port MSVC-internal changes (microsoft#1344)
b1ed29c
@Arzaghi @StephanTLavavej
<iomanip>: std::get_time should not fail when format is longer than t…
7402883 
…he stream (microsoft#1326)

Co-authored-by: Stephan T. Lavavej <[email protected]>
@jrabet
Fix _Execute_once XFG trampoline (microsoft#1356)
b6437a9
CaseyCarter and others added 7 commits October 8, 2020 17:52
@CaseyCarter
P0896R4 stream iterator changes (microsoft#1281)
4af65e3 
Makes `istream_iterator`, `ostream_iterator`, `istreambuf_iterator`, and `ostreambuf_iterator` model the C++20 iterator concepts.
@CaseyCarter @StephanTLavavej
_Node_handle: destroy with value_type allocator (microsoft#1310)
20a19e4 
Drive-by cleanup:
* explicitly compare pointers  with `nullptr` in preference to `if (ptr)` and `if (!ptr)`
* `_STL_INTERNAL_CHECK` checkable preconditions
* Use `constinit` when available to verify `constexpr` constructor

Fixes microsoft#1309.

Co-authored-by: Stephan T. Lavavej <[email protected]>
@CaseyCarter
Remove workarounds for several compiler bugs (microsoft#1327)
5be862d 
Removes workarounds for:
* VSO-938163 "`constexpr` hates pointers", revealing VSO-1132704 "Bogus C3615 when implicitly-constexpr defaulted SMF calls non-trivial SMF in base class" and VSO-1217687 "Casting object reference to base and back loses track of member values in constant expression" beneath.
* VSO-1002863 "Failure to short-circuit substitution when evaluating disjunction of atomic constraints"
* VSO-1062618 "Asymmetric behavior from conditional operator with char32_t operands"
* VSO-1125263 "EDG rejects valid code using consteval"
* VSO-1132105 "[EDG] Error using non-static data member with dependent type in noexcept-specifier of member function template"
* VSO-1132186 "[EDG] Weirdness with dependent template in noexcept-specifier"
* VSO-1178211 "[EDG] Internal compiler error on template template parameter instantiated from inherited template"

Also relabels the workarounds for VSO-1174090 "Assertion failure for member subobject with multiple prospective destructors" (which is fixed!) as workarounds for VSO-1225825 "ModuleReader doesn't understand concept overloading". 

As a bonus, remove unnecessary workarounds for DevCom-1159442 "type-constraint in deduced variable type fails when immediately following an if statement"; these type-constraints don't follow the _compound-statement_ of an `if` conditional, and so don't trigger the bug.
@sylveon
Azure Pipelines: Skip tests if build fails, run both tools even if ot…
8050cbe 
…her fails (microsoft#1337)
@CaseyCarter
Update cgmanifest for 16.8 (microsoft#1354)
f3094e8 
c70b7a8 corresponds to microsoft#1316 "Accept 80-bit `long double` in `<complex>`," which was ported into a late 16.8 preview. This will almost certainly be our last commit for 16.8.

Not that not every preceding commit is in 16.8. This is fine: we need all shipping commits to be covered by the cgmanifest, it's ok to also cover some commits that won't ship until the next release.
@StephanTLavavej
_M_ARM64EC cleanups. Fifth time's the charm. (microsoft#1355)
a6c1042
@CaseyCarter
Merge branch 'main' into ff
7e36734 
Hand-correct trivial conflict in `tests/std/tests.lst` due to the addition of tests at the same place in both branches.
@CaseyCarter CaseyCarter added infrastructure Related to repository automation uncharted Excluded from the Status Chart labels Oct 9, 2020
@CaseyCarter CaseyCarter requested a review from a team as a code owner October 9, 2020 02:06
StephanTLavavej
StephanTLavavej approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge looks good, thanks for taking care of this.

@CaseyCarter CaseyCarter merged commit 699a195 into microsoft:feature/format Oct 9, 2020
@CaseyCarter CaseyCarter deleted the feature_format_update branch October 9, 2020 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

No one assigned

Labels

infrastructure Related to repository automation uncharted Excluded from the Status Chart

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.