Skip to content

_Ty -> _TVal for atomic_ref, one missed occurrence #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 23, 2020
Merged

_Ty -> _TVal for atomic_ref, one missed occurrence #1303

merged 6 commits into from
Sep 23, 2020

Conversation

@AlexGuteniev
Copy link
Contributor

@AlexGuteniev AlexGuteniev commented Sep 17, 2020 •
edited
Loading

Resolves #1302

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner September 17, 2020 09:16
miscco
miscco suggested changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what its worth, this looks correct.

I would prefer that we add a test though

@miscco
Copy link
Contributor

miscco commented Sep 17, 2020

🎉 for increased test coverage

@CaseyCarter CaseyCarter added the bug Something isn't working label Sep 17, 2020
CaseyCarter
CaseyCarter reviewed Sep 17, 2020
View reviewed changes
CaseyCarter
CaseyCarter approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - thanks!

StephanTLavavej
StephanTLavavej approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and comprehensive test coverage! 😸

@CaseyCarter CaseyCarter changed the title _Ty -> _TVal for atomic_ref, one missed occurence _Ty -> _TVal for atomic_ref, one missed occurrence Sep 22, 2020
@StephanTLavavej StephanTLavavej self-assigned this Sep 22, 2020
@StephanTLavavej StephanTLavavej merged commit 648f2b1 into microsoft:master Sep 23, 2020
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Sep 23, 2020

Thanks again for the quick fix! 🚀

@AlexGuteniev AlexGuteniev deleted the ref_decrement branch January 20, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+2 more reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@miscco miscco miscco approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej StephanTLavavej

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

<atomic>: atomic_ref<int8_t>::operator--(int) fails to compile

4 participants

@AlexGuteniev @miscco @StephanTLavavej @CaseyCarter