Remove workarounds for several compiler bugs #1327
Merged
+351
−487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes workarounds for: * VSO-938163 "`constexpr` hates pointers", revealing VSO-1132704 "Bogus C3615 when implicitly-constexpr defaulted SMF calls non-trivial SMF in base class" and VSO-1217687 "Casting object reference to base and back loses track of member values in constant expression" beneath. * VSO-1002863 "Failure to short-circuit substitution when evaluating disjunction of atomic constraints" * VSO-1062618 "Asymmetric behavior from conditional operator with char32_t operands" * VSO-1174090 "Assertion failure for member subobject with multiple prospective destructors" * VSO-1125263 "EDG rejects valid code using consteval" * VSO-1132105 "[EDG] Error using non-static data member with dependent type in noexcept-specifier of member function template" * VSO-1132186 "[EDG] Weirdness with dependent template in noexcept-specifier" * VSO-1178211 "[EDG] Internal compiler error on template template parameter instantiated from inherited template" As a bonus, remove unnecessary workarounds for DevCom-1159442 "type-constraint in deduced variable type fails when immediately following an if statement"; these type-constraints don't follow the _compound-statement_ of an `if` conditional, and so don't trigger the bug.
StephanTLavavej
approved these changes
Sep 29, 2020
Contributor
|
great, nice work compiler team and @CaseyCarter 👍 |
cbezault
approved these changes
Sep 30, 2020
StephanTLavavej
requested changes
Oct 2, 2020
MSVC implements P0848R3 and can now handle these constrained special member functions just fine ... except when imported as a module.
StephanTLavavej
approved these changes
Oct 8, 2020
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
Looks good to me - one newline comment but you don't need to reset testing for it (it can be fixed when the workaround is finally removed).
Contributor
Author
|
Thanks for this compiler regression test coverage! (I don't think this is Changelog-worthy - shout if I've missed something that users or contributors need to be made aware of.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes workarounds for:
constexprhates pointers", revealing VSO-1132704 "Bogus C3615 when implicitly-constexpr defaulted SMF calls non-trivial SMF in base class" and VSO-1217687 "Casting object reference to base and back loses track of member values in constant expression" beneath.Also relabels the workarounds for VSO-1174090 "Assertion failure for member subobject with multiple prospective destructors" (which is fixed!) as workarounds for VSO-1225825 "ModuleReader doesn't understand concept overloading".
As a bonus, remove unnecessary workarounds for DevCom-1159442 "type-constraint in deduced variable type fails when immediately following an if statement"; these type-constraints don't follow the compound-statement of an
ifconditional, and so don't trigger the bug.