Skip to content

<complex>: prevent invalid conversions #1294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 23, 2020
Merged

<complex>: prevent invalid conversions #1294

merged 5 commits into from
Sep 23, 2020

Conversation

@Arzaghi
Copy link
Contributor

@Arzaghi Arzaghi commented Sep 15, 2020 •
edited
Loading

Fixes #1256

@Arzaghi Arzaghi changed the title remove some of the constructors just a draft Sep 15, 2020
@Arzaghi Arzaghi changed the title just a draft <complex>: prevent invalid conversions Sep 15, 2020
@Arzaghi Arzaghi marked this pull request as ready for review September 16, 2020 00:18
@Arzaghi Arzaghi requested a review from a team as a code owner September 16, 2020 00:18
@StephanTLavavej StephanTLavavej added the bug Something isn't working label Sep 16, 2020
StephanTLavavej
StephanTLavavej requested changes Sep 16, 2020
View reviewed changes
@StephanTLavavej StephanTLavavej mentioned this pull request Sep 16, 2020
Merged
@StephanTLavavej StephanTLavavej self-assigned this Sep 16, 2020
StephanTLavavej
StephanTLavavej approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks! 😺

@StephanTLavavej StephanTLavavej removed their assignment Sep 17, 2020
CaseyCarter
CaseyCarter approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice: an all-red PR. 🔥🔥🔥 Burn it all down! 🔥🔥🔥

@StephanTLavavej StephanTLavavej self-assigned this Sep 22, 2020
@StephanTLavavej StephanTLavavej merged commit 5847f82 into microsoft:master Sep 23, 2020
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Sep 23, 2020

Thanks for fixing this bug, slightly improving compiler throughput, and improving our libcxx pass rate! 😸

@Arzaghi Arzaghi deleted the Fix_Issue1256 branch September 23, 2020 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+1 more reviewer

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej StephanTLavavej

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

<complex>: invalid conversions allowed

3 participants

@Arzaghi @StephanTLavavej @CaseyCarter