Workaround VSO-1222776 in <ranges> #1287
Merged
+26
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
approved these changes
Sep 17, 2020
"EDG doesn't know that noexcept-specifiers of hidden friend functions are complete-class contexts"
StephanTLavavej
approved these changes
Sep 29, 2020
mnatsuhara
approved these changes
Sep 29, 2020
CaseyCarter
changed the title
Member
|
Thanks for reporting these bugs to EDG IntelliSense and ensuring a high-quality user experience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal IntelliSense bug
VSO-1132105 is triggered by referring to non-static data members of class templates with dependent type inVSO-1222776 is triggered by using the class type under definition as if it is complete within a noexcept-specifier of a hidden friend function. To minimize distractions while we're bringing up Concept support in IntelliSense, lets workaround occurrences innoexcept-specifiers<ranges>and relabel the workarounds in<xutility>which are mislabeled as workarounds for VSO-1132105.Heads up, @rpjohnst - this suppresses the majority of the failures from your most recent test run.