Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup headers #1270

Merged
merged 8 commits into from
Sep 26, 2020
Merged

Cleanup headers #1270

merged 8 commits into from
Sep 26, 2020

Conversation

SunnyWar
Copy link
Contributor

@SunnyWar SunnyWar commented Sep 5, 2020 •
edited
Loading

  1. Change deprecated headers to the modern equivalent.
  2. Remove unused headers.

@SunnyWar SunnyWar requested a review from a team as a code owner September 5, 2020 03:28
@CaseyCarter CaseyCarter added the enhancement Something can be improved label Sep 5, 2020
@CaseyCarter CaseyCarter marked this pull request as draft September 5, 2020 03:55
@SunnyWar SunnyWar changed the title WIP: Cleanup headers Cleanup headers Sep 5, 2020
@SunnyWar SunnyWar marked this pull request as ready for review September 5, 2020 06:39
CaseyCarter
CaseyCarter reviewed Sep 23, 2020
View reviewed changes
stl/src/filesys.cpp Show resolved Hide resolved
stl/src/special_math.cpp Outdated Show resolved Hide resolved
StephanTLavavej
StephanTLavavej requested changes Sep 23, 2020
View reviewed changes
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! After checking each of these changes, you have a lot of great finds of unused headers here. I commented every occurrence that I think needs to be restored/adjusted (in addition to the ones that @CaseyCarter noted); I think after one more revision this will be ready to merge. 😺

stl/src/thread0.cpp Outdated Show resolved Hide resolved
stl/src/xwcscoll.cpp Show resolved Hide resolved
stl/src/winapinls.cpp Show resolved Hide resolved
stl/src/taskscheduler.cpp Show resolved Hide resolved
stl/src/primitives.hpp Show resolved Hide resolved
stl/src/winapisupp.cpp Show resolved Hide resolved
stl/src/winapisupp.cpp Outdated Show resolved Hide resolved
stl/src/xmath.hpp Show resolved Hide resolved
stl/src/StlCompareStringW.cpp Show resolved Hide resolved
stl/src/StlLCMapStringW.cpp Show resolved Hide resolved
@StephanTLavavej StephanTLavavej self-assigned this Sep 23, 2020
StephanTLavavej
StephanTLavavej approved these changes Sep 24, 2020
View reviewed changes
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I pushed a one-line change to adjust the spacing before a comment in a clang-format-off block (we conventionally use one space before comments). This will also cycle the tests which timed out for an unknown infrastructure reason (I saw that affect another PR too).

@StephanTLavavej StephanTLavavej removed their assignment Sep 24, 2020
@StephanTLavavej StephanTLavavej mentioned this pull request Sep 24, 2020
Merged
@StephanTLavavej StephanTLavavej self-assigned this Sep 25, 2020
@StephanTLavavej StephanTLavavej merged commit 530bdc5 into microsoft:master Sep 26, 2020
@StephanTLavavej
Copy link
Member

Thanks again for cleaning this up! ✨ 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
enhancement Something can be improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SunnyWar @StephanTLavavej @CaseyCarter