feature/spaceship: Merge CI changes #1360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Minimal changes to support constexpr allocation in MSVC * Define `_CONSTEXPR20_DYNALLOC` macro to `constexpr` when the compiler defines `__cpp_constexpr_dynamic_alloc` and `inline` otherwise. * Implement and test `ranges::construct_at` and `ranges::destroy_at`, mark them (and `std` flavors) `_CONSTEXPR20_DYNALLOC`. * Implement `ranges::destroy` and `ranges::destroy_n` which share machinery with `ranges::destroy_at` with minimal test coverage. (More to follow.) [This is a dual of internal MSVC-PR-275909.]
Implement several specialized memory range algorithms: * `ranges::uninitialized_default_construct`, `ranges::uninitialized_default_construct_n` * `ranges::uninitialized_value_construct`, `ranges::uninitialized_value_construct_n` * `ranges::uninitialized_fill`, `ranges::uninitialized_fill_n` * `ranges::uninitialized_copy`, `ranges::uninitialized_copy_n` * `ranges::uninitialized_move_n` Co-authored-by: Adam Bucior <[email protected]> Co-authored-by: Stephan T. Lavavej <[email protected]>
Co-authored-by: Stephan T. Lavavej <[email protected]>
…1282) Co-authored-by: Stephan T. Lavavej <[email protected]>
Co-authored-by: Casey Carter <[email protected]>
Co-authored-by: Stephan T. Lavavej <[email protected]> Co-authored-by: Casey Carter <[email protected]>
…n derived classes (#1314)
Co-authored-by: Stephan T. Lavavej <[email protected]>
Co-authored-by: Casey Carter <[email protected]> Co-authored-by: Stephan T. Lavavej <[email protected]>
Co-authored-by: Stephan T. Lavavej <[email protected]>
Co-authored-by: Stephan T. Lavavej <[email protected]>
Co-authored-by: Stephan T. Lavavej <[email protected]>
…ht_shift_with_rounding (#1220) Co-authored-by: Stephan T. Lavavej <[email protected]>
Co-authored-by: MattStephanson <[email protected]> Co-authored-by: Curtis J Bezault <[email protected]> Co-authored-by: Stephan T. Lavavej <[email protected]>
…return type (#1293) Fixes #1292. Co-authored-by: Stephan T. Lavavej <[email protected]>
Co-authored-by: Stephan T. Lavavej <[email protected]>
Co-authored-by: Casey Carter <[email protected]>
Co-authored-by: Stephan T. Lavavej <[email protected]>
Co-authored-by: Praveen Ojha <[email protected]>
…he stream (#1326) Co-authored-by: Stephan T. Lavavej <[email protected]>
Makes `istream_iterator`, `ostream_iterator`, `istreambuf_iterator`, and `ostreambuf_iterator` model the C++20 iterator concepts.
Drive-by cleanup: * explicitly compare pointers with `nullptr` in preference to `if (ptr)` and `if (!ptr)` * `_STL_INTERNAL_CHECK` checkable preconditions * Use `constinit` when available to verify `constexpr` constructor Fixes #1309. Co-authored-by: Stephan T. Lavavej <[email protected]>
Removes workarounds for: * VSO-938163 "`constexpr` hates pointers", revealing VSO-1132704 "Bogus C3615 when implicitly-constexpr defaulted SMF calls non-trivial SMF in base class" and VSO-1217687 "Casting object reference to base and back loses track of member values in constant expression" beneath. * VSO-1002863 "Failure to short-circuit substitution when evaluating disjunction of atomic constraints" * VSO-1062618 "Asymmetric behavior from conditional operator with char32_t operands" * VSO-1125263 "EDG rejects valid code using consteval" * VSO-1132105 "[EDG] Error using non-static data member with dependent type in noexcept-specifier of member function template" * VSO-1132186 "[EDG] Weirdness with dependent template in noexcept-specifier" * VSO-1178211 "[EDG] Internal compiler error on template template parameter instantiated from inherited template" Also relabels the workarounds for VSO-1174090 "Assertion failure for member subobject with multiple prospective destructors" (which is fixed!) as workarounds for VSO-1225825 "ModuleReader doesn't understand concept overloading". As a bonus, remove unnecessary workarounds for DevCom-1159442 "type-constraint in deduced variable type fails when immediately following an if statement"; these type-constraints don't follow the _compound-statement_ of an `if` conditional, and so don't trigger the bug.
c70b7a8 corresponds to #1316 "Accept 80-bit `long double` in `<complex>`," which was ported into a late 16.8 preview. This will almost certainly be our last commit for 16.8. Not that not every preceding commit is in 16.8. This is fine: we need all shipping commits to be covered by the cgmanifest, it's ok to also cover some commits that won't ship until the next release.
StephanTLavavej
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To pick up #1337. This is a clean merge with no additional edits.