Skip to content

feat(frontend): add basetenkenizer backend - #2

Draft
maheshrbapatu wants to merge 86 commits into
mainfrom
maheshrbapatu/feat-basetenkenizer-frontend
Draft

feat(frontend): add basetenkenizer backend#2
maheshrbapatu wants to merge 86 commits into
mainfrom
maheshrbapatu/feat-basetenkenizer-frontend

Conversation

@maheshrbapatu

@maheshrbapatu maheshrbapatu commented Jul 29, 2026

Copy link
Copy Markdown
Owner

Overview:

Fork-local review mirror for ai-dynamo/dynamo#12376, implementing ai-dynamo/dynamo#12325. Use this PR for an isolated fork diff; upstream review and CI happen on ai-dynamo#12376.

Details:

  • Upgrade dynamo-tokenizers to 1.6.0, which exposes BasetenTokenizer.
  • Accept basetenkenizer through --tokenizer, DYN_TOKENIZER, JSON runtime configuration, and Rust string parsing.
  • Construct the Baseten backend while preserving HuggingFace fallback, sibling special-token metadata, and the existing L1 prefix cache.
  • Add focused configuration, parity, cache, segmented-encoding, and fallback tests.
  • Document configuration and compatibility behavior.

Related Issues

Validation

  • cargo check -p dynamo-llm --lib --locked
  • Rust tokenizer configuration tests (4 passed)
  • Model-card integration tests (10 passed)
  • General tokenizer tests (22 passed)
  • Focused Python frontend argument tests (3 passed)
  • Ruff, Rust formatting, codespell, and git diff --check

larroy and others added 2 commits July 29, 2026 18:20
Signed-off-by: Pedro Larroy <plarroy@nvidia.com>
Signed-off-by: Karen Chung <karenc@nvidia.com>
Co-authored-by: Pedro Larroy <plarroy@nvidia.com>
Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Karen Chung <karenc@nvidia.com>
Signed-off-by: PeaBrane <yanrpei@gmail.com>
@maheshrbapatu
maheshrbapatu deployed to external_collaborator July 29, 2026 18:38 — with GitHub Actions Active
@github-actions github-actions Bot added documentation Improvements or additions to documentation frontend labels Jul 29, 2026
Signed-off-by: Mahesh Bapatu <maheshbapatu@gmail.com>
@maheshrbapatu
maheshrbapatu force-pushed the maheshrbapatu/feat-basetenkenizer-frontend branch from 922879b to 337655f Compare July 29, 2026 18:41
@maheshrbapatu
maheshrbapatu had a problem deploying to external_collaborator July 29, 2026 18:41 — with GitHub Actions Failure
dmitry-tokarev-nv and others added 22 commits July 29, 2026 13:15
…7960) (ai-dynamo#12377)

Signed-off-by: Dmitry Tokarev <dtokarev@nvidia.com>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
…dynamo#12370)

Signed-off-by: Yuewei Na <nv-yna@users.noreply.github.com>
Co-authored-by: Yuewei Na <nv-yna@users.noreply.github.com>
Signed-off-by: Lavanya <lvijayakrish@nvidia.com>
…i-dynamo#12037)

Signed-off-by: Schwinn Saereesitthipitak <schwinns@nvidia.com>
…dynamo#12330)

Home, Community and the blog rendered unstyled in production. The components
mounted correctly, but their CSS never arrived: `global-theme: nvidia` overrides
the project `css:` and `js:` entries and the custom `footer:`, so `main.css` was
never linked and the `SITE_CSS` fallback in `CustomFooter.tsx` died with the
footer it lived in.

Move the landing and blog rules into page-level `<style>` components, the same
delivery `ReferenceStyles.tsx` and `RecipeStyles.tsx` already use — which is why
reference and recipe pages render correctly under the same theme.

- `LandingStyles.tsx` on `welcome.mdx` and `community/README.mdx`
- `BlogStyles.tsx` on the digest landing and all six article pages
- rules are moved out of `main.css`, not duplicated, so there is one source

Injected via `dangerouslySetInnerHTML` rather than as a text child: a text child
is escaped on render, turning every `>` child combinator into `&gt;`, which a
style element never decodes. These bundles carry 122 of them.

Declaration-level conservation against main: 2471 before, 2471 across
`main.css` + `LandingStyles` + `BlogStyles`, 0 lost. `fern check` 0 errors,
`sync_site_css --check` in sync, all 145 component-emitted classes covered.

Does not address `global-theme` replacing the project stylesheet rather than
layering over it, which also leaves `custom.js` dead in production and the
non-page-scoped sidebar rules undeliverable.
Signed-off-by: Zhuangcheng(Jesse) Gu <zcgu@connect.hku.hk>
Co-authored-by: Ryan McCormick <rmccormick@nvidia.com>
Signed-off-by: Kavita Narang <knarang@nvidia.com>
)

Signed-off-by: Lavanya <lvijayakrish@nvidia.com>
Signed-off-by: Jason Zhou (Engrg-Hardware 1) <jasonzho@nvidia.com>
Signed-off-by: Jason Zhou <jasonzho@nvidia.com>
Signed-off-by: hongkuanz <hongkuanz@nvidia.com>
Co-authored-by: Hongkuan Zhou <tedzhouhk@gmail.com>
Co-authored-by: hongkuanz <hongkuanz@nvidia.com>
Signed-off-by: Jacky <18255193+kthui@users.noreply.github.com>
Signed-off-by: hongkuanz <hongkuanz@nvidia.com>
Signed-off-by: pvijayakrish <pvijayakrish@nvidia.com>
Signed-off-by: Ryan McCormick <rmccormick@nvidia.com>
…ness workaround (ai-dynamo#12279)

Signed-off-by: Saravana Periyasamy <saperiyasamy@nvidia.com>
Signed-off-by: Karen Chung <karenc@nvidia.com>
athreesh and others added 26 commits July 30, 2026 17:56
Signed-off-by: Anish Maddipoti <amaddipoti@nvidia.com>
…o#12098)

Signed-off-by: Ishan Dhanani <ishandhanani@gmail.com>
Signed-off-by: cpakkamisaac-sae <cpakkamisaac@nvidia.com>
)

Signed-off-by: Schwinn Saereesitthipitak <galletas1712@users.noreply.github.com>
…11578)

Signed-off-by: WEI CHENG CHIU <waynehacking8@gmail.com>
…amo#11806)

Signed-off-by: Yiqiu Liu <yiqiuliu@amazon.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: h-avsha <avshalom.manevich@hcompany.ai>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
ai-dynamo#12400)

Signed-off-by: Schwinn Saereesitthipitak <schwinns@nvidia.com>
Signed-off-by: Anna Tchernych <atchernych@nvidia.com>
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
Co-authored-by: Anna Tchernych <atchernych@nvidia.com>
Signed-off-by: Schwinn Saereesitthipitak <schwinns@nvidia.com>
Signed-off-by: pvijayakrish <pvijayakrish@nvidia.com>
…ocality gating (ai-dynamo#11571)

Signed-off-by: Change72 <changg@nvidia.com>
Co-authored-by: Cursor Agent <agent@cursor.com>
Signed-off-by: jthomson04 <jwillthomson19@gmail.com>
… fails (ai-dynamo#12404)

Signed-off-by: Ryan McCormick <rmccormick@nvidia.com>
Signed-off-by: Krishnan Prashanth <kprashanth@nvidia.com>
Co-authored-by: Ryan McCormick <rmccormick@nvidia.com>
Signed-off-by: Schwinn Saereesitthipitak <schwinns@nvidia.com>
Signed-off-by: Ace Eldeib <aeldeib@coreweave.com>
Signed-off-by: Karen Chung <karenc@nvidia.com>
ai-dynamo#12036)

Signed-off-by: Rita Zhang <1856066+ritazh@users.noreply.github.com>
Signed-off-by: Ace Eldeib <aeldeib@coreweave.com>
Signed-off-by: maheshrbapatu <maheshbapatu@gmail.com>
@maheshrbapatu
maheshrbapatu had a problem deploying to external_collaborator July 31, 2026 15:35 — with GitHub Actions Failure
@github-actions github-actions Bot added the xpu label Jul 31, 2026
@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions Bot added the Stale label Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.