fix(ci): remove Grove mutation assertion - #12399
Merged
Merged
Conversation
Signed-off-by: Lavanya <lvijayakrish@nvidia.com>
nv-tusharma
approved these changes
Jul 29, 2026
nv-tusharma
left a comment
Collaborator
There was a problem hiding this comment.
approving to unblock CI
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughThe operator setup action removes the Grove defaulting-webhook mutation assertion from the smoke-test step. It continues running the Grove PodCliqueSet smoke test and verifying the defaulting and validating webhook configurations. ChangesGrove webhook verification
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
This comment has been minimized.
This comment has been minimized.
sara4dev
approved these changes
Jul 29, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview:
Follow-up to #12368 that prevents the deploy-operator CI job from reporting a false
Grove webhook failure.
Details:
Remove the explicit headlessServiceConfig JSON assertion.
Keep the real server-side PodCliqueSet admission request.
Keep the mutating and validating webhook configuration checks.
Avoid a false failure when a successful kubectl response includes a warning before
the JSON output, causing jq to report a parse error.
The failed CI output confirmed that Grove applied the expected mutation
successfully.
Validated by parsing the composite action YAML and checking all embedded Bash blocks
with bash -n.
Where should the reviewer start?
Review .github/actions/setup-dynamo-operator/action.yml, specifically the Grove
admission smoke test in the Verify operator image and admission webhooks step.
Related Issues
🔗 This PR is linked to an issue:
Summary by CodeRabbit