Skip to content

fix(ci): remove Grove mutation assertion - #12399

Merged
dagil-nvidia merged 1 commit into
mainfrom
fix/remove-grove-mutation-assertion
Jul 29, 2026
Merged

fix(ci): remove Grove mutation assertion#12399
dagil-nvidia merged 1 commit into
mainfrom
fix/remove-grove-mutation-assertion

Conversation

@lavanyavijayk

@lavanyavijayk lavanyavijayk commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Overview:

Follow-up to #12368 that prevents the deploy-operator CI job from reporting a false
Grove webhook failure.

Details:

  • Remove the explicit headlessServiceConfig JSON assertion.

  • Keep the real server-side PodCliqueSet admission request.

  • Keep the mutating and validating webhook configuration checks.

  • Avoid a false failure when a successful kubectl response includes a warning before
    the JSON output, causing jq to report a parse error.

  • The failed CI output confirmed that Grove applied the expected mutation
    successfully.

Validated by parsing the composite action YAML and checking all embedded Bash blocks
with bash -n.

Where should the reviewer start?

Review .github/actions/setup-dynamo-operator/action.yml, specifically the Grove
admission smoke test in the Verify operator image and admission webhooks step.

Related Issues

🔗 This PR is linked to an issue:


Open in Devin Review

Summary by CodeRabbit

  • Bug Fixes
    • Updated operator verification to use the Grove PodCliqueSet webhook smoke test.
    • Removed an outdated admission webhook mutation check from the verification workflow.
    • Continued validation of Grove defaulting and validating webhook configurations.

Signed-off-by: Lavanya <lvijayakrish@nvidia.com>
@lavanyavijayk
lavanyavijayk requested a review from a team as a code owner July 29, 2026 22:38

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@nv-tusharma nv-tusharma left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving to unblock CI

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5f38179b-c2df-4c33-a556-420f30a2ad99

📥 Commits

Reviewing files that changed from the base of the PR and between a2cfdc9 and f32d264.

📒 Files selected for processing (1)
  • .github/actions/setup-dynamo-operator/action.yml

Walkthrough

The operator setup action removes the Grove defaulting-webhook mutation assertion from the smoke-test step. It continues running the Grove PodCliqueSet smoke test and verifying the defaulting and validating webhook configurations.

Changes

Grove webhook verification

Layer / File(s) Summary
Simplify Grove admission smoke verification
.github/actions/setup-dynamo-operator/action.yml
Runs the Grove PodCliqueSet smoke test without the removed headlessServiceConfig mutation assertion, while retaining webhook configuration checks.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely matches the main change: removing the Grove mutation assertion from CI.
Description check ✅ Passed The description covers Overview, Details, reviewer start, and Related Issues, matching the template well enough.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@datadog-official

This comment has been minimized.

@dagil-nvidia
dagil-nvidia merged commit be9dd5a into main Jul 29, 2026
65 of 67 checks passed
@dagil-nvidia
dagil-nvidia deleted the fix/remove-grove-mutation-assertion branch July 29, 2026 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants