fix(operator): allow component-scoped topology

[alexeldeib]

Overview

Align DGD webhook validation with the existing component-scoped topology design. This allows GPU workers to be rack-packed while CPU frontends and auxiliary components remain topology-free.

Details

• Allow a deployment topology without packDomain when at least one component defines its own topology constraint.
• Continue rejecting configurations with neither a deployment-level packDomain nor any component-scoped constraint.
• Add positive and negative admission coverage while preserving independent topology error aggregation.

This matches the documented service-level-only topology behavior and the existing Grove render path.

Where should the reviewer start?

• deploy/operator/internal/webhook/validation/dynamographdeployment.go
• deploy/operator/internal/webhook/validation/dynamographdeployment_validation_envtest_test.go

Validation

• make envtest ENVTEST_PACKAGES=./internal/webhook/validation
• go vet ./internal/webhook/validation

Related Issues

🔗 This PR is linked to an issue:

• Relates to fix(operator): emit Grove alpha.11 topology constraint fields #11399

Related design: ai-dynamo/enhancements#69

---

Summary by CodeRabbit

• Bug Fixes
  • Improved validation for deployment and component topology constraints.
  • Component-level constraints with a pack domain now allow other components to remain unconstrained.
  • Added clearer required-field validation when no deployment- or component-level topology constraint is configured.
  • Updated validation error reporting for more accurate field paths and aggregated errors.

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[github-actions]

👋 Hi alexeldeib! Thank you for contributing to ai-dynamo/dynamo.

Just a reminder: The NVIDIA Test Github Validation CI runs an essential subset of the testing framework to quickly catch errors.Your PR reviewers may elect to test the changes comprehensively before approving your changes.

🚀

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6c72c97a-93e5-49cf-b896-613820707d5b

📥 Commits

Reviewing files that changed from the base of the PR and between 6cc7c4e and dc83c5a.

📒 Files selected for processing (2)

• deploy/operator/internal/webhook/validation/dynamographdeployment.go
• deploy/operator/internal/webhook/validation/dynamographdeployment_validation_envtest_test.go

---

Walkthrough

The DynamoGraphDeployment validator now recognizes topology constraints at both deployment and component scope. Missing pack-domain validation and environment-test expectations were updated accordingly.

Changes

Topology validation

Layer / File(s)	Summary
Constraint detection and required-field validation deploy/operator/internal/webhook/validation/dynamographdeployment.go	Topology validation considers deployment-level or component-level constraints, and only requires deployment packDomain when no component constraint exists.
Environment validation coverage deploy/operator/internal/webhook/validation/dynamographdeployment_validation_envtest_test.go	Tests cover component-provided pack domains, the no-constraint required-field error, and updated aggregated topology errors.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the main change: enabling component-scoped topology.
Description check	✅ Passed	The description includes overview, details, reviewer start points, validation, and a linked issue, matching the template well.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies"

---

_{Comment @coderabbitai help to get the list of available commands.}

[devin-ai-integration]

Devin Review found 2 potential issues.

[julienmancuso]

/ok to test 25950c0

[athreesh]

/ok to test 8ef5c1f