test(operator): cover GMS discovery annotation pruning

[julienmancuso]

Summary

Backfill regression coverage for OPS-7060 / NVBug 6176646.

• Verify v1beta1 DCD pod-template annotations survive an API-server round trip.
• Verify v1beta1 DGD component pod-template annotations survive structural pruning.
• Assert intra-pod failover engines retain DYN_KUBE_DISCOVERY_MODE=container.
• Assert engine-0 and engine-1 receive distinct CONTAINER_NAME values.

This MR changes tests only; production behavior is unchanged.

Validation

• go test ./internal/dynamo -count=1
• go test ./internal/webhook/validation -count=1
• git diff --check

Closes OPS-7060

---

Summary by CodeRabbit

• Bug Fixes

  • Preserved pod-template annotations, including VLLM backend and container discovery settings, through API admission and round trips.
  • Ensured failover engine containers receive the correct container discovery environment settings.

• Tests

  • Added validation coverage for annotation preservation and failover environment variables.

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f3e50007-84d4-43bf-9953-b7019e0fb42d

📥 Commits

Reviewing files that changed from the base of the PR and between 329aba5 and b9b2903.

📒 Files selected for processing (3)

• deploy/operator/internal/dynamo/failover_test.go
• deploy/operator/internal/webhook/validation/dynamocomponentdeployment_validation_envtest_test.go
• deploy/operator/internal/webhook/validation/dynamographdeployment_validation_envtest_test.go

---

Walkthrough

Changes

Container discovery validation

Layer / File(s)	Summary
Failover container environment checks deploy/operator/internal/dynamo/failover_test.go	Failover pod and cloned engine tests now verify CONTAINER_NAME and DYN_KUBE_DISCOVERY_MODE=container environment variables.
Admission annotation preservation deploy/operator/internal/webhook/validation/*deployment_validation_envtest_test.go	Component and graph deployment envtests now compare expected pod-template annotations after admission and API-server conversion, including VLLM and Dynamo Kubernetes discovery annotations.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR text covers summary, validation, and issue linkage, but it omits the required Overview, Details, and Where should reviewer start sections.	Reformat the description to the repository template and add the missing Overview, Details, and reviewer-start sections; keep the related issue entry.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is concise and matches the main change: regression coverage for discovery annotation pruning.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies"

---

_{Comment @coderabbitai help to get the list of available commands.}