fix(gms): support SGLang 0.5.16 memory pool API - #12445
Merged
Merged
Conversation
Contributor
Walkthrough
ChangesSGLang memory patching
Estimated code review effort: 3 (Moderate) | ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@lib/gpu_memory_service/integrations/sglang/patches.py`:
- Around line 182-190: Update the baseline-adjustment logic around
_gms_memory_baseline_adjusted to access self.pre_model_load_memory directly and
remove the getattr fallback and numeric-type guard, so missing or invalid
baselines raise while preserving the existing one-time adjustment behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: fc9f0a29-eb00-4028-8399-e4505230adf0
📒 Files selected for processing (2)
lib/gpu_memory_service/integrations/sglang/patches.pylib/gpu_memory_service/tests/test_sglang_patches.py
|
🎯 Code Coverage (details) 🔗 Commit SHA: 7ce711b | Docs | Datadog PR Page | Give us feedback! |
Signed-off-by: Schwinn Saereesitthipitak <schwinns@nvidia.com>
galletas1712
force-pushed
the
fix/dyn-3690-sglang-gms-memory-pool
branch
from
July 30, 2026 22:43
c53907e to
0cba288
Compare
Signed-off-by: Schwinn Saereesitthipitak <schwinns@nvidia.com>
mohammedabdulwahhab
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
alloc_memory_poolAPI.Validation
components/src/dynamo/sglang/tests/test_sglang_gms_memory_saver.pylib/gpu_memory_service/tests/test_sglang_patches.pytest_gms_basic_pause_resume_sglangtest_gms_shadow_engine_failover_sglangalloc_memory_poolapplied the preloaded-weight baseline adjustment, and pause/resume plus post-failover inference returned HTTP 200. All Early Flake Detection retries also passed.Related Issues