Skip to content

ci(snapshot): gate DynamoCheckpoint CI on framework snapshot paths - #12037

Merged
galletas1712 merged 3 commits into
mainfrom
ci/framework-snapshot-dynamocheckpoint-filters
Jul 29, 2026
Merged

ci(snapshot): gate DynamoCheckpoint CI on framework snapshot paths#12037
galletas1712 merged 3 commits into
mainfrom
ci/framework-snapshot-dynamocheckpoint-filters

Conversation

@galletas1712

@galletas1712 galletas1712 commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add snapshot_vllm / snapshot_sglang / snapshot_trtllm CI filters for each backend's snapshot.py and TRT-LLM's existing test_trtllm_snapshot.py.
  • Wire those filters into the matching DynamoCheckpoint deploy jobs in pr.yaml, so a framework-local snapshot change runs that backend's suite instead of being skipped.
  • Keep the shared snapshot filter for agent/operator/deploy paths (still runs all three frameworks).
  • Document the filters and cover them in .github/scripts/test-filters.js.

Fixes the gap seen on #11744, where vLLM/TRT-LLM snapshot warmup changes triggered backend unit tests but skipped all DynamoCheckpoint jobs.

Validation

  • cd .github/scripts && npm test — 26/26 filter pattern tests passed
  • CI path detection on this PR (expect snapshot_vllm/snapshot_trtllm only if those files change; this PR changes filters/workflows so core/ci will also match)

Open in Devin Review

Summary by CodeRabbit

  • CI Improvements

    • Added framework-specific snapshot change detection for vLLM, SGLang, and TRT-LLM.
    • Updated pull request checks to run the appropriate build, test, deployment, checkpoint, and image workflows when related snapshot changes are detected.
    • Shared snapshot and DynamoCheckpoint changes now trigger the relevant common validation workflows.
  • Documentation

    • Clarified snapshot filter coverage and trigger behavior.
  • Tests

    • Added coverage for framework-specific and shared snapshot change scenarios.

@galletas1712
galletas1712 requested a review from a team as a code owner July 22, 2026 20:45
@github-actions github-actions Bot added ci Issues/PRs that reference CI build/test documentation Improvements or additions to documentation actions labels Jul 22, 2026

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

Comment thread .github/workflows/pr.yaml
@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Snapshot CI detection now distinguishes vLLM, SGLang, and TRT-LLM changes, exposes corresponding outputs, validates filter behavior, and routes framework-specific build, deployment, testing, and cleanup jobs.

Changes

Snapshot CI routing

Layer / File(s) Summary
Snapshot filter definitions and validation
.github/FILTERS.md, .github/filters.yaml, .github/scripts/test-filters.js
Documents shared and framework-specific snapshot filters, defines their paths, and adds matching test cases.
Changed-files output propagation
.github/actions/changed-files/action.yml
Adds framework-specific outputs, debug logging, and coverage tracking for snapshot filters.
Framework build and image routing
.github/workflows/pr.yaml
Routes framework snapshot outputs into build, frontend, image-copy, placeholder, operator, and snapshot-agent job conditions.
Checkpoint deployment and cleanup routing
.github/workflows/pr.yaml
Gates framework-specific operator, snapshot-agent, deployment-test, and cleanup jobs using matching snapshot outputs.

Estimated code review effort: 3 (Moderate) | ~25 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers the change and validation, but it misses required template sections like Overview, Details, reviewer start, and Related Issues. Rewrite the PR description to match the template, including Overview, Details, Where should the reviewer start?, and a completed Related Issues section.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately summarizes the main change: gating DynamoCheckpoint CI on framework-specific snapshot paths.

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/scripts/test-filters.js:
- Around line 191-199: Add a test-filter matrix entry in the surrounding cases
of .github/scripts/test-filters.js for
components/src/dynamo/sglang/tests/test_sglang_snapshot.py, asserting
snapshot_sglang is true while sglang, snapshot, snapshot_vllm, and
snapshot_trtllm are false, consistent with the existing SGLang snapshot.py case.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a10cde60-c696-4500-96a6-8b28371d6377

📥 Commits

Reviewing files that changed from the base of the PR and between c2ea0c4 and 6dfd42d.

📒 Files selected for processing (5)
  • .github/FILTERS.md
  • .github/actions/changed-files/action.yml
  • .github/filters.yaml
  • .github/scripts/test-filters.js
  • .github/workflows/pr.yaml

Comment thread .github/scripts/test-filters.js
@datadog-official

datadog-official Bot commented Jul 22, 2026

Copy link
Copy Markdown

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 44.97% (+7.05%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a9ce30d | Docs | Datadog PR Page | Give us feedback!

Comment thread .github/workflows/pr.yaml
@nv-tusharma

Copy link
Copy Markdown
Collaborator

snapshot_vllm/snapshot_sglang list test_vllm_snapshot.py/test_sglang_snapshot.py, which do not exist on this branch or main (only trtllm's does) — those two lines are dead and the "unit tests" wording overstates coverage. Suggest dropping them (keep the snapshot.py paths) or confirming they're intentional placeholders.

@galletas1712

Copy link
Copy Markdown
Contributor Author

@nv-tusharma Addressed in 36b90ca: removed the nonexistent vLLM/SGLang test_*_snapshot.py filter entries and their synthetic filter-test cases, while retaining each backend’s snapshot.py path and TRT-LLM’s existing unit-test path. I also corrected the coverage wording in filters.yaml and the PR summary. Validation: .github/scripts && npm test passes 26/26 cases; git diff --check passes.

@galletas1712
galletas1712 force-pushed the ci/framework-snapshot-dynamocheckpoint-filters branch from 36b90ca to 08664e9 Compare July 27, 2026 21:40
@copy-pr-bot

copy-pr-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@galletas1712
galletas1712 force-pushed the ci/framework-snapshot-dynamocheckpoint-filters branch from 08664e9 to dad6b09 Compare July 27, 2026 21:52
@galletas1712

Copy link
Copy Markdown
Contributor Author

/ok to test dad6b09

@galletas1712
galletas1712 enabled auto-merge (squash) July 27, 2026 22:48
@galletas1712
galletas1712 force-pushed the ci/framework-snapshot-dynamocheckpoint-filters branch from dad6b09 to 3c2df77 Compare July 28, 2026 03:50
@galletas1712

Copy link
Copy Markdown
Contributor Author

/ok to test 3c2df77

@galletas1712
galletas1712 force-pushed the ci/framework-snapshot-dynamocheckpoint-filters branch from 3c2df77 to ae16d63 Compare July 28, 2026 17:07
@galletas1712

Copy link
Copy Markdown
Contributor Author

/ok to test ae16d63

Framework snapshot.py and test_*_snapshot.py only matched backend filters,
so DynamoCheckpoint deploy jobs were skipped. Add per-framework snapshot
filters and wire each suite to its own paths.

Signed-off-by: Schwinn Saereesitthipitak <schwinns@nvidia.com>
Signed-off-by: Schwinn Saereesitthipitak <schwinns@nvidia.com>
Signed-off-by: Schwinn Saereesitthipitak <schwinns@nvidia.com>
@galletas1712
galletas1712 force-pushed the ci/framework-snapshot-dynamocheckpoint-filters branch from ae16d63 to a9ce30d Compare July 29, 2026 20:01
@galletas1712

Copy link
Copy Markdown
Contributor Author

/ok to test ae16d63

@copy-pr-bot

copy-pr-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown

/ok to test ae16d63

@galletas1712, there was an error processing your request: E2

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/

@galletas1712

Copy link
Copy Markdown
Contributor Author

/ok to test a9ce30d

@galletas1712
galletas1712 merged commit a2cfdc9 into main Jul 29, 2026
179 of 184 checks passed
@galletas1712
galletas1712 deleted the ci/framework-snapshot-dynamocheckpoint-filters branch July 29, 2026 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions ci Issues/PRs that reference CI build/test documentation Improvements or additions to documentation size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants