fix(plugin-qrcode): skip interactive loop in non-TTY environments (#2201) by knullptr · Pull Request #2202 · lynx-family/lynx-stack

knullptr · 2026-02-09T06:09:19Z

When stdin is not a TTY (CI, piped output, Docker without -it), the interactive shortcut menu is now skipped to prevent hangs, while still printing the QR code.

Summary by CodeRabbit

Bug Fixes
- Plugin no longer blocks or prompts in non-interactive/automated environments; it skips the interactive loop to avoid hangs or unexpected prompts.
Chores
- Added a patch release note marker documenting this behavior change for the QR code plugin.

Checklist

Tests updated (or not required). not required.
Documentation updated (or not required). not required.
Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required). not required.

changeset-bot · 2026-02-09T06:09:25Z

🦋 Changeset detected

Latest commit: 4c19c08

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@lynx-js/qrcode-rsbuild-plugin	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

cla-assistant · 2026-02-09T06:09:33Z

All committers have signed the CLA.

coderabbitai · 2026-02-09T06:09:45Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

📝 Walkthrough

Walkthrough

Added an early-return guard in the QR code plugin's loop to detect non-interactive stdin (via process.stdin.isTTY and related properties) so the loop exits when stdin is unavailable; also added a changeset entry noting the behavior. No public API changes.

Changes

Cohort / File(s)	Summary
QR Code Loop Guard `packages/rspeedy/plugin-qrcode/src/shortcuts.ts`	Added an early-return guard in the loop function to skip execution when stdin is non-interactive (non-TTY).
Changeset / Release Note `.changeset/quiet-dogs-sleep.md`	Added a patch changeset describing the non-TTY/interactive-loop behavior change for the QR code plugin.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

colinaaa

Poem

🐰 I sniffed the stdin, quiet and spry,
If TTY's sleeping, I let the loop lie.
No prompts in the dark, I hop away light,
Safe little guard keeps the prompts polite. 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: fixing the qrcode plugin to skip interactive loops in non-TTY environments, which directly matches the code changes and PR objectives.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-02-09T07:07:24Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

codspeed-hq · 2026-02-09T07:16:17Z

CodSpeed Performance Report

Merging this PR will degrade performance by 10.33%

_{Comparing knullptr:main (4c19c08) with main (82068ae)}

Summary

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 61 untouched benchmarks
⏩ 3 skipped benchmarks¹

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
❌	`transform 1000 view elements`	40.3 ms	44.9 ms	-10.33%
⚡	`basic-performance-nest-level-100`	7.8 ms	6.9 ms	+12.92%

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

relativeci · 2026-02-09T07:30:15Z

Web Explorer

#7579 Bundle Size — 383.74KiB (0%).

4c19c08(current) vs a10b3ec main#7575(baseline)

Bundle metrics no changes

	Current #7579	Baseline #7575
Initial JS	`154.88KiB`	`154.88KiB`
Initial CSS	`35.06KiB`	`35.06KiB`
Cache Invalidation	`0%`	`0%`
Chunks	`8`	`8`
Assets	`8`	`8`
Modules	`238`	`238`
Duplicate Modules	`16`	`16`
Duplicate Code	`2.99%`	`2.99%`
Packages	`4`	`4`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #7579	Baseline #7575
JS	`252.82KiB`	`252.82KiB`
Other	`95.85KiB`	`95.85KiB`
CSS	`35.06KiB`	`35.06KiB`

Bundle analysis report Branch knullptr:main Project dashboard

^{Generated by RelativeCI Documentation Report issue}

…x-family#2201) Add TTY check before starting keyboard shortcuts loop to prevent errors in non-interactive environments such as CI/CD pipelines or piped commands. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

colinaaa

Thank you!

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @lynx-js/motion@0.0.3 ### Patch Changes - Fix an issue that motion/mini will accidentally imports full version, causing compiling error ([#2204](#2204)) ## @lynx-js/react@0.116.3 ### Patch Changes - fix: remove `lynx.createSelectorQuery` deprecated warning in production ([#2195](#2195)) - Add a DEV-only guard that detects MainThread flush loops caused by re-entrant MTS handlers. ([#2159](#2159)) This typically happens when a MainThread handler (e.g. event callback or `MainThreadRef`) performs UI mutations (like `Element.setStyleProperty`, `setStyleProperties`, `setAttribute`, or `invoke`) that synchronously trigger a flush which re-enters the handler again. - Avoid DEV_ONLY_SetSnapshotEntryName on standalone lazy bundle. ([#2184](#2184)) - Add alog and trace for BTS event handlers. ([#2102](#2102)) - fix: Main thread functions cannot access properties on `this` before hydration completes. ([#2194](#2194)) This fixes the `cannot convert to object` error. - Remove element api calls alog by default, and only enable it when `__ALOG_ELEMENT_API__` is defined to `true` or environment variable `REACT_ALOG_ELEMENT_API` is set to `true`. ([#2192](#2192)) - fix: captured variables in main thread functions within class components do not update correctly ([#2197](#2197)) ## @lynx-js/rspeedy@0.13.4 ### Patch Changes - Bump ts-blank-space v0.7.0 ([#2238](#2238)) - Bump Rsbuild v1.7.3 with Rspack v1.7.5. ([#2189](#2189)) - Updated dependencies \[]: - @lynx-js/web-rsbuild-server-middleware@0.19.8 ## @lynx-js/qrcode-rsbuild-plugin@0.4.5 ### Patch Changes - Only register console shortcuts when running in TTY environments ([#2202](#2202)) ## @lynx-js/react-rsbuild-plugin@0.12.8 ### Patch Changes - Updated dependencies \[[`4240138`](4240138)]: - @lynx-js/react-webpack-plugin@0.7.4 - @lynx-js/react-alias-rsbuild-plugin@0.12.8 - @lynx-js/use-sync-external-store@1.5.0 - @lynx-js/react-refresh-webpack-plugin@0.3.4 - @lynx-js/template-webpack-plugin@0.10.3 ## @lynx-js/testing-environment@0.1.11 ### Patch Changes - Remove element api calls alog by default, and only enable it when `__ALOG_ELEMENT_API__` is defined to `true` or environment variable `REACT_ALOG_ELEMENT_API` is set to `true`. ([#2192](#2192)) ## @lynx-js/web-constants@0.19.8 ### Patch Changes - Updated dependencies \[]: - @lynx-js/web-worker-rpc@0.19.8 ## @lynx-js/web-core@0.19.8 ### Patch Changes - fix: avoid error when LynxView is removed immediately after connected ([#2182](#2182)) - Updated dependencies \[]: - @lynx-js/web-constants@0.19.8 - @lynx-js/web-mainthread-apis@0.19.8 - @lynx-js/web-worker-rpc@0.19.8 - @lynx-js/web-worker-runtime@0.19.8 ## @lynx-js/web-core-wasm@0.0.3 ### Patch Changes - Updated dependencies \[[`e0972ef`](e0972ef), [`3bc017e`](3bc017e), [`e2d349e`](e2d349e), [`d924b6a`](d924b6a)]: - @lynx-js/web-elements@0.11.2 - @lynx-js/web-worker-rpc@0.19.8 ## @lynx-js/web-elements@0.11.2 ### Patch Changes - Add scrollHeight/scrollWidth getters to XList. ([#2156](#2156)) - Inherit padding styles for x-input elements. ([#2199](#2199)) - Remove the default lazy-loading attribute from x-image elements. ([#2186](#2186)) - Fix x-input number type forwarding to the inner input element. ([#2193](#2193)) ## @lynx-js/web-mainthread-apis@0.19.8 ### Patch Changes - Updated dependencies \[]: - @lynx-js/web-constants@0.19.8 ## @lynx-js/web-worker-runtime@0.19.8 ### Patch Changes - Updated dependencies \[]: - @lynx-js/web-constants@0.19.8 - @lynx-js/web-mainthread-apis@0.19.8 - @lynx-js/web-worker-rpc@0.19.8 ## @lynx-js/react-webpack-plugin@0.7.4 ### Patch Changes - Remove element api calls alog by default, and only enable it when `__ALOG_ELEMENT_API__` is defined to `true` or environment variable `REACT_ALOG_ELEMENT_API` is set to `true`. ([#2192](#2192)) ## create-rspeedy@0.13.4 ## @lynx-js/react-alias-rsbuild-plugin@0.12.8 ## upgrade-rspeedy@0.13.4 ## @lynx-js/web-core-server@0.19.8 ## @lynx-js/web-rsbuild-server-middleware@0.19.8 ## @lynx-js/web-worker-rpc@0.19.8 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

knullptr requested review from colinaaa, luhc228 and upupming as code owners February 9, 2026 06:09

knullptr force-pushed the main branch 3 times, most recently from 60553b4 to 131b76d Compare February 9, 2026 06:42

knullptr force-pushed the main branch from 4f5b13b to 4c19c08 Compare February 9, 2026 12:17

luhc228 approved these changes Feb 9, 2026

View reviewed changes

colinaaa approved these changes Feb 10, 2026

View reviewed changes

colinaaa enabled auto-merge (squash) February 10, 2026 03:16

colinaaa merged commit 9f6c756 into lynx-family:main Feb 10, 2026
75 of 78 checks passed

github-actions bot mentioned this pull request Feb 10, 2026

chore: Release 2026-02-21 04:23:50 #2183

Merged

coderabbitai bot mentioned this pull request Feb 12, 2026

feat: print all entries and schema URLs in non-TTY mode (#2226) #2227

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(plugin-qrcode): skip interactive loop in non-TTY environments (#2201)#2202

fix(plugin-qrcode): skip interactive loop in non-TTY environments (#2201)#2202
colinaaa merged 1 commit intolynx-family:mainfrom
knullptr:main

knullptr commented Feb 9, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Feb 9, 2026 •

edited

Loading

Uh oh!

cla-assistant bot commented Feb 9, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Feb 9, 2026 •

edited

Loading

Reviews paused

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Poem

Uh oh!

codecov bot commented Feb 9, 2026 •

edited

Loading

Uh oh!

codspeed-hq bot commented Feb 9, 2026 •

edited

Loading

Uh oh!

relativeci bot commented Feb 9, 2026 •

edited

Loading

Uh oh!

colinaaa left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

knullptr commented Feb 9, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Checklist

Uh oh!

changeset-bot bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

cla-assistant bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Poem

Uh oh!

codecov bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codspeed-hq bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging this PR will degrade performance by 10.33%

Summary

Performance Changes

Footnotes

Uh oh!

relativeci bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Web Explorer

#7579 Bundle Size — 383.74KiB (0%).

Uh oh!

colinaaa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

knullptr commented Feb 9, 2026 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Feb 9, 2026 •

edited

Loading

cla-assistant bot commented Feb 9, 2026 •

edited

Loading

coderabbitai bot commented Feb 9, 2026 •

edited

Loading

codecov bot commented Feb 9, 2026 •

edited

Loading

codspeed-hq bot commented Feb 9, 2026 •

edited

Loading

relativeci bot commented Feb 9, 2026 •

edited

Loading