Skip to content

fix: Inherit padding for x-input and add fixture coverage#2199

Merged
Sherry-hue merged 4 commits intomainfrom
copilot/add-padding-inherit-to-x-input
Feb 9, 2026
Merged

fix: Inherit padding for x-input and add fixture coverage#2199
Sherry-hue merged 4 commits intomainfrom
copilot/add-padding-inherit-to-x-input

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 6, 2026

  • Update x-input snapshots affected by padding inheritance
  • Verify updated snapshots in web-elements Playwright tests
  • Provide updated UI screenshot in response and reply to PR comment

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 6, 2026

🦋 Changeset detected

Latest commit: ce25a24

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@lynx-js/web-elements Patch
@lynx-js/web-core-wasm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Co-authored-by: PupilTong <12288479+PupilTong@users.noreply.github.com>
Copilot AI changed the title [WIP] Add padding inherit to x-input component Inherit padding for x-input and add fixture coverage Feb 6, 2026
Copilot AI requested a review from PupilTong February 6, 2026 06:36
@PupilTong PupilTong marked this pull request as ready for review February 6, 2026 06:41
@PupilTong PupilTong requested a review from Sherry-hue as a code owner February 6, 2026 06:41
@PupilTong PupilTong changed the title Inherit padding for x-input and add fixture coverage fix: Inherit padding for x-input and add fixture coverage Feb 6, 2026
Sherry-hue
Sherry-hue previously approved these changes Feb 6, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Feb 6, 2026

Merging this PR will degrade performance by 10.96%

❌ 3 regressed benchmarks
✅ 60 untouched benchmarks
⏩ 3 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
basic-performance-div-100 6.9 ms 7.5 ms -8.02%
basic-performance-div-10000 455.6 ms 480 ms -5.08%
transform 1000 view elements 42.3 ms 47.5 ms -10.96%

Comparing copilot/add-padding-inherit-to-x-input (ce25a24) with main (bf1a177)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@PupilTong
Copy link
Copy Markdown
Collaborator

@copilot update all affected screenshots

Co-authored-by: PupilTong <12288479+PupilTong@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Feb 6, 2026

@copilot update all affected screenshots

Updated the full set of x-input snapshots and captured the new padding inheritance baseline. Screenshot: x-input padding inherit

Commit: efa8296

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • esm.ubuntu.com
    • Triggering command: /usr/lib/apt/methods/https /usr/lib/apt/methods/https conntrack /usr/bin/cat cat /pro�� o | grep &#34;physical id&#34; | sort |uniq | wc -l cat /usr/bin/uniq (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@relativeci
Copy link
Copy Markdown

relativeci bot commented Feb 9, 2026

Web Explorer

#7558 Bundle Size — 383.74KiB (~+0.01%).

ce25a24(current) vs bf1a177 main#7552(baseline)

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#7558
     Baseline
#7552
No change  Initial JS 154.88KiB 154.88KiB
Regression  Initial CSS 35.06KiB(+0.04%) 35.05KiB
Change  Cache Invalidation 9.13% 0%
No change  Chunks 8 8
No change  Assets 8 8
No change  Modules 238 238
No change  Duplicate Modules 16 16
No change  Duplicate Code 2.99% 2.99%
No change  Packages 4 4
No change  Duplicate Packages 0 0
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#7558
     Baseline
#7552
No change  JS 252.83KiB 252.83KiB
No change  Other 95.85KiB 95.85KiB
Regression  CSS 35.06KiB (+0.04%) 35.05KiB

Bundle analysis reportBranch copilot/add-padding-inherit-to-x...Project dashboard


Generated by RelativeCIDocumentationReport issue

@PupilTong PupilTong force-pushed the copilot/add-padding-inherit-to-x-input branch from 01f0e7f to ce25a24 Compare February 9, 2026 04:42
@Sherry-hue Sherry-hue self-requested a review February 9, 2026 06:42
@Sherry-hue Sherry-hue merged commit 3bc017e into main Feb 9, 2026
44 of 45 checks passed
@Sherry-hue Sherry-hue deleted the copilot/add-padding-inherit-to-x-input branch February 9, 2026 06:42
colinaaa pushed a commit that referenced this pull request Feb 23, 2026
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @lynx-js/motion@0.0.3

### Patch Changes

- Fix an issue that motion/mini will accidentally imports full version,
causing compiling error
([#2204](#2204))

## @lynx-js/react@0.116.3

### Patch Changes

- fix: remove `lynx.createSelectorQuery` deprecated warning in
production
([#2195](#2195))

- Add a DEV-only guard that detects MainThread flush loops caused by
re-entrant MTS handlers.
([#2159](#2159))

This typically happens when a MainThread handler (e.g. event callback or
`MainThreadRef`) performs UI mutations (like `Element.setStyleProperty`,
`setStyleProperties`, `setAttribute`, or `invoke`) that synchronously
trigger a flush which re-enters the handler again.

- Avoid DEV_ONLY_SetSnapshotEntryName on standalone lazy bundle.
([#2184](#2184))

- Add alog and trace for BTS event handlers.
([#2102](#2102))

- fix: Main thread functions cannot access properties on `this` before
hydration completes.
([#2194](#2194))

    This fixes the `cannot convert to object` error.

- Remove element api calls alog by default, and only enable it when
`__ALOG_ELEMENT_API__` is defined to `true` or environment variable
`REACT_ALOG_ELEMENT_API` is set to `true`.
([#2192](#2192))

- fix: captured variables in main thread functions within class
components do not update correctly
([#2197](#2197))

## @lynx-js/rspeedy@0.13.4

### Patch Changes

- Bump ts-blank-space v0.7.0
([#2238](#2238))

- Bump Rsbuild v1.7.3 with Rspack v1.7.5.
([#2189](#2189))

-   Updated dependencies \[]:
    -   @lynx-js/web-rsbuild-server-middleware@0.19.8

## @lynx-js/qrcode-rsbuild-plugin@0.4.5

### Patch Changes

- Only register console shortcuts when running in TTY environments
([#2202](#2202))

## @lynx-js/react-rsbuild-plugin@0.12.8

### Patch Changes

- Updated dependencies
\[[`4240138`](4240138)]:
    -   @lynx-js/react-webpack-plugin@0.7.4
    -   @lynx-js/react-alias-rsbuild-plugin@0.12.8
    -   @lynx-js/use-sync-external-store@1.5.0
    -   @lynx-js/react-refresh-webpack-plugin@0.3.4
    -   @lynx-js/template-webpack-plugin@0.10.3

## @lynx-js/testing-environment@0.1.11

### Patch Changes

- Remove element api calls alog by default, and only enable it when
`__ALOG_ELEMENT_API__` is defined to `true` or environment variable
`REACT_ALOG_ELEMENT_API` is set to `true`.
([#2192](#2192))

## @lynx-js/web-constants@0.19.8

### Patch Changes

-   Updated dependencies \[]:
    -   @lynx-js/web-worker-rpc@0.19.8

## @lynx-js/web-core@0.19.8

### Patch Changes

- fix: avoid error when LynxView is removed immediately after connected
([#2182](#2182))

-   Updated dependencies \[]:
    -   @lynx-js/web-constants@0.19.8
    -   @lynx-js/web-mainthread-apis@0.19.8
    -   @lynx-js/web-worker-rpc@0.19.8
    -   @lynx-js/web-worker-runtime@0.19.8

## @lynx-js/web-core-wasm@0.0.3

### Patch Changes

- Updated dependencies
\[[`e0972ef`](e0972ef),
[`3bc017e`](3bc017e),
[`e2d349e`](e2d349e),
[`d924b6a`](d924b6a)]:
    -   @lynx-js/web-elements@0.11.2
    -   @lynx-js/web-worker-rpc@0.19.8

## @lynx-js/web-elements@0.11.2

### Patch Changes

- Add scrollHeight/scrollWidth getters to XList.
([#2156](#2156))

- Inherit padding styles for x-input elements.
([#2199](#2199))

- Remove the default lazy-loading attribute from x-image elements.
([#2186](#2186))

- Fix x-input number type forwarding to the inner input element.
([#2193](#2193))

## @lynx-js/web-mainthread-apis@0.19.8

### Patch Changes

-   Updated dependencies \[]:
    -   @lynx-js/web-constants@0.19.8

## @lynx-js/web-worker-runtime@0.19.8

### Patch Changes

-   Updated dependencies \[]:
    -   @lynx-js/web-constants@0.19.8
    -   @lynx-js/web-mainthread-apis@0.19.8
    -   @lynx-js/web-worker-rpc@0.19.8

## @lynx-js/react-webpack-plugin@0.7.4

### Patch Changes

- Remove element api calls alog by default, and only enable it when
`__ALOG_ELEMENT_API__` is defined to `true` or environment variable
`REACT_ALOG_ELEMENT_API` is set to `true`.
([#2192](#2192))

## create-rspeedy@0.13.4



## @lynx-js/react-alias-rsbuild-plugin@0.12.8



## upgrade-rspeedy@0.13.4



## @lynx-js/web-core-server@0.19.8



## @lynx-js/web-rsbuild-server-middleware@0.19.8



## @lynx-js/web-worker-rpc@0.19.8

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants