fix: Remove default lazy loading from x-image by Copilot · Pull Request #2186 · lynx-family/lynx-stack

Copilot · 2026-02-02T09:02:30Z

x-image should no longer force lazy loading on its internal <img>. This updates the default template behavior and verifies the attribute stays absent.

Template changes
- Remove the loading="lazy" attribute from the shared image template used by x-image and filter-image.
Coverage
- Add a Playwright assertion to ensure the internal <img> does not have a loading attribute by default.

const img = xImage?.shadowRoot?.querySelector('#img');
expect(img?.getAttribute('loading')).toBeNull();

Release metadata
- Add a patch changeset for @lynx-js/web-elements describing the lazy-loading removal.
Screenshot

[!WARNING]

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

changeset-bot · 2026-02-02T09:02:36Z

🦋 Changeset detected

Latest commit: 5c5d877

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@lynx-js/web-elements	Patch
@lynx-js/web-core-wasm	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Co-authored-by: PupilTong <12288479+PupilTong@users.noreply.github.com>

coderabbitai · 2026-02-02T09:54:36Z

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🔍 Trigger a full review

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

PupilTong · 2026-02-02T09:57:17Z

@copilot add a patch changeset

codecov · 2026-02-02T09:58:28Z

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...latform/web-elements/src/elements/htmlTemplates.ts	0.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

codspeed-hq · 2026-02-02T10:08:27Z

CodSpeed Performance Report

Merging this PR will not alter performance

_{Comparing copilot/remove-loading-lazy-x-image (5c5d877) with main (6ec0b1d)}

Summary

✅ 63 untouched benchmarks
⏩ 3 skipped benchmarks¹

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Co-authored-by: PupilTong <12288479+PupilTong@users.noreply.github.com>

Copilot · 2026-02-02T10:12:29Z

@copilot add a patch changeset

Added a patch changeset for @lynx-js/web-elements in commit 5c5d877. Screenshot: https://github.com/user-attachments/assets/21fd34bb-64fc-45d1-9ee5-810798595e00

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

esm.ubuntu.com
- Triggering command: /usr/lib/apt/methods/https /usr/lib/apt/methods/https (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @lynx-js/motion@0.0.3 ### Patch Changes - Fix an issue that motion/mini will accidentally imports full version, causing compiling error ([#2204](#2204)) ## @lynx-js/react@0.116.3 ### Patch Changes - fix: remove `lynx.createSelectorQuery` deprecated warning in production ([#2195](#2195)) - Add a DEV-only guard that detects MainThread flush loops caused by re-entrant MTS handlers. ([#2159](#2159)) This typically happens when a MainThread handler (e.g. event callback or `MainThreadRef`) performs UI mutations (like `Element.setStyleProperty`, `setStyleProperties`, `setAttribute`, or `invoke`) that synchronously trigger a flush which re-enters the handler again. - Avoid DEV_ONLY_SetSnapshotEntryName on standalone lazy bundle. ([#2184](#2184)) - Add alog and trace for BTS event handlers. ([#2102](#2102)) - fix: Main thread functions cannot access properties on `this` before hydration completes. ([#2194](#2194)) This fixes the `cannot convert to object` error. - Remove element api calls alog by default, and only enable it when `__ALOG_ELEMENT_API__` is defined to `true` or environment variable `REACT_ALOG_ELEMENT_API` is set to `true`. ([#2192](#2192)) - fix: captured variables in main thread functions within class components do not update correctly ([#2197](#2197)) ## @lynx-js/rspeedy@0.13.4 ### Patch Changes - Bump ts-blank-space v0.7.0 ([#2238](#2238)) - Bump Rsbuild v1.7.3 with Rspack v1.7.5. ([#2189](#2189)) - Updated dependencies \[]: - @lynx-js/web-rsbuild-server-middleware@0.19.8 ## @lynx-js/qrcode-rsbuild-plugin@0.4.5 ### Patch Changes - Only register console shortcuts when running in TTY environments ([#2202](#2202)) ## @lynx-js/react-rsbuild-plugin@0.12.8 ### Patch Changes - Updated dependencies \[[`4240138`](4240138)]: - @lynx-js/react-webpack-plugin@0.7.4 - @lynx-js/react-alias-rsbuild-plugin@0.12.8 - @lynx-js/use-sync-external-store@1.5.0 - @lynx-js/react-refresh-webpack-plugin@0.3.4 - @lynx-js/template-webpack-plugin@0.10.3 ## @lynx-js/testing-environment@0.1.11 ### Patch Changes - Remove element api calls alog by default, and only enable it when `__ALOG_ELEMENT_API__` is defined to `true` or environment variable `REACT_ALOG_ELEMENT_API` is set to `true`. ([#2192](#2192)) ## @lynx-js/web-constants@0.19.8 ### Patch Changes - Updated dependencies \[]: - @lynx-js/web-worker-rpc@0.19.8 ## @lynx-js/web-core@0.19.8 ### Patch Changes - fix: avoid error when LynxView is removed immediately after connected ([#2182](#2182)) - Updated dependencies \[]: - @lynx-js/web-constants@0.19.8 - @lynx-js/web-mainthread-apis@0.19.8 - @lynx-js/web-worker-rpc@0.19.8 - @lynx-js/web-worker-runtime@0.19.8 ## @lynx-js/web-core-wasm@0.0.3 ### Patch Changes - Updated dependencies \[[`e0972ef`](e0972ef), [`3bc017e`](3bc017e), [`e2d349e`](e2d349e), [`d924b6a`](d924b6a)]: - @lynx-js/web-elements@0.11.2 - @lynx-js/web-worker-rpc@0.19.8 ## @lynx-js/web-elements@0.11.2 ### Patch Changes - Add scrollHeight/scrollWidth getters to XList. ([#2156](#2156)) - Inherit padding styles for x-input elements. ([#2199](#2199)) - Remove the default lazy-loading attribute from x-image elements. ([#2186](#2186)) - Fix x-input number type forwarding to the inner input element. ([#2193](#2193)) ## @lynx-js/web-mainthread-apis@0.19.8 ### Patch Changes - Updated dependencies \[]: - @lynx-js/web-constants@0.19.8 ## @lynx-js/web-worker-runtime@0.19.8 ### Patch Changes - Updated dependencies \[]: - @lynx-js/web-constants@0.19.8 - @lynx-js/web-mainthread-apis@0.19.8 - @lynx-js/web-worker-rpc@0.19.8 ## @lynx-js/react-webpack-plugin@0.7.4 ### Patch Changes - Remove element api calls alog by default, and only enable it when `__ALOG_ELEMENT_API__` is defined to `true` or environment variable `REACT_ALOG_ELEMENT_API` is set to `true`. ([#2192](#2192)) ## create-rspeedy@0.13.4 ## @lynx-js/react-alias-rsbuild-plugin@0.12.8 ## upgrade-rspeedy@0.13.4 ## @lynx-js/web-core-server@0.19.8 ## @lynx-js/web-rsbuild-server-middleware@0.19.8 ## @lynx-js/web-worker-rpc@0.19.8 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Initial plan

925730c

Copilot AI assigned Copilot and PupilTong Feb 2, 2026

Copilot started work on behalf of PupilTong February 2, 2026 09:02 View session

remove lazy loading from x-image

fbd8825

Co-authored-by: PupilTong <12288479+PupilTong@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Remove loading="lazy" for x-image~~ Remove default lazy loading from x-image Feb 2, 2026

Copilot AI requested a review from PupilTong February 2, 2026 09:50

Copilot finished work on behalf of PupilTong February 2, 2026 09:50

PupilTong marked this pull request as ready for review February 2, 2026 09:54

PupilTong requested a review from Sherry-hue as a code owner February 2, 2026 09:54

PupilTong added this to Lynx for Web Feb 2, 2026

Sherry-hue previously approved these changes Feb 2, 2026

View reviewed changes

Copilot started work on behalf of PupilTong February 2, 2026 09:57 View session

chore: add changeset for x-image lazy loading removal

5c5d877

Co-authored-by: PupilTong <12288479+PupilTong@users.noreply.github.com>

Copilot AI dismissed Sherry-hue’s stale review via 5c5d877 February 2, 2026 10:12

Copilot finished work on behalf of PupilTong February 2, 2026 10:13

PupilTong changed the title ~~Remove default lazy loading from x-image~~ fix: Remove default lazy loading from x-image Feb 2, 2026

PupilTong requested a review from Sherry-hue February 2, 2026 12:40

PupilTong enabled auto-merge (squash) February 2, 2026 12:49

PupilTong approved these changes Feb 2, 2026

View reviewed changes

Sherry-hue approved these changes Feb 3, 2026

View reviewed changes

PupilTong merged commit e2d349e into main Feb 3, 2026
40 of 44 checks passed

PupilTong deleted the copilot/remove-loading-lazy-x-image branch February 3, 2026 03:29

github-project-automation bot moved this to Done in Lynx for Web Feb 3, 2026

github-actions bot mentioned this pull request Feb 2, 2026

chore: Release 2026-02-21 04:23:50 #2183

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Remove default lazy loading from x-image#2186

fix: Remove default lazy loading from x-image#2186
PupilTong merged 3 commits intomainfrom
copilot/remove-loading-lazy-x-image

Copilot AI commented Feb 2, 2026 •

edited

Loading

Uh oh!

changeset-bot bot commented Feb 2, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Feb 2, 2026

Review skipped

Uh oh!

PupilTong commented Feb 2, 2026

Uh oh!

codecov bot commented Feb 2, 2026 •

edited

Loading

Uh oh!

codspeed-hq bot commented Feb 2, 2026 •

edited

Loading

Uh oh!

Copilot AI commented Feb 2, 2026 •

edited

Loading

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai bot commented Feb 2, 2026

Review skipped

Uh oh!

PupilTong commented Feb 2, 2026

Uh oh!

codecov bot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codspeed-hq bot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging this PR will not alter performance

Summary

Footnotes

Uh oh!

Copilot AI commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Feb 2, 2026 •

edited

Loading

changeset-bot bot commented Feb 2, 2026 •

edited

Loading

codecov bot commented Feb 2, 2026 •

edited

Loading

codspeed-hq bot commented Feb 2, 2026 •

edited

Loading

Copilot AI commented Feb 2, 2026 •

edited

Loading