fix: avoid DEV_ONLY_SetSnapshotEntryName on standalone lazy bundle by upupming · Pull Request #2184 · lynx-family/lynx-stack

upupming · 2026-02-02T07:47:42Z

Summary by CodeRabbit

Same as #2048, we should not apply DEV_ONLY_SetSnapshotEntryName for standalone lazy bundle.

Patch Release

Bug Fixes
- Fixed snapshot handling for standalone lazy bundles by preventing unnecessary patch generation during hydration cycles.

Checklist

Tests updated (or not required).
Documentation updated (or not required).
Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

changeset-bot · 2026-02-02T07:47:47Z

🦋 Changeset detected

Latest commit: 4c43ef1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@lynx-js/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-02-02T07:47:49Z

📝 Walkthrough

Walkthrough

This patch adds a constraint to snapshot creation logic to skip DEV_ONLY_SetSnapshotEntryName emission for standalone lazy bundles (identified by colons in uniqID). A test is updated to verify the new behavior, and a changeset documents the patch release.

Changes

Cohort / File(s)	Summary
Changeset `.changeset/fast-bears-relate.md`	New patch release entry for "@Lynx-js/react" noting the DEV_ONLY_SetSnapshotEntryName behavior change for standalone lazy bundles.
Snapshot Logic `packages/react/runtime/src/snapshot.ts`	Modified createSnapshot to add a guard condition preventing DEV_ONLY_SetSnapshotEntryName emission when uniqID contains a colon (standalone lazy bundle scenario).
Test Coverage `packages/react/runtime/__test__/snapshotPatch.test.jsx`	Refactored test to use explicit uniqID variable and verify that no global snapshot patch is generated for standalone lazy bundle contexts with stubbed JS global.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

fix: undefined factory error when loading a standalone lazy bundle after hydration #2048: Modifies the same snapshot emission logic in snapshot.ts to skip producing global snapshot patches for standalone lazy-bundle keys containing a colon.
fix: lazy bundle HMR set correct entryName #2134: Related through snapshot handling for lazy bundles; the main PR's colon-based guard complements that PR's SetSnapshotEntryName emission logic.
fix(webpack/external): globDynamicComponentEntry is not defined #2058: Both PRs interact with globDynamicComponentEntry handling in snapshot/runtime code, touching the same semantic patterns.

Suggested labels

framework:React

Suggested reviewers

HuJean
hzy

Poem

🐰 A colon in the path reveals the way,
Lazy bundles bundled, snapshots saved the day,
Guards protect from patches gone astray,
Tests confirm the logic holds its sway,
With whiskers twitched, the patch is here to stay! 📸

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The pull request title accurately describes the main change: adding a check to prevent DEV_ONLY_SetSnapshotEntryName from being called on standalone lazy bundles.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/avoid-DEV_ONLY_SetSnapshotEntryName

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-02-02T07:52:30Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

codspeed-hq · 2026-02-02T08:02:36Z

CodSpeed Performance Report

Merging this PR will not alter performance

_{Comparing fix/avoid-DEV_ONLY_SetSnapshotEntryName (4c43ef1) with main (9b69730)}

Summary

✅ 63 untouched benchmarks
⏩ 3 skipped benchmarks¹

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

relativeci · 2026-02-02T08:07:47Z

Web Explorer

#7509 Bundle Size — 383.58KiB (0%).

4c43ef1(current) vs 9b69730 main#7508(baseline)

Bundle metrics

1 change

	Current #7509	Baseline #7508
Initial JS	`154.73KiB`	`154.73KiB`
Initial CSS	`35.05KiB`	`35.05KiB`
Cache Invalidation	`0%`	`40.34%`
Chunks	`8`	`8`
Assets	`8`	`8`
Modules	`237`(`-0.42%`)	`238`
Duplicate Modules	`16`	`16`
Duplicate Code	`2.99%`	`2.99%`
Packages	`4`	`4`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #7509	Baseline #7508
JS	`252.68KiB`	`252.68KiB`
Other	`95.85KiB`	`95.85KiB`
CSS	`35.05KiB`	`35.05KiB`

Bundle analysis report Branch fix/avoid-DEV_ONLY_SetSnapshotEn... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @lynx-js/motion@0.0.3 ### Patch Changes - Fix an issue that motion/mini will accidentally imports full version, causing compiling error ([#2204](#2204)) ## @lynx-js/react@0.116.3 ### Patch Changes - fix: remove `lynx.createSelectorQuery` deprecated warning in production ([#2195](#2195)) - Add a DEV-only guard that detects MainThread flush loops caused by re-entrant MTS handlers. ([#2159](#2159)) This typically happens when a MainThread handler (e.g. event callback or `MainThreadRef`) performs UI mutations (like `Element.setStyleProperty`, `setStyleProperties`, `setAttribute`, or `invoke`) that synchronously trigger a flush which re-enters the handler again. - Avoid DEV_ONLY_SetSnapshotEntryName on standalone lazy bundle. ([#2184](#2184)) - Add alog and trace for BTS event handlers. ([#2102](#2102)) - fix: Main thread functions cannot access properties on `this` before hydration completes. ([#2194](#2194)) This fixes the `cannot convert to object` error. - Remove element api calls alog by default, and only enable it when `__ALOG_ELEMENT_API__` is defined to `true` or environment variable `REACT_ALOG_ELEMENT_API` is set to `true`. ([#2192](#2192)) - fix: captured variables in main thread functions within class components do not update correctly ([#2197](#2197)) ## @lynx-js/rspeedy@0.13.4 ### Patch Changes - Bump ts-blank-space v0.7.0 ([#2238](#2238)) - Bump Rsbuild v1.7.3 with Rspack v1.7.5. ([#2189](#2189)) - Updated dependencies \[]: - @lynx-js/web-rsbuild-server-middleware@0.19.8 ## @lynx-js/qrcode-rsbuild-plugin@0.4.5 ### Patch Changes - Only register console shortcuts when running in TTY environments ([#2202](#2202)) ## @lynx-js/react-rsbuild-plugin@0.12.8 ### Patch Changes - Updated dependencies \[[`4240138`](4240138)]: - @lynx-js/react-webpack-plugin@0.7.4 - @lynx-js/react-alias-rsbuild-plugin@0.12.8 - @lynx-js/use-sync-external-store@1.5.0 - @lynx-js/react-refresh-webpack-plugin@0.3.4 - @lynx-js/template-webpack-plugin@0.10.3 ## @lynx-js/testing-environment@0.1.11 ### Patch Changes - Remove element api calls alog by default, and only enable it when `__ALOG_ELEMENT_API__` is defined to `true` or environment variable `REACT_ALOG_ELEMENT_API` is set to `true`. ([#2192](#2192)) ## @lynx-js/web-constants@0.19.8 ### Patch Changes - Updated dependencies \[]: - @lynx-js/web-worker-rpc@0.19.8 ## @lynx-js/web-core@0.19.8 ### Patch Changes - fix: avoid error when LynxView is removed immediately after connected ([#2182](#2182)) - Updated dependencies \[]: - @lynx-js/web-constants@0.19.8 - @lynx-js/web-mainthread-apis@0.19.8 - @lynx-js/web-worker-rpc@0.19.8 - @lynx-js/web-worker-runtime@0.19.8 ## @lynx-js/web-core-wasm@0.0.3 ### Patch Changes - Updated dependencies \[[`e0972ef`](e0972ef), [`3bc017e`](3bc017e), [`e2d349e`](e2d349e), [`d924b6a`](d924b6a)]: - @lynx-js/web-elements@0.11.2 - @lynx-js/web-worker-rpc@0.19.8 ## @lynx-js/web-elements@0.11.2 ### Patch Changes - Add scrollHeight/scrollWidth getters to XList. ([#2156](#2156)) - Inherit padding styles for x-input elements. ([#2199](#2199)) - Remove the default lazy-loading attribute from x-image elements. ([#2186](#2186)) - Fix x-input number type forwarding to the inner input element. ([#2193](#2193)) ## @lynx-js/web-mainthread-apis@0.19.8 ### Patch Changes - Updated dependencies \[]: - @lynx-js/web-constants@0.19.8 ## @lynx-js/web-worker-runtime@0.19.8 ### Patch Changes - Updated dependencies \[]: - @lynx-js/web-constants@0.19.8 - @lynx-js/web-mainthread-apis@0.19.8 - @lynx-js/web-worker-rpc@0.19.8 ## @lynx-js/react-webpack-plugin@0.7.4 ### Patch Changes - Remove element api calls alog by default, and only enable it when `__ALOG_ELEMENT_API__` is defined to `true` or environment variable `REACT_ALOG_ELEMENT_API` is set to `true`. ([#2192](#2192)) ## create-rspeedy@0.13.4 ## @lynx-js/react-alias-rsbuild-plugin@0.12.8 ## upgrade-rspeedy@0.13.4 ## @lynx-js/web-core-server@0.19.8 ## @lynx-js/web-rsbuild-server-middleware@0.19.8 ## @lynx-js/web-worker-rpc@0.19.8 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

fix: avoid DEV_ONLY_SetSnapshotEntryName on standalone lazy bundle

4c43ef1

upupming marked this pull request as ready for review February 2, 2026 07:47

upupming requested review from HuJean and hzy as code owners February 2, 2026 07:47

HuJean approved these changes Feb 2, 2026

View reviewed changes

coderabbitai bot added the framework:React label Feb 2, 2026

upupming merged commit b849248 into main Feb 2, 2026
51 checks passed

upupming deleted the fix/avoid-DEV_ONLY_SetSnapshotEntryName branch February 2, 2026 08:13

github-actions bot mentioned this pull request Feb 2, 2026

chore: Release 2026-02-21 04:23:50 #2183

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: avoid DEV_ONLY_SetSnapshotEntryName on standalone lazy bundle#2184

fix: avoid DEV_ONLY_SetSnapshotEntryName on standalone lazy bundle#2184
upupming merged 1 commit intomainfrom
fix/avoid-DEV_ONLY_SetSnapshotEntryName

upupming commented Feb 2, 2026 •

edited

Loading

Uh oh!

changeset-bot bot commented Feb 2, 2026

Uh oh!

coderabbitai bot commented Feb 2, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Uh oh!

codecov bot commented Feb 2, 2026

Uh oh!

codspeed-hq bot commented Feb 2, 2026

Uh oh!

relativeci bot commented Feb 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

upupming commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Patch Release

Checklist

Uh oh!

changeset-bot bot commented Feb 2, 2026

🦋 Changeset detected

Uh oh!

coderabbitai bot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Uh oh!

codecov bot commented Feb 2, 2026

Codecov Report

Uh oh!

codspeed-hq bot commented Feb 2, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Summary

Footnotes

Uh oh!

relativeci bot commented Feb 2, 2026

Web Explorer

#7509 Bundle Size — 383.58KiB (0%).

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

upupming commented Feb 2, 2026 •

edited

Loading

coderabbitai bot commented Feb 2, 2026 •

edited

Loading