fix: avoid error when LynxView is removed immediately after connected by Sherry-hue · Pull Request #2182 · lynx-family/lynx-stack

Sherry-hue · 2026-02-02T03:59:39Z

Summary by CodeRabbit

Bug Fixes
- Prevented an error when a LynxView is removed immediately after being connected, improving stability during rapid lifecycle changes.
Tests
- Added a test to ensure no errors occur when a view is connected and then immediately disconnected, preventing regressions.

Checklist

Tests updated (or not required).
Documentation updated (or not required).
Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

changeset-bot · 2026-02-02T03:59:44Z

🦋 Changeset detected

Latest commit: ad83192

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages

Name	Type
@lynx-js/web-core	Patch
upgrade-rspeedy	Patch
@lynx-js/web-rsbuild-server-middleware	Patch
@lynx-js/web-core-server	Patch
@lynx-js/web-constants	Patch
@lynx-js/web-mainthread-apis	Patch
@lynx-js/web-worker-rpc	Patch
@lynx-js/web-worker-runtime	Patch
@lynx-js/rspeedy	Patch
@lynx-js/web-core-wasm	Patch
create-rspeedy	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-02-02T03:59:59Z

📝 Walkthrough

Walkthrough

Replaces internal connectivity tracking in LynxView with the DOM isConnected check, adds an early return in render flow to avoid work when the element is no longer connected, adds a test reproducing removal immediately after connect, and adds a changeset bump for the patch release.

Changes

Cohort / File(s)	Summary
Changeset `\.changeset/fix-web-core-lynxview-disconnect.md`	Adds a patch changeset entry documenting "fix: avoid error when LynxView is removed immediately after connected".
LynxView implementation `packages/web-platform/web-core/src/apis/LynxView.ts`	Removes use of a private `#connected` flag; uses `this.isConnected` instead, removes explicit `#connected` updates, and adds an early return in render scheduling to skip post-render work when the element is not connected.
Tests `packages/web-platform/web-tests/tests/web-core.test.ts`	Adds test "should not throw error when removed immediately after connected" that connects and immediately disconnects a LynxView and asserts no page errors occur.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

fix(web): fix: && use getter to get. #1466 — Modifies LynxView render/connection handling similarly; likely overlaps in render/connection changes.

Suggested reviewers

PupilTong
colinaaa

Poem

🐰 I hopped in quick, then slipped away,
The view unmounted in a single day.
No panic, no crash, I twitched my nose,
Render skipped where the cold wind blows.
A tidy fix, and on we go! 🥕

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and accurately summarizes the main change: fixing an error when LynxView is removed immediately after connected. It directly matches the core issue being addressed across all modified files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-02-02T04:04:19Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

codspeed-hq · 2026-02-02T04:15:06Z

CodSpeed Performance Report

Merging this PR will improve performance by 11.31%

_{Comparing Sherry-hue:fix/web-core-lynxview-disconnect (ad83192) with main (3cdf389)}

Summary

⚡ 1 improved benchmark
✅ 62 untouched benchmarks
⏩ 3 skipped benchmarks¹

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	`transform 1000 view elements`	47.5 ms	42.7 ms	+11.31%

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

relativeci · 2026-02-02T04:18:09Z

Web Explorer

#7507 Bundle Size — 383.58KiB (~+0.01%).

ad83192(current) vs 3cdf389 main#7496(baseline)

Bundle metrics

3 changes

1 regression

	Current #7507	Baseline #7496
Initial JS	`154.73KiB`(`+0.01%`)	`154.71KiB`
Initial CSS	`35.05KiB`	`35.05KiB`
Cache Invalidation	`40.34%`	`0%`
Chunks	`8`	`8`
Assets	`8`	`8`
Modules	`238`(`-0.42%`)	`239`
Duplicate Modules	`16`	`16`
Duplicate Code	`2.99%`	`2.99%`
Packages	`4`	`4`
Duplicate Packages	`0`	`0`

Bundle size by type

1 change

1 regression

	Current #7507	Baseline #7496
JS	`252.68KiB` (`~+0.01%`)	`252.66KiB`
Other	`95.85KiB`	`95.85KiB`
CSS	`35.05KiB`	`35.05KiB`

Bundle analysis report Branch Sherry-hue:fix/web-core-lynxview... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @lynx-js/motion@0.0.3 ### Patch Changes - Fix an issue that motion/mini will accidentally imports full version, causing compiling error ([#2204](#2204)) ## @lynx-js/react@0.116.3 ### Patch Changes - fix: remove `lynx.createSelectorQuery` deprecated warning in production ([#2195](#2195)) - Add a DEV-only guard that detects MainThread flush loops caused by re-entrant MTS handlers. ([#2159](#2159)) This typically happens when a MainThread handler (e.g. event callback or `MainThreadRef`) performs UI mutations (like `Element.setStyleProperty`, `setStyleProperties`, `setAttribute`, or `invoke`) that synchronously trigger a flush which re-enters the handler again. - Avoid DEV_ONLY_SetSnapshotEntryName on standalone lazy bundle. ([#2184](#2184)) - Add alog and trace for BTS event handlers. ([#2102](#2102)) - fix: Main thread functions cannot access properties on `this` before hydration completes. ([#2194](#2194)) This fixes the `cannot convert to object` error. - Remove element api calls alog by default, and only enable it when `__ALOG_ELEMENT_API__` is defined to `true` or environment variable `REACT_ALOG_ELEMENT_API` is set to `true`. ([#2192](#2192)) - fix: captured variables in main thread functions within class components do not update correctly ([#2197](#2197)) ## @lynx-js/rspeedy@0.13.4 ### Patch Changes - Bump ts-blank-space v0.7.0 ([#2238](#2238)) - Bump Rsbuild v1.7.3 with Rspack v1.7.5. ([#2189](#2189)) - Updated dependencies \[]: - @lynx-js/web-rsbuild-server-middleware@0.19.8 ## @lynx-js/qrcode-rsbuild-plugin@0.4.5 ### Patch Changes - Only register console shortcuts when running in TTY environments ([#2202](#2202)) ## @lynx-js/react-rsbuild-plugin@0.12.8 ### Patch Changes - Updated dependencies \[[`4240138`](4240138)]: - @lynx-js/react-webpack-plugin@0.7.4 - @lynx-js/react-alias-rsbuild-plugin@0.12.8 - @lynx-js/use-sync-external-store@1.5.0 - @lynx-js/react-refresh-webpack-plugin@0.3.4 - @lynx-js/template-webpack-plugin@0.10.3 ## @lynx-js/testing-environment@0.1.11 ### Patch Changes - Remove element api calls alog by default, and only enable it when `__ALOG_ELEMENT_API__` is defined to `true` or environment variable `REACT_ALOG_ELEMENT_API` is set to `true`. ([#2192](#2192)) ## @lynx-js/web-constants@0.19.8 ### Patch Changes - Updated dependencies \[]: - @lynx-js/web-worker-rpc@0.19.8 ## @lynx-js/web-core@0.19.8 ### Patch Changes - fix: avoid error when LynxView is removed immediately after connected ([#2182](#2182)) - Updated dependencies \[]: - @lynx-js/web-constants@0.19.8 - @lynx-js/web-mainthread-apis@0.19.8 - @lynx-js/web-worker-rpc@0.19.8 - @lynx-js/web-worker-runtime@0.19.8 ## @lynx-js/web-core-wasm@0.0.3 ### Patch Changes - Updated dependencies \[[`e0972ef`](e0972ef), [`3bc017e`](3bc017e), [`e2d349e`](e2d349e), [`d924b6a`](d924b6a)]: - @lynx-js/web-elements@0.11.2 - @lynx-js/web-worker-rpc@0.19.8 ## @lynx-js/web-elements@0.11.2 ### Patch Changes - Add scrollHeight/scrollWidth getters to XList. ([#2156](#2156)) - Inherit padding styles for x-input elements. ([#2199](#2199)) - Remove the default lazy-loading attribute from x-image elements. ([#2186](#2186)) - Fix x-input number type forwarding to the inner input element. ([#2193](#2193)) ## @lynx-js/web-mainthread-apis@0.19.8 ### Patch Changes - Updated dependencies \[]: - @lynx-js/web-constants@0.19.8 ## @lynx-js/web-worker-runtime@0.19.8 ### Patch Changes - Updated dependencies \[]: - @lynx-js/web-constants@0.19.8 - @lynx-js/web-mainthread-apis@0.19.8 - @lynx-js/web-worker-rpc@0.19.8 ## @lynx-js/react-webpack-plugin@0.7.4 ### Patch Changes - Remove element api calls alog by default, and only enable it when `__ALOG_ELEMENT_API__` is defined to `true` or environment variable `REACT_ALOG_ELEMENT_API` is set to `true`. ([#2192](#2192)) ## create-rspeedy@0.13.4 ## @lynx-js/react-alias-rsbuild-plugin@0.12.8 ## upgrade-rspeedy@0.13.4 ## @lynx-js/web-core-server@0.19.8 ## @lynx-js/web-rsbuild-server-middleware@0.19.8 ## @lynx-js/web-worker-rpc@0.19.8 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Sherry-hue self-assigned this Feb 2, 2026

Sherry-hue added this to Lynx for Web Feb 2, 2026

Sherry-hue requested a review from PupilTong as a code owner February 2, 2026 03:59

Sherry-hue added the platform:Web label Feb 2, 2026

fix: avoid error when LynxView is removed immediately after connected

ad83192

Sherry-hue force-pushed the fix/web-core-lynxview-disconnect branch from d4f88de to ad83192 Compare February 2, 2026 04:22

PupilTong approved these changes Feb 2, 2026

View reviewed changes

Sherry-hue merged commit 9b69730 into lynx-family:main Feb 2, 2026
46 checks passed

github-project-automation bot moved this to Done in Lynx for Web Feb 2, 2026

github-actions bot mentioned this pull request Feb 2, 2026

chore: Release 2026-02-21 04:23:50 #2183

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: avoid error when LynxView is removed immediately after connected#2182

fix: avoid error when LynxView is removed immediately after connected#2182
Sherry-hue merged 1 commit intolynx-family:mainfrom
Sherry-hue:fix/web-core-lynxview-disconnect

Sherry-hue commented Feb 2, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Feb 2, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Feb 2, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

codecov bot commented Feb 2, 2026

Uh oh!

codspeed-hq bot commented Feb 2, 2026 •

edited

Loading

Uh oh!

relativeci bot commented Feb 2, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Sherry-hue commented Feb 2, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Checklist

Uh oh!

changeset-bot bot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai bot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

codecov bot commented Feb 2, 2026

Codecov Report

Uh oh!

codspeed-hq bot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging this PR will improve performance by 11.31%

Summary

Performance Changes

Footnotes

Uh oh!

relativeci bot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Web Explorer

#7507 Bundle Size — 383.58KiB (~+0.01%).

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Sherry-hue commented Feb 2, 2026 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Feb 2, 2026 •

edited

Loading

coderabbitai bot commented Feb 2, 2026 •

edited

Loading

codspeed-hq bot commented Feb 2, 2026 •

edited

Loading

relativeci bot commented Feb 2, 2026 •

edited

Loading