Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement page (or maybe called breath) edit mode in the lyric editor. #1766

Closed
andy840119 opened this issue Nov 27, 2022 · 10 comments
Closed
Labels
enhancement New feature or request
Milestone

Comments

@andy840119
Copy link
Member

andy840119 commented Nov 27, 2022

Inspired from #1764

https://youtu.be/alR4Ac9evFg?t=93
Should be useful to create "page mode" in the lyric editor.
Same page means user can sing the lyric with one breath.
Usually between 1~4 lyrics.

Benefit:

  • Might let user not confused if they can see the page in the layout editor. It might be useful if user can decide the lyric position by breath.
    • classic layout 可能會根據這個規則進行格式設計
  • Will be used in the scrolling layout mode.
  • 未來的 layout 可以根據 page 進行參考
@andy840119 andy840119 added the enhancement New feature or request label Nov 27, 2022
@andy840119
Copy link
Member Author

需要思考:

  • 如果有遇到多個 singer 輪流唱歌詞,可能會遇到 page 跳號的問題,或許應該要有 checks 來檢查這件事情

@andy840119
Copy link
Member Author

andy840119 commented Nov 27, 2022

Maybe can use page number * magic number(e.g. 21) % 360 to get the hue number

@andy840119
Copy link
Member Author

Wait
Page can be designed as control point
Should be better to do that?

@andy840119
Copy link
Member Author

andy840119 commented Nov 30, 2022

If add the check:

@andy840119
Copy link
Member Author

andy840119 commented Dec 9, 2022

Also, should move those classes into more generic location:

@andy840119
Copy link
Member Author

andy840119 commented Dec 10, 2022

Should prepare:

Should implement those edit sections:

@andy840119
Copy link
Member Author

andy840119 commented Dec 15, 2022

  • Also, should write the generator for the page editor.

@andy840119
Copy link
Member Author

andy840119 commented Dec 18, 2022

image
Need to make some improvements:

  • Should be able to drag the time to change the page to change the time. -> Implemented in the Improve the page editor. #1802.
  • Should be able to click the page-related issue to select the blueprint.
  • Should be able to click the lyric-related issue to select the blueprint.
  • Should show the time marker. Not really sure should follow recording or adjust time-tag did?
  • Fix the pages order is not correct(both section and the blueprint container). -> Implemented in the Improve the page editor. #1802.
  • Add the create and remove botton at the bottom right of the page editor.
  • [Optional] Show the zoom level at the bottom right of the page editor.
  • Separate the generate and the edit section.

@andy840119
Copy link
Member Author

阿不是
issue 怎麼會自己繁殖?

This was referenced Dec 18, 2022
@andy840119
Copy link
Member Author

Implemented, but not ready for use.

@andy840119 andy840119 added this to the 2024.0831 milestone Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant