Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement beatmap page checks. #1780

Merged
merged 8 commits into from
Dec 7, 2022
Merged

Implement beatmap page checks. #1780

merged 8 commits into from
Dec 7, 2022

Conversation

andy840119
Copy link
Member

Implement part of issue #1766.

What's done in this PR:

  • Change the get page rules. Should be able to get the page only if time is between two pages.
  • Implement the base check class for able to check the property from the karaoke beatmap.
  • Implement the base check test for able to test beatmap property-related check.
  • Implement the check for checking page info in the karaoke beatmap.

@andy840119 andy840119 added enhancement New feature or request code quality Improve code quality. labels Dec 7, 2022
@andy840119 andy840119 added this to the 2022.1231 milestone Dec 7, 2022
@andy840119 andy840119 mentioned this pull request Dec 7, 2022
Closed
@andy840119 andy840119 merged commit 34cb2b0 into karaoke-dev:master Dec 7, 2022
@andy840119 andy840119 deleted the implement-beatmap-page-checks branch December 7, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code quality Improve code quality. enhancement New feature or request size/XL
Projects
None yet
Milestone
2022.1231
Development

Successfully merging this pull request may close these issues.
1 participant
@andy840119