Implement page bottom timeline. #1800

andy840119 · 2022-12-18T01:59:30Z

What's done in this PR:

Create the generic editable time-line based selection blueprint, can be the part of Move the time-line part into more generic location. #1798
Implement the timeline area for the page editor (see Implement page (or maybe called breath) edit mode in the lyric editor. #1766).

This PR is the initial PR and guess might have improvement PRs after.

This class is focused on placing the object into timeline.

… initialize the scroll range.

Note that the lyric should not be selectable.

andy840119 added 10 commits December 18, 2022 09:54

Move some logic into the shared class.

336982b

This class is focused on placing the object into timeline.

Let time-tag related selection blueprint inherit the same base class.

d8551e4

Implement the method for able to get the order from the page info.

841a42a

Should be able to get the selected page from the page provider.

b26c8bf

Shoupld provide the scrolling info in the page state provider becasue…

d352e7f

… initialize the scroll range.

Implement the selection blueprint for lyric and the page.

ac79aed

Note that the lyric should not be selectable.

Implement the page blueprint container

a6acbf1

Implement the lyric blueprint container

17ec2d9

Implement the timeline.

31a3671

Apply into the page editor.

5cf354f

andy840119 added enhancement New feature or request code quality Improve code quality. labels Dec 18, 2022

andy840119 added this to the 2022.1231 milestone Dec 18, 2022

pull-request-size bot added the size/L label Dec 18, 2022

andy840119 merged commit 71bb619 into karaoke-dev:master Dec 18, 2022

andy840119 deleted the implement-page-bottom-timeline branch December 18, 2022 02:05

Provide feedback